Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 141445

Summary: xpak,py xsplit function return logic issue
Product: Portage Development Reporter: Chris White (RETIRED) <chriswhite>
Component: CoreAssignee: Portage team <dev-portage>
Status: RESOLVED FIXED    
Severity: normal Keywords: InVCS
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 136244    

Description Chris White (RETIRED) gentoo-dev 2006-07-22 16:25:19 UTC
Noted in sys-apps/portage-2.1.1_pre2-r1 and -r3991 SVN.  xsplit has the following code:

 splits = xsplit_mem(mydat)
        if not splits:
                return

and later on down:

        myfile.write(splits[1])
        myfile.close()
        return

This should be return false/true to be able to distinguish failure/success of the function.
Comment 1 Zac Medico gentoo-dev 2006-07-22 16:40:34 UTC
Thanks, in svn r4006 it now returns False on failure and True on success.
Comment 2 Zac Medico gentoo-dev 2006-07-23 15:00:23 UTC
This has been released in 2.1.1_pre3-r4.