Summary: | tarsync malloc failure | ||
---|---|---|---|
Product: | Portage Development | Reporter: | MATSUI Tetsushi <VED03370> |
Component: | Core | Assignee: | Zac Medico <zmedico> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ferringb |
Priority: | High | Keywords: | InVCS |
Version: | 2.1 | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 141388 | ||
Attachments: | strcmp fix |
Description
MATSUI Tetsushi
2006-07-15 22:37:32 UTC
emerge-webrsync in 2.1 has new support for tarsync and that seems to be where the problem is. What version of tarsync do you have? If you're using tarsync-0.1, could you upgrade to tarsync-0.2 to see if that helps? I've just tried upgrading tarsync and diffball. Unfortunately, tarsync-0.2 with diffball-1.0 produces the same error. I uninstalled tarsync, and then emerge-webrsync seems to work as before. Though, I don't think this is the resolution. I've reproduced the "malloc failure" locally with tarsync-0.2. need to mangle emerge-webrsync to report the tarball that failed... cause without that info bit hard fishing what failed (I'm getting no failures). finally, try a downgrade to 0.7.1 of diffball- doubt it has any affect, but the failure is the return from scandir (and till I get enough info to debug this, kind of stabbing in the dark). I've reproduced the problem updating to portage-20060717.tar.bz2 from a normal rsync tree that was last updated on 20060716. Diffball patch to get from 20060717 to the initial state: http://dev.gentoo.org/~zmedico/tmp/snapshot-20060717-20060716.patch.bz2 scanning tarball... cleansed 1 dups out of 145045 scanning existing target directory... removing node 'app-admin/skey/' skey-1.1.5-r3.ebuild' removing node 'app-admin/skey/' skey-1.1.5-r4.ebuild' removing node 'app-admin/skey/' skey-1.1.5-r5.ebuild' removing node 'app-admin/skey/files/' digest-skey-1.1.5-r3' removing node 'app-admin/skey/files/' digest-skey-1.1.5-r4' removing node 'app-admin/skey/files/' digest-skey-1.1.5-r5' removing node 'app-admin/skey/files/' skey-1.1.5-bind-now.patch' removing node 'app-admin/skey/files/' skey-1.1.5-fPIC.patch' removing node 'app-admin/skey/files/' skey-1.1.5-otp.diff' removing node 'app-admin/skey/files/' skey-login_name_max.diff' removing node 'app-cdr/qpxtool/' qpxtool-0.5.0.ebuild' removing node 'app-cdr/qpxtool/' qpxtool-0.5.3.ebuild' removing node 'app-cdr/qpxtool/files/' digest-qpxtool-0.5.0' removing node 'app-cdr/qpxtool/files/' digest-qpxtool-0.5.3' removing node 'app-laptop/thinkpad/' thinkpad-5.7.ebuild' removing node 'app-laptop/thinkpad/' thinkpad-5.8.ebuild' removing node 'app-laptop/thinkpad/' thinkpad-5.9-r1.ebuild' removing node 'app-laptop/thinkpad/files/' digest-thinkpad-5.7' removing node 'app-laptop/thinkpad/files/' digest-thinkpad-5.8' removing node 'app-laptop/thinkpad/files/' digest-thinkpad-5.9-r1' removing node 'app-laptop/thinkpad/files/' thinkpad' removing node 'app-laptop/thinkpad/files/' thinkpad-5.8-cpu_ptr.patch' removing node 'app-laptop/thinkpad/files/' thinkpad-5.9-remove-inter_module.patch' removing node 'app-laptop/thinkpad/files/' thinkpad-5.9-remove-thinkpadapm-argument.patch' creating dir 'app-text/build-docbook-catalog' removing node 'app-text/' 'bow' removing node 'app-text/' 'build-docbook-catalog' 2 malloc failure on app-text/build-docbook-catalog/ChangeLog app-text/build-docbook-catalog/, /usr/portage failed enforcing file layout, bailing I take back what I said in Bug #141388 about this problem being a regression between v0.1 and v0.2 Apparently I did not clean out the target directory between runs of the different versions, thinking the failure took place during scanning so the directory would not have been changed yet. Wrong! The first time it runs, it fails AND deletes a bunch of files and directories. The second time it runs the directory in which it failed is already *gone*, so it successfully gets through the deleting phase and unpacks the proper versions of all the missing stuff from the tar. So... the failure message about malloc is totally misleading, with the real error code from scandir() being ENOENT because it was trying to sort a directory that had mistakenly been deleted. Created attachment 92586 [details, diff]
strcmp fix
Try this please, ought to fix it.
The patch works for me. A 0.2-r1 revbump with the patch is now in the tree. |