| Summary: | x11-drivers/ati-drivers-8.26.18-r1 acpi ati-powermode.sh script has wrong aticonfig location | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Clarke Brunsdon <crimson> |
| Component: | New packages | Assignee: | X11 External Driver Maintainers <x11-drivers> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | armando, dodeco, gentoo-a7x, henning, humpback, jradmacher, rhill |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
patch to replace "finger" with "who"
replace finger with who, and point to correct aticonfig location Includes changes from above (finger -> who) as well as more genericizing of the script A new version of this file since the version provided with the ebuild didn't work for me ati-powermode.sh.patch ati-powermode.sh.patch |
||
|
Description
Clarke Brunsdon
2006-07-06 08:50:22 UTC
Created attachment 91816 [details, diff]
patch to replace "finger" with "who"
Created attachment 91817 [details, diff]
replace finger with who, and point to correct aticonfig location
This patch will correct the fact that most users do not have finger, and do not have aticonfig in /usr/X11R6/bin/
Created attachment 93436 [details, diff]
Includes changes from above (finger -> who) as well as more genericizing of the script
Includes changes from above (finger -> who) as well as more genericizing of the script, to include more power states.
I can confirm the problem but can you please remake the patch for the version of ati-drivers in portage now? "aticonfig --set-powerstate=NUMBER" is effective immediately so no need to use --effective=now, it generate an error message Created attachment 101258 [details]
A new version of this file since the version provided with the ebuild didn't work for me
Since the version provided with the ebuild didn't work for me, I corrected it.
I did not make a patch since I modified the script too deeply.
Created attachment 109715 [details, diff]
ati-powermode.sh.patch
I wonder why none of these patches made it into portage yet. The version in portage is clearly broken because it relies on finger. So ati-drivers should either depend on net-misc/netkit-fingerd or simply use who (which is part of baselayout).
My patch uses who and another grep pattern to determine Xusers. It works for multiple XServers which is not important for aticonfig but i also use that one for locking with xscreensaver.
It also determines the default state with $DISPLAY set in environment. Try the line from the portage version in an root xterm where you unset DISPLAY first ..
Hope at least one of the scripts here makes it into portage soon. Or at least someone fixing the two bugs in the current version with his/her own script.
Created attachment 109727 [details, diff]
ati-powermode.sh.patch
sorry that old one could _only_ handle multiple X-Servers, that one does the trick..
Fixed in >=8.33.6-r1 |
