Bug 138688 - The setuid patch for x11-base/xorg-server-1.0.2 is broken.
|
Bug#:
138688
|
Product: Gentoo Linux
|
Version: unspecified
|
Platform: All
|
|
OS/Version: Linux
|
Status: RESOLVED
|
Severity: normal
|
Priority: P2
|
|
Resolution: FIXED
|
Assigned To: x11@gentoo.org
|
Reported By: rudo@matfyz.cz
|
|
Component: Applications
|
|
|
URL:
|
|
Summary: The setuid patch for x11-base/xorg-server-1.0.2 is broken.
|
|
Keywords:
|
|
Status Whiteboard:
|
|
Opened: 2006-07-01 04:12 0000
|
Hi,
I have looked at the x11-base/xorg-server/files/x11r7.0-setuid.diff file in the
portage tree and found the patch broken.
As of revision 1.1 of the file in portage CVS, the write.c hunk says:
- setuid(getuid());
+ if (setuid(getuid() == -1)
+ FatalError("xf86writeConfigFile(): "
Note the missing closing parenthesis after getuid(). I wonder how it could even
compile (haven't tried it myself though).
Please fix the patch.
Bye for now.
Rudo.
It probably doesn't compile the parser, then. I'll fix this up anyway. Good
catch :)
Donnie, this is broken in the 1.1 patch as well, which probably means it's
broken in git upstream.
I've also committed your fix upstream.
