Bug 137918 - cmake path to kde plugin missing
Bug#: 137918 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: dragonheart@gentoo.org Reported By: michi2k@web.de
Component: Development
URL:  http://bugs.kde.org/show_bug.cgi?id=129737
Summary: cmake path to kde plugin missing
Keywords:  
Status Whiteboard: 
Opened: 2006-06-25 03:10 0000
Description:   Opened: 2006-06-25 03:10 0000
I tried to compile games-strathegy/boson and it failed. I submitted a bugreport
to the KDE guys and they found out what was wrong: cmake-2.4.2 needs a little
patch, see http://bugs.kde.org/show_bug.cgi?id=129737

I tried it out and now boson compiles and works.

------- Comment #1 From Daniel Black 2006-06-28 22:06:02 0000 -------
see also:

http://www.cmake.org/Bug/bug.php?op=show&bugid=3324&pos=0

This references the patches:
http://svn.sourceforge.net/viewcvs.cgi/boson/trunk/tools/cmake/modules/boson/kde3uic.cmake?view=diff&r1=7624&r2=7626&diff_format=h 
and 
http://svn.sourceforge.net/viewcvs.cgi/boson/trunk/tools/cmake/modules/boson/KDE3Macros.cmake?view=diff&r1=7624&r2=7626&diff_format=h 

Do these need adjustment or is using $KDE3_LIB_DIR ok?

------- Comment #2 From Daniel Black 2006-06-29 23:44:53 0000 -------
I'll take care of this one (and bug 135816)

------- Comment #3 From Daniel Black 2006-06-30 01:50:14 0000 -------
thanks Michael for going all the way and getting an answer off the kde folks.

I really appreciate this kind of dedication.

Hopefully I've read/applied and tested it ok and it works now. I compiled the
boson-0.12 without the error in kde bug 129737. Please tell me if it isn't
fixed for you.

------- Comment #4 From Michael Siebert 2006-06-30 23:07:07 0000 -------
I removed the entry from /usr/share/cmake/Modules/kde3uic.cmake and compiled
the svn version. Now the bug does not occur anymore (the svn version is still
buggy, but a "make -k" does it).

------- Comment #5 From Daniel Black 2006-07-01 01:53:45 0000 -------
(In reply to comment #4)
> I removed the entry from /usr/share/cmake/Modules/kde3uic.cmake
ok. And replaced it with what cmake-2.4.2-r1 installed?

> and compiled
> the svn version.

of cmake or boson?

> Now the bug does not occur anymore
So cmake-2.4.2-r1 in portage is ok right?

> (the svn version is still
> buggy,

> but a "make -k" does it).
in boson particually or for cmake compile failures in general?

------- Comment #6 From Michael Siebert 2006-07-02 00:15:41 0000 -------
I'm talking of boson ;) Boson compiles with some errors, but these are not
related to cmake. What they did is using their own kde3uic.cmake, ignoring the
system's default.

There are two ways to solve the problem:
- Clean version: Providing a patch to cmake as in "Description"
- Dirty hack: Let boson use its own files as in Comment #1

Both options work, but the second one is first dirtier, since other programs
still  suffer from the cmake bug and more difficult to implement, since we
either have to wait for the next release or to build a patch for the current -
and I don't know the minimum set of changes needed to introduce the patched
files.

So what I suggest is to patch cmake by changing the kde3uic.cmake as in
http://www.cmake.org/Bug/bug.php?op=show&bugid=3324&pos=0
The solution provided there is a very general one, that means especially
independend of the kde version.

------- Comment #7 From Daniel Black 2006-07-02 00:48:34 0000 -------
(In reply to comment #6)
> I'm talking of boson ;) Boson compiles with some errors, but these are not
> related to cmake. What they did is using their own kde3uic.cmake, ignoring the
> system's default.

Ok. makes more sense now.

> There are two ways to solve the problem:
> - Clean version: Providing a patch to cmake as in "Description"

Hopefully done in cmake-2.4.2-r1.

> - Dirty hack: Let boson use its own files as in Comment #1
> 
> Both options work, but the second one is first dirtier, since other programs
> still  suffer from the cmake bug and more difficult to implement, since we
> either have to wait for the next release or to build a patch for the current -
> and I don't know the minimum set of changes needed to introduce the patched
> files.

Hopefully I've done it right. It seemed to have the right results by all
documentation that I could sanely read.

> 
> So what I suggest is to patch cmake by changing the kde3uic.cmake as in
> http://www.cmake.org/Bug/bug.php?op=show&bugid=3324&pos=0

Yes I took those two patches and made them into this patch:
/usr/portage/dev-util/cmake/files/cmake-2.4.2-kde.patch

> The solution provided there is a very general one, that means especially
> independend of the kde version.

I was grateful for it too.

------- Comment #8 From Michael Siebert 2006-07-04 06:12:14 0000 -------
I emerged cmake-2.4.2-r1 and now I can compile boson without problems.