| Summary: | possible problem with boot/kernel/foo/packages processing | ||
|---|---|---|---|
| Product: | Gentoo Hosted Projects | Reporter: | Andrew Gaffney (RETIRED) <agaffney> |
| Component: | Catalyst | Assignee: | Gentoo Catalyst Developers <catalyst> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | InVCS |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
What would you recommend as a fix? Get rid of one of the sets of brackets in the first part of the 'if': addlargs["boot/kernel/"+x+"/packages"]=[y] Heh... why didn't you just say that? :P Because that would have just made sense? Fixed in 2.0_rc49 |
Starting at line 511 in modules/generic_stage_target.py, there's the following code: for y in loop2: if not addlargs.has_key("boot/kernel/"+x+"/packages"): addlargs["boot/kernel/"+x+"/packages"]=[[y]] else: addlargs["boot/kernel/"+x+"/packages"].append(y) The first part of the 'if' block appears to do something undesired. It creates the initial list and then sticks the first package inside another list. Subsequent packages are added to the main list. This would result in something like: [ [ "pkg1" ], "pkg2", "pkg3", "pkg4", "pkg5" ] Somehow, this just doesn't seem right.