Bug 134206 - keyword jakarta-jstl-1.1.2 for ppc
Bug#: 134206 Product:  Gentoo Linux Version: 2006.0 Platform: PPC
OS/Version: Linux Status: RESOLVED Severity: enhancement Priority: P2
Resolution: FIXED Assigned To: java@gentoo.org Reported By: aymeric@nnx.com
Component: Ebuilds
URL:  http://forums.gentoo.org/viewtopic-t-462657-start-0-postdays-0-postorder-asc-highlight-jakartajstl.html
Summary: keyword jakarta-jstl-1.1.2 for ppc
Keywords:  
Status Whiteboard: 
Opened: 2006-05-24 06:59 0000
Description:   Opened: 2006-05-24 06:59 0000 
Hi there,
jakarta-jstl should emerge fine for x86 but I need it on ppc so I modify the
ebuild to get it work on ppc with ibm-jdk (1.4.2_04).
I described the process on a post on the forum.
Also I'll add the files as attachement with this bug.
If people could comment (it's my first ebuild modification) I could learn and
help further (I'd like to).

------- Comment #1 From Aymeric Nys 2006-05-24 07:00:36 0000 ------- 
Created an attachment (id=87392) [details]
jakarta jstl 1.1.2 ebuild

------- Comment #2 From Aymeric Nys 2006-05-24 07:02:04 0000 ------- 
Created an attachment (id=87394) [details]
Patch to the build.xml ant file

build.xml is made for a sun-jdk. ibm break down the file rt.jar in 3 or 4
differents files.

------- Comment #3 From Joe Jezak 2006-05-24 14:45:30 0000 ------- 
What does the java team think about these changes?

------- Comment #4 From Josh Nichols (RETIRED) 2006-05-25 06:21:04 0000 ------- 
My first impression is that the build.xml probably doesn't need to specify the
bootclasspath, since it should already be setup. So, I'd suggest patching to
remove the bootclasspath of javac, and see if that works on both sun-jdk and
ibm-jdk.

------- Comment #5 From Aymeric Nys 2006-05-25 11:43:01 0000 ------- 
(In reply to comment #4)
> My first impression is that the build.xml probably doesn't need to specify the
> bootclasspath, since it should already be setup. So, I'd suggest patching to
> remove the bootclasspath of javac, and see if that works on both sun-jdk and
> ibm-jdk.
> 
Your first impression is correct. I patch to remove the classpath, and it works
the same (ppc, ibm-jdk). I post the new ebuild and the patch.

------- Comment #6 From Aymeric Nys 2006-05-25 11:45:00 0000 ------- 
Created an attachment (id=87499) [details]
new ebuild with new patch

------- Comment #7 From Aymeric Nys 2006-05-25 11:45:41 0000 ------- 
Created an attachment (id=87500) [details]
remove bootclasspath from build.xml

------- Comment #8 From Josh Nichols (RETIRED) 2006-05-25 12:03:52 0000 ------- 
For future reference, it is preferred to submit patches against ebuilds, rather
than the entire ebuild. This makes it possible to quickly determine how the
ebuild has been changed.

But I'm glad to here it could be fixed. Might I suggest you submit a bug with
patch upstream as well?

------- Comment #9 From Josh Nichols (RETIRED) 2006-09-13 10:41:56 0000 ------- 
(From update of attachment 87500 [details])
Patch applied to ebuild in CVS.

------- Comment #10 From Josh Nichols (RETIRED) 2006-09-13 20:07:22 0000 ------- 
Fixed in CVS. Thanks for reporting! Sorry about the delay.