Home | Docs | Forums | Lists | Bugs | Planet | Store | GMN | Get Gentoo!

Full Text Bug Listing

Compiling Sources/Display/System/Unix/directfb_target.cpp
Sources/Display/System/Unix/display_target.h:19: warning: 'class
CL_DisplayTarget' has virtual functions but non-virtual destructor
Sources/Display/System/Unix/directfb_target.h:25: warning: 'class
CL_DirectFBTarget' has virtual functions but non-virtual destructor
Sources/Display/Input/DirectFB/keyboard_directfb.cpp: In member function 'int
CL_DirectFBKeyboard::map_directfb_to_cl(DFBInputDeviceKeyIdentifier)':
Sources/Display/Input/DirectFB/keyboard_directfb.cpp:246: error: 'DIKI_ALTGR'
was not declared in this scope
Sources/Display/Input/DirectFB/keyboard_directfb.cpp: In member function
'DFBInputDeviceKeyIdentifier CL_DirectFBKeyboard::map_cl_to_directfb(int)':
Sources/Display/Input/DirectFB/keyboard_directfb.cpp:340: error: 'DIKI_ALTGR'
was not declared in this scope
Sources/Display/Display/Generic/displaycard_generic.h:100: warning: 'class
CL_DisplayCard_Generic::CL_FlipDisplayCallback_Generic' has virtual functions
but non-virtual destructor
make: *** [Libs/Intermediate/keyboard_directfb.o] Error 1

Created an attachment (id=86592) [details]
clanlib-0.6.5-r3-directfb.patch

The DIKI_ALTGR enum is removed in directfb-0.9.25. This patch checks for the
directfb version before using DIKI_ALT_R instead as documented in the directfb
release notes.

Applied patch, works, looks good too (other than the logic assuming (correctly)
that there wasn't ever a 0.8.25+, 0.7.25+, etc.)).

Happy with this. :)

Created an attachment (id=86614) [details]
clanlib-0.6.5-directfb.patch

You are absolutely right (I should never submit quick fixes during coffee
breaks at work). Here's my second attempt.

Created an attachment (id=86631) [details]
clanlib-0.6.5-DirectFB-update.patch

still no good ... that patch would use DIKI_ALTGR for 0.10.1

try the attached instead

typo in that patch; D_V should be DFB_V.  Otherwise it compiles fine.

thanks for reviewing, now in portage