Bug 130539 - games-emulation/generator-0.3.5-r1 generates an executable stack QA notice
Bug#: 130539 Product:  Gentoo Linux Version: 2006.0 Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: games@gentoo.org Reported By: gentoo@altkai.ml1.net
Component: Games
URL: 
Summary: games-emulation/generator-0.3.5-r1 generates an executable stack QA notice
Keywords:  
Status Whiteboard: 
Opened: 2006-04-19 17:49 0000
Description:   Opened: 2006-04-19 17:49 0000
on x86, +gtk -svga use flags

QA Notice: the following files contain executable stacks
 Files with executable stacks will not work properly (or at all!)
 on some architectures/operating systems.  A bug should be filed
 at http://bugs.gentoo.org/ to make sure the file is fixed.
RWX --- --- usr/games/bin/generator-gtk

------- Comment #1 From Kai 2006-04-19 18:27:06 0000 -------
Kindly excuse my cluelessness :)

I followed the instructions at:
http://www.gentoo.org/proj/en/hardened/gnu-stack.xml

to find that raze/raze.o is the source of the trouble. It doesn't define
.note.GNU-stack. Now, I'm not sure where the ifdef goes. There are the
following files in /raze:

Makefile     Makefile.in  raze.asm     raze.h    raze.o    raze.zip
Makefile.am  libraze.a    raze.asm.in  raze.inc  raze.reg  raze2.asm

------- Comment #2 From SpanKY 2006-04-19 19:20:51 0000 -------
i fixed this once already ... the question is, where did that patch go

------- Comment #3 From Kai 2006-04-19 19:45:11 0000 -------
I looked through changelog & past bugs and don't see where your patch might've
been dropped. Where's an old Portage tree when you need one?

------- Comment #4 From Kai 2006-04-19 20:19:24 0000 -------
Aha. Sorry for the bugspam, folks. A bit of detective work shows that gngeo
uses the raze Z80 core as well, and that's where Spanky fixed it. 

The makefiles are different, though, and I'm a little too clueless to figure it
out :P

------- Comment #5 From SpanKY 2006-04-19 20:25:27 0000 -------
ah, indeed ... i just recognized the 'raze.asm' and thought it to be the same

------- Comment #6 From SpanKY 2006-04-19 20:45:30 0000 -------
sync up and try current cvs please ... just added
files/generator-0.35-gcc.patch

------- Comment #7 From Kai 2006-04-19 23:14:28 0000 -------
Still generates a execstack QA notice here on my x86 machine. Works fine,
though.

------- Comment #8 From Tupone Alfredo 2006-09-02 18:32:39 0000 -------
Should be fixed now. In generator-0.35-r2 ebuild