Home | Docs | Forums | Lists | Bugs | Planet | Store | GMN | Get Gentoo!

Full Text Bug Listing

Nothing significant needed to be done because there is now upstream support. 
However, due to issues related to `use ppc` evaluating to true on this arch and
related changes to the ebuild, it should be tested on a ppc-linux system. 
Attached is a patch to add ppc-macos support.  The ebuild is also available via
http in my darcs overlay at the indicated URI.

Created an attachment (id=84288) [details]
ppc-macos patch

As above.

Seems ok to me. Successfully built with the patch, and used it to compile
maxima which also seems fine.

wormo, do you mean to say that it worked on ppc linux or ppc-macos?

Nick, if it is found to work fine on both architectures, you should commit the
patch to CVS.  The only question I have about your patch is the last section:

@@ -91,7 +104,7 @@
 #      use x86 \
 #              && echo '(enable :sb-futex)' \
 #              >>${S}/customize-target-features.lisp
-       echo '(disable :sb-test)' >>${S}/customize-target-features.lisp
+#      echo '(disable :sb-test)' >>${S}/customize-target-features.lisp
        ! use unicode \
                && echo '(disable :sb-unicode)' \
                >>${S}/customize-target-features.lisp

That would affect all archs.  Is there any reason to exclude :sb-test from
customize-target-features? 

Worked on ppc linux

mkennedy:

That line will be uncommented for submission.  It's not necessary.  Why is
sb-test disabled by default?  Is it extra runtime type-checking or something? 
I enabled the test hoping for extra output while testing sbcl on ppc-macos.

Created an attachment (id=84658) [details]
disabled sb-test as original

Re-disabled sb-test.

In the SBCL archive root directory base-target-features.lisp-expr:

 ;; Do regression and other tests when building the system. You might
 ;; or might not want this if you're not a developer, depending on how
 ;; paranoid you are. You probably do want it if you are a developer.
 ;; This test does not affect the target system (in much the same way
 ;; as :sb-after-xc-core, below).
 :sb-test

I can't remember what effect it had exactly, but disabling it for users is a
good idea.  I vaguely recall it avoids loading up *-test.asd system definitions
and that was a speedup.

I'll apply your latest patch when I get home.

Nick, one more question about the patch:

    if use ppc-macos && use ldb; then
        true
    elif use ppc && use ldb; then
        sbcl_einfo <<'EOF'                                                      
Building SBCL on PPC with LDB support is not a supported configuration          
in Gentoo. Please refer to Bug #121830 for more information.                    
EOF                                                                             
        die
    fi

I'm not sure what the intention there is.  Does ldb really work on ppc-macos
but not on non-macos ppc?

I dont think it does, so I adjusted that stanza slightly and committed to
portage.

Sorry for the delay; I'm in the middle of moving.

I tried building sbcl with the ldb use flag enabled and encountered no
compilation errors as described in the associated bug mentioned in the ebuild
(#121830).  Hence, I left it as an available option in the patch.