Bug 127890 - epiphany-extensions-2.14.0.1: adblock: segfault closing window with multiple recovered tabs [PATCH]
Bug#: 127890 Product:  Gentoo Linux Version: 2006.0 Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: gnome@gentoo.org Reported By: ed@catmur.co.uk
Component: GNOME
URL: 
Summary: epiphany-extensions-2.14.0.1: adblock: segfault closing window with multiple recovered tabs [PATCH]
Keywords:  
Status Whiteboard: 
Opened: 2006-03-28 11:55 0000
Description:   Opened: 2006-03-28 11:55 0000 
From http://bugzilla.gnome.org/show_bug.cgi?id=336111

When adblock is enabled, epiphany segfaults when a window containing multiple
tabs recovered from a previous crash is closed.

The fix is in Gnome CVS and will be released in 2.14.0.2, but I would suggest
adding the patch to the ebuild, as it's a nasty bug and an easy fix.

Commit URL:
http://cvs.gnome.org/viewcvs/epiphany-extensions/extensions/adblock/ephy-adblock-extension.c?r1=1.10&r2=1.10.2.1

I can confirm that applying the commit as a patch fixes the bug.

------- Comment #1 From Xavier Maillard 2006-03-28 14:26:55 0000 ------- 
I confirm the behaviour on one of my machines.

Patching it solved my problem.

------- Comment #2 From foser (RETIRED) 2006-03-29 03:25:56 0000 ------- 
added the patch, thnx for the notification.

------- Comment #3 From Ed Catmur 2006-03-29 08:22:20 0000 ------- 
Created an attachment (id=83377) [details]
epiphany-extensions-2.14.0.1-adblock.patch

Unfortunately the first hunk in that commit contains an $Id: $ tag, so the
patch got tagged with your commit ID, and so fails to apply. This is the same
patch with the first hunk removed.

------- Comment #4 From Ed Catmur 2006-03-29 08:23:14 0000 ------- 
Reopening so that patch can get fixed.

------- Comment #5 From Ed Catmur 2006-03-29 08:27:59 0000 ------- 
Created an attachment (id=83378) [details]
epiphany-extensions-2.14.0.1-adblock.patch

I'm really not awake today...

------- Comment #6 From foser (RETIRED) 2006-03-29 09:06:28 0000 ------- 
you are correct sir, obviously I wasn't too awake either at the time. Should be
fixed now for real.