Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 127890

Summary: epiphany-extensions-2.14.0.1: adblock: segfault closing window with multiple recovered tabs [PATCH]
Product: Gentoo Linux Reporter: Ed Catmur <ed>
Component: [OLD] GNOMEAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal CC: zedek
Priority: High    
Version: 2006.0   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 119872    
Attachments: epiphany-extensions-2.14.0.1-adblock.patch
epiphany-extensions-2.14.0.1-adblock.patch

Description Ed Catmur 2006-03-28 11:55:16 UTC
From http://bugzilla.gnome.org/show_bug.cgi?id=336111

When adblock is enabled, epiphany segfaults when a window containing multiple
tabs recovered from a previous crash is closed.

The fix is in Gnome CVS and will be released in 2.14.0.2, but I would suggest adding the patch to the ebuild, as it's a nasty bug and an easy fix.

Commit URL: http://cvs.gnome.org/viewcvs/epiphany-extensions/extensions/adblock/ephy-adblock-extension.c?r1=1.10&r2=1.10.2.1

I can confirm that applying the commit as a patch fixes the bug.
Comment 1 Xavier Maillard 2006-03-28 14:26:55 UTC
I confirm the behaviour on one of my machines.

Patching it solved my problem.
Comment 2 foser (RETIRED) gentoo-dev 2006-03-29 03:25:56 UTC
added the patch, thnx for the notification.
Comment 3 Ed Catmur 2006-03-29 08:22:20 UTC
Created attachment 83377 [details, diff]
epiphany-extensions-2.14.0.1-adblock.patch

Unfortunately the first hunk in that commit contains an $Id: $ tag, so the patch got tagged with your commit ID, and so fails to apply. This is the same patch with the first hunk removed.
Comment 4 Ed Catmur 2006-03-29 08:23:14 UTC
Reopening so that patch can get fixed.
Comment 5 Ed Catmur 2006-03-29 08:27:59 UTC
Created attachment 83378 [details, diff]
epiphany-extensions-2.14.0.1-adblock.patch

I'm really not awake today...
Comment 6 foser (RETIRED) gentoo-dev 2006-03-29 09:06:28 UTC
you are correct sir, obviously I wasn't too awake either at the time. Should be fixed now for real.