Bug 127599 - media-video/sswf-1.7.5 bump request
Bug#: 127599 Product:  Gentoo Linux Version: 2005.1 Platform: All
OS/Version: Linux Status: RESOLVED Severity: enhancement Priority: P2
Resolution: FIXED Assigned To: media-video@gentoo.org Reported By: justin@salasaga.org
Component: Ebuilds
URL:  http://sswf.sourceforge.net/
Summary: media-video/sswf-1.7.5 bump request
Keywords:  
Status Whiteboard: 
Opened: 2006-03-25 22:59 0000
Description:   Opened: 2006-03-25 22:59 0000
Hi,

I've been using more recent versions of SSWF (Flash generator) recently than
are available in Portage.

Figured I might as well submit the latest ebuild here that I use, as it's one
of those ebuilds that's trivially simple and Just Works. :)

Will create an attachment with the ebuild.  It works fine "as is" on my system
at least. :)

Regards and best wishes,

Justin Clift

------- Comment #1 From Justin Clift 2006-03-25 23:01:26 0000 -------
Created an attachment (id=83136) [details]
Ebuild for sswf version 1.7.4. (Complete ebuild - it's only a few lines - not a
patch)

This is a complete ebuild script - it's only a few lines - rather than a patch
or anything.  Able to be dropped right in.

------- Comment #2 From Samuli Suominen 2007-02-04 08:19:58 0000 -------
(In reply to comment #1)
> Created an attachment (id=83136) [edit] [details]
> Ebuild for sswf version 1.7.4. (Complete ebuild - it's only a few lines - not a
> patch)
> 
> This is a complete ebuild script - it's only a few lines - rather than a patch
> or anything.  Able to be dropped right in.
> 

There is multiple faults in your ebuild,

--cut--
# Copyright 1999-2005 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: /var/cvsroot/gentoo-x86/media-video/sswf/sswf-1.7.1.ebuild,v 1.3
2005/03/23 14:33:10 blubb Exp $
--cut--

This is wrong, look at /usr/portage/header.txt

--cut--
inherit eutils
--cut--

Eutils doesn't actually do anything in this ebuild, so drop whole line.

--cut--
DEPEND="sys-libs/zlib
        media-libs/jpeg
        media-libs/freetype
        sys-devel/bison"
---cut--

zlib, jpeg and freetype are both RDEPENDs and DEPENDs so change that to RDEPEND
and add line DEPEND="${RDEPEND}". What it comes to bison, it might be only
DEPEND so check that too.

--cut--
src_unpack() {
        unpack ${A}
        cd ${S}
}
--cut--

You can remove whole src_unpack() if you don't do anything but unpack and cd
there.

--cut--
src_compile() {
        econf \
                $(use_enable debug) \
                || die "Configuration Failed!"

        emake || die "Make Failed"
}
--cut--

Looks a bit weird, make econf $(use_enable debug) || die "econf failed" in one
line without \

--cut--
src_install () {
        make DESTDIR=${D} install || die
}
--cut--

Use emake instead of make because for example Gentoo/FreeBSD doesn't use gmake
as default make command and it might break the build.

------- Comment #3 From Diego E. 'Flameeyes' Pettenò 2007-02-04 11:14:09 0000 -------
Actually emake install might not always work _especially_ on G/FBSD, as most
install-sh files are non-parallel-make compatible.

On the other hand, emake -j1 makes more sense, and does respect users' choice
on other options for make.

------- Comment #4 From Jakub Moc (RETIRED) 2007-03-07 15:33:27 0000 -------
*** Bug 169780 has been marked as a duplicate of this bug. ***

------- Comment #5 From Samuli Suominen 2007-03-07 21:52:11 0000 -------
Created an attachment (id=112480) [details]
sswf-1.7.5.ebuild

Draft ebuild. I never got to src_install because it dies in src_compile, by
looks of it, an compilation error caused by recent gcc; even with provided
g++-4.x patch from upstream (see SRC_URI)

Also, upstream mentions 1.8.0 (beta, with some flash 8 funcs) but download link
in their page is dead..

------- Comment #6 From Samuli Suominen 2007-03-09 17:41:59 0000 -------
Allright, 1.8.0 is in Portage (still in CVS). Thanks Justin!

------- Comment #7 From Justin Clift 2008-03-18 09:33:56 0000 -------
Heh, just noticed this follow up info.

Don't remember getting any notification via email though (thus my lack of
attention).

Maybe my spam filters at the time...?  Oh well, it's fixed now. ;->

Thanks guys. :)