Bug 127429 - invalid use flags check in app-emacs/emacs-w3m-1.4.4
|
Bug#:
127429
|
Product: Gentoo Linux
|
Version: unspecified
|
Platform: All
|
|
OS/Version: Linux
|
Status: RESOLVED
|
Severity: minor
|
Priority: P2
|
|
Resolution: FIXED
|
Assigned To: emacs@gentoo.org
|
Reported By: tassilo@member.fsf.org
|
|
Component: Applications
|
|
|
URL:
|
|
Summary: invalid use flags check in app-emacs/emacs-w3m-1.4.4
|
|
Keywords:
|
|
Status Whiteboard:
|
|
Opened: 2006-03-24 06:52 0000
|
Hi,
one cannot install emacs-w3m if "async" is in USE. That's too restrictive,
because the user (like me) could have
www-client/w3m -async
in his/her /etc/portage/package.use. So sticking with a simple warning message
about the async-problem would be better.
<snip>
# use async doesn't ensure you built w3m with async flag,
# but it's safe to abort if you have it.
ewarn "emacs-w3m hangs if you build w3m with async support."
ewarn "Please turn off async USE flag if you set it."
ewarn
if use async ; then
die "async USE flag detected. aborting."
fi
</snip>
This is completely broken check, if the thing really doesn't work when
something else is compiled with a particular USE flag, then please do something
like:
inherit eutils
...
if built_with_use www-client/w3m async; then
eerror "emacs-w3m hangs if you build w3m with async support."
die "re-emerge www-client/w3m with USE=\"-async\""
fi
Don't die just because someone has a USE flag enabled that isn't even in this
ebuild's IUSE.
Arch teams for alpha, ppc, x86 and sparc: Please add stable keywords for
app-emacs/emacs-w3m-1.4.4-r1 in order to resolve this bug. Thanks for the QA
solution Jakub
Looks safe to mark this as stable on x86 since it's just a change in how the
ebuild checks for w3m's USE, and the logic there is working fine. (I gave it 10
minutes of testing anyway, and didn't run into any problems).
SPARC, it makes me so stable.
I mentioned alpha arch, but neglected to add it to the CC list.
alpha archs testers, please keyword emacs app-emacs/emacs-w3m-1.4.4-r1 stable.
1.4.4-r1 stable on alpha.