Bug 127429 - invalid use flags check in app-emacs/emacs-w3m-1.4.4
Bug#: 127429 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: minor Priority: P2
Resolution: FIXED Assigned To: emacs@gentoo.org Reported By: tassilo@member.fsf.org
Component: Applications
URL: 
Summary: invalid use flags check in app-emacs/emacs-w3m-1.4.4
Keywords:  
Status Whiteboard: 
Opened: 2006-03-24 06:52 0000
Description:   Opened: 2006-03-24 06:52 0000
Hi,
one cannot install emacs-w3m if "async" is in USE. That's too restrictive,
because the user (like me) could have

    www-client/w3m -async

in his/her /etc/portage/package.use. So sticking with a simple warning message
about the async-problem would be better.

------- Comment #1 From Jakub Moc (RETIRED) 2006-03-24 07:24:08 0000 -------
<snip>
        # use async doesn't ensure you built w3m with async flag,
        # but it's safe to abort if you have it.
        ewarn "emacs-w3m hangs if you build w3m with async support."
        ewarn "Please turn off async USE flag if you set it."
        ewarn
        if use async ; then
                die "async USE flag detected. aborting."
        fi
</snip>

This is completely broken check, if the thing really doesn't work when
something else is compiled with a particular USE flag, then please do something
like:

inherit eutils

...

if built_with_use www-client/w3m async; then
        eerror "emacs-w3m hangs if you build w3m with async support."
        die "re-emerge www-client/w3m with USE=\"-async\""
fi

Don't die just because someone has a USE flag enabled that isn't even in this
ebuild's IUSE.

------- Comment #2 From Matthew Kennedy (RETIRED) 2006-04-26 10:19:11 0000 -------
Arch teams for alpha, ppc, x86 and sparc: Please add stable keywords for
app-emacs/emacs-w3m-1.4.4-r1 in order to resolve this bug.  Thanks for the QA
solution Jakub

------- Comment #3 From David Morgan 2006-04-28 08:12:30 0000 -------
Looks safe to mark this as stable on x86 since it's just a change in how the
ebuild checks for w3m's USE, and the logic there is working fine. (I gave it 10
minutes of testing anyway, and didn't run into any problems).

------- Comment #4 From Tobias Scherbaum 2006-04-29 04:59:52 0000 -------
ppc stable

------- Comment #5 From Mark Loeser 2006-05-03 15:00:35 0000 -------
x86 stable, thanks David

------- Comment #6 From Jason Wever (RETIRED) 2006-05-06 16:14:58 0000 -------
SPARC, it makes me so stable.

------- Comment #7 From Matthew Kennedy (RETIRED) 2006-05-15 09:11:38 0000 -------
I mentioned alpha arch, but neglected to add it to the CC list.

------- Comment #8 From Matthew Kennedy (RETIRED) 2006-05-16 22:47:11 0000 -------
alpha archs testers, please keyword emacs app-emacs/emacs-w3m-1.4.4-r1 stable.

------- Comment #9 From Thomas Cort (RETIRED) 2006-05-19 16:02:51 0000 -------
1.4.4-r1 stable on alpha.

------- Comment #10 From Matthew Kennedy (RETIRED) 2006-05-20 13:12:04 0000 -------
All arches done, closing