| Summary: | baselayout-1.11.x depscan.sh incorrectly checks for changed scripts | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | John Waymouth <gentoo.org> |
| Component: | [OLD] baselayout | Assignee: | Gentoo's Team for Core System packages <base-system> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | toralf |
| Priority: | High | ||
| Version: | 2006.0 | ||
| Hardware: | x86 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
this has been fixed in 1.12 and newer already Neato. I didn't check, it's masked. Incidentally, I think we went to the same college. back ported the current code from trunk to the 1.11.x branch *** Bug 127419 has been marked as a duplicate of this bug. *** |
I've found that changing the depend statement in a hand-rolled init script and then running depscan.sh doesn't seem to pick up the change. Depscan.sh seems not to check for changed scripts correctly. Here's the relavent section from the script: # Only update if files have actually changed if ! ${update} ; then for config in /etc/conf.d /etc/init.d /etc/rc.conf ; do if [[ ${config} -nt "${mysvcdir}/depcache" ]] ; then update=true break fi done fi This checks if the directory init.d itself is newer than the depcache file. The directory's modified time will only update when a new script is added to /etc/init.d, not when an existing one is changed. I don't think this was the intent when this was written, or if it is, it's rather stupid. The fix is simple, just change the for line to this: for config in /etc/conf.d/* /etc/init.d/* /etc/rc.conf ; do My installed baselayout version is 1.11.14-r6. Also of note, before I fixed this bug on my system, whenever I ran my initscript with the "ineed" parameter to test my dependency changes, I got this message: * Re-caching dependency info (mtimes differ)... but it didn't actually seem to recache.