Summary: | app-crypt/johntheripper-1.6.40 - 'CLK_TCK' undeclared (glibc-2.4) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Paul Taylor <birder> |
Component: | Current packages | Assignee: | Daniel Black (RETIRED) <dragonheart> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alberto.devesa, anakin.skyw, anigel, cgibreak, michal.terepeta, notellin, patroy1, storri |
Priority: | High | ||
Version: | 2006.0 | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | changes CLK_TCK to CLOCKS_PER_SEC |
Description
Paul Taylor
2006-03-13 19:07:37 UTC
Created attachment 82412 [details, diff]
changes CLK_TCK to CLOCKS_PER_SEC
works for me - glibc-2.4 gcc-4.1.0...
A less invasive patch would be to modify the ebuild CFLAGS editing to include -DCLK_TCK=CLOCKS_PER_SEC: sed -i -e "s|^CFLAGS.*|CFLAGS= -c -Wall -DCLK_TCK=CLOCKS_PER_SEC ${CFLAGS}|" \ Another thing I noticed is that the with amd64 mmx use flag the ebuild runs linux-x86-64-mmx target which is documented in the makefile to create a 32bit binary ("Linux, AMD x86-64, 32-bit with MMX"). I do not think the mmx is an allowed use flag for amd64, but still it would be good to remove testing for it in the amd64 case. I can confirm that Michaels patch works. Although Mikkos solution sounds cleaner to me (haven't tried) I did the same thing as Michael and got it working. To me, patching the source code (i.e. fixing the REAL problem) seems to me to be the best solution as long as it doesn't break portability. Hacks that muck around with the compile options are really far dirtier than a good solid diff. Michael -- have you submitted this upstream? (In reply to comment #4) > > Michael -- have you submitted this upstream? > No I haven't. It's a rather trivial patch. But if you think it should be sent upstream, feel free to do it. cheers, Michael fixed and sorry for the delay. I was on leave. Thanks for the patch too. It didn't break on x86 so I'm hoping its happy. I'll version bump to 1.7.0.* when I get a few hours free. *** Bug 143932 has been marked as a duplicate of this bug. *** This CLK_TCK patch is only applied to not stable versions (1.6.40 and later, they are all ~x86 masked) Is there any reason to not being applied to the stable version (1.6) ? (In reply to comment #8) > This CLK_TCK patch is only applied to not stable versions (1.6.40 and later, > they are all ~x86 masked) > Is there any reason to not being applied to the stable version (1.6) ? > See Bug 147027. |