Bug 125950 - dev-dotnet/gtk-sharp-2.8.0: broken libtoolize handling and unrespected CFLAGS
Bug#: 125950 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: dotnet@gentoo.org Reported By: flameeyes@gentoo.org
Component: Ebuilds
URL: 
Summary: dev-dotnet/gtk-sharp-2.8.0: broken libtoolize handling and unrespected CFLAGS
Keywords:  
Status Whiteboard: 
Opened: 2006-03-12 09:27 0000
Description:   Opened: 2006-03-12 09:27 0000 
Currently handling of libtoolize in gtk-sharp is broken: it's run after aclocal
and autoconf (it should be run before them), and should be under an || die
condition (probably now it is because it's run after the other and might fail).

Easy solution: use eautoreconf from autotools eclass like the attached patch
does.

Thanks,
Diego

------- Comment #1 From Diego E. 'Flameeyes' Pettenò 2006-03-12 09:27:29 0000 ------- 
Created an attachment (id=81985) [details]
Ebuild patch

------- Comment #2 From Peter Johanson (RETIRED) 2006-03-14 21:29:49 0000 ------- 
Diego: Why blast the WANT_AUTOMAKE part? Does eautoreconf handle knowing those
details as well?

------- Comment #3 From Diego E. 'Flameeyes' Pettenò 2006-03-17 04:50:25 0000 ------- 
Yes, eautoreconf takes care of everything (well it's more the autoconf/automake
wrappers) unless you want to force an upgrade (say the configures are for
autoconf 2.1 and you want to force them to be built with 2.5).

Also, the package does not respect CFLAGS (but it does respect LDFLAGS), as the
configure.in rewrites them with -g and a bunch of -W flags. If you just run

sed -i -e '/^CFLAGS=/d' ${S}/configure.in

before eautoreconf, CFLAGS are respected (the one they were rewritten with are
dropped as it should be, -g is an user choice, the warnings are for developers
mainly). This solution is good for an ebuild but to be sent upstream it
requires different handling, and as I don't know upstream, you might be better
in that :)

------- Comment #4 From Peter Johanson (RETIRED) 2006-04-16 11:30:59 0000 ------- 
Ok, Commited this fix to gtk-sharp-2.{4,8}.2, as well as similar fixes to the
gtk-sharp-componenent.eclass.

Marking this FIXED, feel free to re-open if there's further issues.

Thanks for the patch.