Home | Docs | Forums | Lists | Bugs | Planet | Store | GMN | Get Gentoo!

Full Text Bug Listing

Simple tk front end which allows users to manage a voice mail system and
send/receive faxes. Requires mgetty/vgetty, sox, tk, and netpbm. Possible
maintainers for this would include those who work on mgetty (mrness, blubb,
tove @ gentoo.org).

Created an attachment (id=81540) [details]
x11-misc/tkvoice/tkvoice-1.5.ebuild

suggest put into x11-misc because its graphical. Also could go into one of the
net- categories.

- We officially do not accept "contributed by" lines, so please remove them.
- Same for the other comments. The ebuild is trivial, saving bytes counts.
- Are sox, mgetty pure runtime dependencies by chance?

sox is required for voice record and playback
mgetty is required for modem access for voice and fax
netpbm is for fax image manipulation and conversion.

And yes, they are pure runtime dependencies. Nothing is compiled in this
ebuild.

Created an attachment (id=81545) [details]
x11-misc/tkvoice/tkvoice-1.5.ebuild

revised to remove ALL comments. around 300 bytes lighter.

> And yes, they are pure runtime dependencies. Nothing is compiled in this
> ebuild.

Then use RDEPEND instead DEPEND.

Created an attachment (id=81546) [details]
x11-misc/tkvoice/tkvoice-1.5.ebuild

revised per comments.

it seems interesting, but why did this ebuild ended in x11-misc? IMO it belongs
to net-dialup category. anyone opposing to that?

Some suggestions:
 - virtual-x11 dependency should be deleted (dev-lang/tk depends on x11)
 - quote env vars that could contain spaces, such as $D, $S, $FILESDIR...

(In reply to comment #7)
> it seems interesting, but why did this ebuild ended in x11-misc? IMO it belongs
> to net-dialup category. anyone opposing to that?
> 
> Some suggestions:
>  - virtual-x11 dependency should be deleted (dev-lang/tk depends on x11)
>  - quote env vars that could contain spaces, such as $D, $S, $FILESDIR...
> 

I put it into x11-misc only because tkhylafax was there. I assumed since the
products are similar in function they should be together. And, it _is_ just a
frontend. It does nothing by itself. Sort of like how gdb is in sys-devel, and
kdbg is not. However, putting it into net-dialup would make it easier for users
to locate and be more logical. An argument can be made either way.

As for the quoting, sure. Although I I've never seen any of these quoted beore,
but understand your reasoning.

Created an attachment (id=82084) [details]
tkvoice-1.5.ebuild

Changes: Quoted env vars $D and $FILESDIR. Added .desktop file and install.
Added two additional doc files that were omitted. Could the docs be symlinked
to the install dir? Or, is it proper to copy and gz them?

Created an attachment (id=82085) [details]
files/tkvoice.desktop

Place in files directory.

(From update of attachment 82084 [details])
Also removed x11 dependancy.

submitted in portage as net-dialup/tkvoice.