Bug 124260

Summary:	dev-util/cvs: gnulib's openat.c file has bad code when accessing mode_t vararg
Product:	Gentoo/Alt	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	Other	Assignee:	Maintainers for cvs, and cvs related tools (the version control system) [OBSOLETE] <cvs-utils+obsolete>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bsd+disabled
Priority:	High
Version:	unspecified
Hardware:	All
OS:	FreeBSD
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	cvs-1.12.12-mode_t.patch

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2006-02-27 06:32:51 UTC

cvs is using an old version of gnulib's openat.c unit which contains an openat() replacement. Unfortunately that version of openat.c contains bad code when trying to access mode_t through vararg; it does only produce a warning, but if the execution reach that code, the program aborts (as told by the warning itself).
The attached patch replaces the bad code with the updated one in recent openat.c unit files (the unit is way different but this patch should be enough). Current CVS version of cvs already has openat.c updated from gnulib.

Thanks,
Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2006-02-27 06:33:21 UTC

Created attachment 80835 [details, diff]
cvs-1.12.12-mode_t.patch

Comment 2 Lars Weiler (RETIRED) gentoo-dev

2006-03-01 08:03:20 UTC

Fixed in cvs-1.12.12-r3.