Bug 123538 - adesklets 0.5.0-r1 ebuild (update)
|
Bug#:
123538
|
Product: Gentoo Linux
|
Version: unspecified
|
Platform: All
|
|
OS/Version: Linux
|
Status: RESOLVED
|
Severity: enhancement
|
Priority: P2
|
|
Resolution: FIXED
|
Assigned To: desktop-dock@gentoo.org
|
Reported By: syfou@users.sourceforge.net
|
|
Component: Ebuilds
|
|
|
URL:
|
|
Summary: adesklets 0.5.0-r1 ebuild (update)
|
|
Keywords:
|
|
Status Whiteboard:
|
|
Opened: 2006-02-20 13:50 0000
|
Find enclosed an updated version of the adesklets-0.5.0 ebuild included in the
portage tree. This new ebuild:
- Adds support for the debug machinery of the adesklets interpreter
- Adds support for default redirection to the WM contextual menu
- Conditionally applies a Xorg-specific patch for smoother use under Xfce4.
It adds a local use flag, 'ctrlmenu'. Here is the proposed description for
use.local.desc:
x11-misc/adesklets:ctrlmenu - force CTRL to be pressed to fire context menu
Created an attachment (id=80331) [details]
adesklets-0.5.0-r1.ebuild
I've taken the liberty of making some minor changes to the ebuild and patch.
First, there's no need to conditionally apply the patch, since the new ctrlmenu
use flag activate/deactivates that section of code implicitly. The patch now
has a version on it so it's clear to what version it belongs. The patch file
directory paths are fixed (src/adesklets) in next attachment. Finally I will
attach an ebuild diff as is recommended. Phil
whoops. corrections coming.
I agree those changes are for the better, therefore I will mark my original
attachments as obsoleted by the new ones from Philip.
One small detail: I find the "when patching src/adesklets.c or src/commands.c,
you need to touch these files" comment slightly misleading... On most gentoo
systems, you only need to touch them to save time, because it is shorter than
calling configure twice, or with an --enable-maintainer-mode flag. Any gentoo
system with bs, bash and GNU sed 4.x.x should be able to regenerate them.
Sylvain,
I only added that comment as a reminder that there is a "caveat" if you will
when patching those two particular files, not as the last word on the subject.
If the tarball contains all the maintainer files, and you recommend that two
configure passes be done, instead of this "trick" -- we can do that too.
Phil
Phil,
> you recommend that two configure passes be done, instead of this "trick" -- we
> can do that too
oh - not at all: touching the two files is in fact a recommendable shortcut
(why spending a significant amount of time regenerating files that do not need
it?), and I understand why you wrote the comment. I am just suggesting that
something similar to "when performing minor changes to src/adesklets.c or
src/commands.c, touching these files will avoid unneeded processing" could
withdraw a possible confusion.
In Portage, thanks for the submission!
