Home | Docs | Forums | Lists | Bugs | Planet | Store | GMN | Get Gentoo!

Full Text Bug Listing

Hi,

Please consider attached update to net-analyzer/base. Update includes support
for PHP5, Cherokee web server, and proper default configuration for
>=dev-php/adodb-4.68 users.

Thanks,

Travis Post

Created an attachment (id=79177) [details]
base-1.2.2-r1.ebuild

(In reply to comment #1)

The dependencies are wrong. Besides the weird syntax, your depend on
dev-php5/jpgraph will pull in php-5, which may be undesired for a bunch of
people. I'll attach a better ebuild if I have time. Also, unified diffs are
generally preferred.

(In reply to comment #2)
> (In reply to comment #1)
> 
> The dependencies are wrong.
Which ones?

>Besides the weird syntax, your depend on
> dev-php5/jpgraph will pull in php-5, which may be undesired for a bunch of
> people.
That's true, but depending on dev-php4/jpgraph will pull in php-4, which may be
just as undesirable. There's no elegant solution, unless a new USE flag is
implemented.

As it currently stands, somebody is going to be without graphing
support--either PHP4 users or PHP5 users. I just decided PHP4 users would do
without since PHP5 has been marked stable. And PHP4 can actually still create
charts, it just takes more effort on their part.

This ebuild won't pull in PHP5 so long as the user disables the "gd" and
"gd-external" use flags for this package. And PHP4 users should disable gd and
gd-external in BASE since they're only needed for graphing. By disabling gd,
PHP4 users will have fewer dependencies than those who want to create charts.
It also provides flexibility for those PHP5 users who don't want graphing
support. They can also disable gd, and do without all the unnecessary
dependencies (including jpgraph).

Anyway, I'm sure the ebuild isn't perfect, but it should be very flexible and
easy to maintain. I'd appreciate any help you can offer in writing a new one.

Created an attachment (id=79218) [details]
net-analyzer/base-1.2.2-r1 ebuild

- fixed gd deps
- dropped gd-external use flag completely; require_gd will check for required
gd gd support in php (either gd or gd-external) and avoid bloat in the ebuild
- dropped conditional check and sed on adodb <4.68 (depend.php assumes
>=adodb-4.68 so that was completely pointless)
- dropped cherokee entirely, not familiar with that and webapps are supposed to
work with any webserver, cherokee is a weird alternative webserver anyway. If
you insist on doing some additional configuration for users' convenience, use
lighttpd instead.
- moved mysql/postgresql to RDEPEND
- dropped bogus apache/apache2 from IUSE (want_apache takes care of this)
- changed need_apache to want_apache and dropped a couple of related redundant
stuff
- dropped bogus session use flag
- added back a couple of "${S}" quotes that you've dropped for no reason
- dropped oci8 use flag, why did you add it? We don't need two use flags for
the same thing.
- hmmm, did I forget something?

Also, the ebuild in portage doesn't check for conflicting use flags at all and
does sed-ing in src_unpack() according to them, needs to be fixed somehow, else
you end up with $DBType = "oracle" if you set USE="mysql oracle" e.g. Easiest
solution would be to drop this part (and related use flags) entirely and let
user do the job.

One more note - for stuff like mysql, postgres, mssql or oracle - you need
relevant support in php as well for this stuff to work with net-analyzer/base,
(whether those DBs are local or not), right? Another thing that this ebuild
doesn't check for at all...

Created an attachment (id=79227) [details]
net-analyzer/base-1.2.2-r1 ebuild

Additional fixes for the above-mentioned issues. Please test, won't have more
time to spend on this.

Created an attachment (id=79231) [details]
net-analyzer/base-1.2.2-r1 ebuild (fixed typo)

Sigh, left a stupid mistake in there... Fixed now.

Thanks, in cvs.