Bug 120968

Summary:	taglib 1.4 writes incorrect genre info in ID3v2 tags
Product:	Gentoo Linux	Reporter:	Scott Alfter <scott>
Component:	[OLD] Library	Assignee:	Gentoo KDE team <kde>
Status:	RESOLVED UPSTREAM
Severity:	normal
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	revised ebuild for taglib

Description Scott Alfter 2006-01-30 11:38:31 UTC

I've been working on a command-line tagger that uses TagLib to work with MP3, FLAC, and Ogg Vorbis files (and MPEG4IP to work with AAC, but that's irrelevant here).  The other file formats were working incorrectly, but the genre info on retagged MP3s was screwed up.  When viewing the tag in iTunes, the ID3v1 genre code would be displayed (such as "2" instead of "Country").  When viewing the tag in Winamp, the genre drop-down was empty.

I traced this to some incorrect code in ID3v2::Tag::setGenre().  It tries to look up the genre in the ID3v1 genre list.  If found, it writes the associated code to the ID3v2 tag.  It should just write the text as-is.

I've cobbled together a small patch and put it on my website.  The ebuild that will be attached shortly pulls in this patch.  As far as I can tell, it writes correct ID3v2 tags.

Comment 1 Scott Alfter 2006-01-30 11:39:29 UTC

Created attachment 78513 [details]
revised ebuild for taglib

Comment 2 Scott Alfter 2006-01-30 12:14:14 UTC

PIMF:

s/were working incorrectly/were working correctly/

Comment 3 Wulf Krueger (RETIRED) gentoo-dev

2007-04-15 16:53:37 UTC

Please send this patch to the upstream developer(s). Like that, it will not only get back into the Gentoo package but into other distributions as well.