Bug 120934

Summary:	media-gfx/xfig depends on virtual/x11 (doesn't work with modular Xorg)
Product:	Gentoo Linux	Reporter:	Herve.Roussain
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal	CC:	graphics+disabled
Priority:	High
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Patch for xfig-3.2.4-r1.ebuild to support modular X Patch for xfig-3.2.4-r2.ebuild to support modular X Patch for xfig-3.2.5_alpha5.ebuild to support modular X

Description Herve.Roussain 2006-01-30 05:39:19 UTC

media-gfx/xfig depends on virtual/x11, which 

According to http://www.gentoo.org/proj/en/desktop/x/x11/porting-modular-x-howto.xml, virtual/x11 should be replaced by a separated packages list to support 'modular Xorg'.

The dependencies should be something like this:

DEPEND="|| ( (
        x11-misc/imake
        x11-misc/rman
        x11-libs/libXaw
        x11-proto/xproto
        x11-proto/inputproto )
      virtual/x11 )
    x11-libs/Xaw3d
    media-libs/jpeg
    media-libs/libpng"

RDEPEND="|| ( x11-libs/libXaw
      virtual/x11 )
    x11-libs/Xaw3d
    media-libs/jpeg
    media-libs/libpng
    media-gfx/transfig
    media-libs/netpbm"

Comment 1 Herve.Roussain 2006-01-30 08:39:22 UTC

Created attachment 78503 [details, diff]
Patch for xfig-3.2.4-r1.ebuild to support modular X

Comment 2 Herve.Roussain 2006-01-30 08:39:51 UTC

Created attachment 78504 [details, diff]
Patch for xfig-3.2.4-r2.ebuild to support modular X

Comment 3 Herve.Roussain 2006-01-30 08:40:17 UTC

Created attachment 78505 [details, diff]
Patch for xfig-3.2.5_alpha5.ebuild to support modular X

Comment 4 Herve.Roussain 2006-01-30 08:45:55 UTC

I attached three patches (for the three versions of xfig in portage).

Emerge worked well with xfig-3.2.4-r2, but I don't know if I forgot dependencies.

Note there is an error in my bug report: "app-text/rman" is required (not "x11-misc/rman").

Could someone test the patches and (eventually) apply the patches to the portage tree?

Comment 5 Joshua Baergen (RETIRED) gentoo-dev

2006-02-11 08:38:02 UTC

Thanks, committed.

For future reference, we generally prefer unified diffs (diff -u).

I had to re-structure the DEPEND/RDEPEND system, but the committed deps are roughly what were submitted.  I added libXp for those with USE="-xprint".