Bug 120826 – swt firefox/mozilla use flags

• Product: Gentoo Linux
• Status: RESOLVED DUPLICATE

[Description Jordan 2006-01-29 08:52:33 UTC]

I recently removed the mozilla use flag from my make.conf as I primarily use firefox. I noticed with SWT it starts erroring out saying it still needs it. This doesn't seem consistent with the behavior of other programs (such as epiphany for example.) It certainly seems reasonable to have the firefox flag but not the mozilla one if one wants firefox support but not mozilla support.

It doesn't seem like it'd be a big deal to just have a check for !firefox ( mozilla? (blah) ) instead of how it's doing it now. This should essentially do the same thing as right now except it won't need to spit out a silly error message if you have the firefox flag but not the mozilla one...


I have created an ebuild which swaps around the use flag handling and changes around the mozilla/firefox if check to something a little more sane...

[Comment 1 Jordan 2006-01-29 08:53:50 UTC]

Created attachment 78436 [details]
ebuild that fixes this

this solves the problem and makes more sense to me than spitting out an error message at users....

[Comment 2 Jakub Moc (RETIRED) 2006-01-29 09:07:36 UTC]

Please, attach a diff instead of a huge ebuild, makes it much easier to review the changes...

[Comment 3 Jordan 2006-01-29 09:26:50 UTC]

Created attachment 78441 [details, diff]
a diff between the two...

here you go...

[Comment 4 Jordan 2006-01-29 09:31:03 UTC]

I've posted the diff...

it's fairly simple, I just redid the use checking, removed the silly warning, and redid the mozilla check so it checks for firefox OR mozilla instead of checking for the mozilla flag first, then running a check for firefox later. The later check still needs to be there to determine whether or not to use the settings for mozilla or firefox, but now it works if only the firefox flag is there instead of spitting out a silly error message...

[Comment 5 Anthony Mutiso 2006-07-14 14:38:52 UTC]

Ok the patch does not apply succesfully for me. So I hand patched a local version and tried to build swt on ~amd box and ended up with compile failures. The following two attachments are the ebuild log and my emerge --info files.

Since I have removed mozilla to install seamonkey I am stuck with this swt-3.2_pre1 update.

[Comment 6 Anthony Mutiso 2006-07-14 14:47:26 UTC]

Created attachment 91735 [details]
swt-3.2-pre1 failed ebuild log

My ebuild log from a failed compile on a ~amd using a the patched swt-3.2-pre1 ebuild.

[Comment 7 Anthony Mutiso 2006-07-14 14:49:11 UTC]

Created attachment 91736 [details]
emerge-info for my ~amd workstation associated to comment 5 & 6

As per comment 5.

[Comment 8 Jordan 2006-07-14 17:54:45 UTC]

yeah this patched stopped working a long time ago...the ebuild is way different now (it looked like it got even more obscured since last time when I checked it...) I'd have to rewrite this pretty much entirely.

[Comment 9 Jakub Moc (RETIRED) 2006-07-22 15:14:40 UTC]

Obsoleted by Bug 137665.

*** This bug has been marked as a duplicate of 137665 ***