Bug 120441 - (request) bump dev-libs/nspr to 4.6.1
Bug#: 120441 Product:  Gentoo Linux Version: 2005.1 Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: liquidx@gentoo.org Reported By: h.mth@web.de
Component: Applications
URL: 
Summary: (request) bump dev-libs/nspr to 4.6.1
Keywords:  
Status Whiteboard: 
Opened: 2006-01-26 09:36 0000
Description:   Opened: 2006-01-26 09:36 0000 
This bump is necessary to get bug 120423 solved.

------- Comment #1 From Hanno Meyer-Thurow 2006-01-26 09:37:23 0000 ------- 
Created an attachment (id=78183) [details]
dev-libs/nspr-4.6.1.ebuild

------- Comment #2 From Hanno Meyer-Thurow 2006-01-26 09:40:55 0000 ------- 
Created an attachment (id=78185) [details]
nspr.pc.in

------- Comment #3 From Hanno Meyer-Thurow 2006-01-26 09:56:21 0000 ------- 
It would be great to get this into portage with package.mask entry.
For future Mozilla applications to link to system nspr/nss.

------- Comment #4 From Jory A. Pratt 2006-01-26 10:59:26 0000 ------- 
Soon as this is added I will finish up the work on firefox/thunderbird to build
against nss/nspr packages in tree.

------- Comment #5 From Jory A. Pratt 2006-01-26 11:34:32 0000 ------- 
Created an attachment (id=78204) [details]
updated for multilib systems.

Small changes for multilib systems.

------- Comment #6 From Hanno Meyer-Thurow 2006-01-26 11:47:57 0000 ------- 
Instead of:

        # create pkg-config file
        mkdir -p ${D}/usr/$(get_libdir)/pkgconfig/
        sed -e "s:@NSPR_VER@:${PV}:g" \
                < ${FILESDIR}/${PN}.pc.in \
                > ${D}/usr/$(get_libdir)/pkgconfig/${PN}.pc \
                || die "pkg-config file creation failed!"

        #correct lib dir in nspr.pc
        sed -i "s:libdir=/usr/lib/nspr:libdir=/usr/$(get_libdir)/nspr:g" \
                ${D}/usr/$(get_libdir)/pkgconfig/${PN}.pc || die "failed to
correct nspr.pc"


We may do:

        # create pkg-config file
        mkdir -p ${D}/usr/$(get_libdir)/pkgconfig/
        sed -e "s:@NSPR_VER@:${PV}:g" \
                -e "s:^libdir=.*:libdir=/usr/$(get_libdir)/nspr:" \
                < ${FILESDIR}/${PN}.pc.in \
                > ${D}/usr/$(get_libdir)/pkgconfig/${PN}.pc \
                || die "pkg-config file creation failed!"

With dev-libs/nss likewise then.
Well, just a thought. You may do the way you like.

------- Comment #7 From Jory A. Pratt 2006-01-26 12:02:28 0000 ------- 
either way is fine I was just working out the details quickly is all.

------- Comment #8 From Jory A. Pratt 2006-01-26 12:38:55 0000 ------- 
I am gonna have to make another modification to ebuild. Soon as it is ready I
will update it.

------- Comment #9 From Jory A. Pratt 2006-01-26 12:49:14 0000 ------- 
Created an attachment (id=78212) [details]
fully working 64bit with proper multilib

Aight this is the full working ebuild ppc64 might need a block to enable 64bit
elf support.

------- Comment #10 From Hanno Meyer-Thurow 2006-01-26 12:58:35 0000 ------- 
We may want to enable visibility feature?
http://cvs.fedora.redhat.com/viewcvs/*checkout*/devel/nspr/nspr-4.6.1-gcc-visibility.patch

------- Comment #11 From Jory A. Pratt 2006-01-26 13:30:00 0000 ------- 
Created an attachment (id=78217) [details]
amd64 patch

I seem to have forgotten it so here it is now! :-b

------- Comment #12 From Jory A. Pratt 2006-01-26 13:44:58 0000 ------- 
I have managed to get these bumped in tree sooner then I thought possible. I
will get to mozilla related products just as soon as I can, either next few
days or sunday for sure.

------- Comment #13 From Marcelo Goes 2006-01-26 13:45:39 0000 ------- 
Bumped in cvs, thanks!
Since it had no metadata, added crypto as a herd.
Alastair: feel free do add yourself as a maintainer.

Cheers

------- Comment #14 From Marcelo Goes 2006-01-26 13:46:41 0000 ------- 
As for visibility: I don't think it's much important. If you disagree, please
reopen this bug.

------- Comment #15 From Hanno Meyer-Thurow 2006-01-26 14:16:27 0000 ------- 
If I am not wrong it defines HAVE_VISIBILITY_PRAGMA.
At least for firefox build with gcc-4.1 here.
configure part looks same for nspr as firefox.

So that patch may be useless even.

------- Comment #16 From Jory A. Pratt 2006-01-30 09:57:09 0000 ------- 
I have commited -r1 as it has many changes, I also p.masked as it should have
been to begin with.