Bug 115702 - app-cdr/cdrdao-1.2.1 GCC 4.1 fix for ProgressDialog.h
Bug#: 115702 Product:  Gentoo Linux Version: 2005.1 Platform: All
OS/Version: All Status: RESOLVED Severity: minor Priority: P2
Resolution: FIXED Assigned To: media-optical@gentoo.org Reported By: af1n@o2.pl
Component: GCC Porting
URL:  http://cdrdao.sourceforge.net/
Summary: app-cdr/cdrdao-1.2.1 GCC 4.1 fix for ProgressDialog.h
Keywords:  
Status Whiteboard: 
Opened: 2005-12-15 13:58 0000
Description:   Opened: 2005-12-15 13:58 0000 
GCC 4.1,amd64 emerge =cdrdao-1.2.1 dies here:
ProgressDialog.h:65: error: extra qualification 'ProgressDialog::' on member 'time'

A tivial fix IMHO is:

diff -uw cdrdao-1.2.1.orig/xdao/ProgressDialog.h cdrdao-1.2.1/xdao/ProgressDialog.h
--- cdrdao-1.2.1.orig/xdao/ProgressDialog.h     2005-05-01 11:17:17.000000000 +0200
+++ cdrdao-1.2.1/xdao/ProgressDialog.h  2005-12-15 22:32:25.860011728 +0100
@@ -35,6 +35,7 @@
   ProgressDialog(ProgressDialogPool *father);
   ~ProgressDialog();

+  bool time();
   bool on_delete_event(GdkEventAny*);

 private:
@@ -62,7 +63,6 @@
   bool leadTimeFilled_;

   struct timeval time_;
-  bool ProgressDialog::time();

   Gtk::Button *cancelButton_;
   Gtk::Button *closeButton_;

------- Comment #1 From Mark Loeser 2005-12-16 23:49:28 0000 ------- 
Created an attachment (id=74914) [details]
gcc41 fix

Simple patch yes, but you changed the meaning of the code by making time()
public.  Upstream won't accept a patch that does that :)

------- Comment #2 From Luis Medinas (RETIRED) 2005-12-26 10:17:44 0000 ------- 
patch added. Thanks both