Summary: | django-0.90.ebuild (New Package) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Emmanuel Rosa <emmanuelrosa> |
Component: | New packages | Assignee: | Python Gentoo Team <python> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | bugs.gentoo.org, ia64, jochen+gentoo-bugs, karpi.web, marti, morelli, plasmagunman, sekretarz, VED03370 |
Priority: | High | Keywords: | EBUILD |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
django-0.90.ebuild (New Ebuild)
django-0.90.ebuild (Update) django-0.91.ebuild django-0.91.ebuild (Update) |
Description
Emmanuel Rosa
2005-12-07 18:29:32 UTC
Created attachment 74274 [details]
django-0.90.ebuild (New Ebuild)
Django 0.90 initial ebuild.
Note: Requires unmasking of dev-python/setuptools.
Created attachment 74350 [details]
django-0.90.ebuild (Update)
Added sqlite and postgres USE flags.
Created attachment 78371 [details]
django-0.91.ebuild
This needs inclusion *quick*!
The old ebuild worked with Django 0.91 with a simple version bump, but I decided to spiff it up a bit:
* MY_PN="${PN/d/D}" - this seems to be the preferred way to set MY_PN
* Removed the redundant src_compile section; distutils_src_install is implied by 'inherit distutils' in the src_install section. This was done twice by the ebuild.
* Added all ~arches that Python compiles on, since Django is purely implemented in Python.
I've just took a look at the ebuild. There are some questions I would like to ask: 1. isn't it necessary to include 'dev-db/sqlite' in RDEPEND for sqlite flag, and '<dev-python/psycopg-2' for postgres? 2. is '>=dev-lang/python-2.4.0' OK, instead of '>=dev-lang/python-2.4'? 3. isn't it breaking the policy of gentoo by marking all ~arches? I referred: http://dev.gentoo.org/~plasmaroo/devmanual/keywording/ . 4. why has not this bug been assigned to python herd? (In reply to comment #4) > There are some questions I would like to ask: > 1. isn't it necessary to include 'dev-db/sqlite' in RDEPEND for sqlite flag, > and '<dev-python/psycopg-2' for postgres? The pysqlite ebuild already depends on sqlite. I think It makes more sense to depend only on the pysqlite package rather than add the redundant sqlite dependency - this is how it's done in other packages as well. You're probably right about psycopg, however. I haven't tried Postgre myself yet, so I wouldn't know. > 2. is '>=dev-lang/python-2.4.0' OK, instead of '>=dev-lang/python-2.4'? This should probably be changed. > 3. isn't it breaking the policy of gentoo by marking all ~arches? > I referred: http://dev.gentoo.org/~plasmaroo/devmanual/keywording/ . I just marked all the ~arches that Python is marked stable on. I don't know if this is OK, but it made sense to me since Django is entirely implemented in Python and therefore should work everywhere where Python does. On a second thought, it should be limited to "~alpha ~amd64 ~ppc ~sparc ~x86" as that's what the setuptools dependency works on. > 4. why has not this bug been assigned to python herd? I don't know if there are any reasons, but bug wranglers apparently didn't. Should it? (In reply to comment #5) > The pysqlite ebuild already depends on sqlite. I think It makes more sense to > depend only on the pysqlite package rather than add the redundant sqlite > dependency - this is how it's done in other packages as well. > > You're probably right about psycopg, however. I haven't tried Postgre myself > yet, so I wouldn't know. I don't much care about db, but at least I think the dependencies are logically parallel and ebuild should reflect the parallelism. > I just marked all the ~arches that Python is marked stable on. I don't know if > this is OK, but it made sense to me since Django is entirely implemented in > Python and therefore should work everywhere where Python does. > > On a second thought, it should be limited to "~alpha ~amd64 ~ppc ~sparc ~x86" > as that's what the setuptools dependency works on. Well, I'm not a Gentoo developer and I have no incentive to persuade you to follow the guideline. I guess they will be shoot out later, anyway. > I don't know if there are any reasons, but bug wranglers apparently didn't. > Should it? rails is of dev-ruby, then who does guess django should not be of dev-python? I add python@gentoo.org to CC with this post. *** Bug 125456 has been marked as a duplicate of this bug. *** Created attachment 83251 [details]
django-0.91.ebuild (Update)
Added mysql USE-Flag "mysql" and dependency to dev-python/mysql-python. Also added src_install-voodoo, because original ebuild didn't build on my machine.
In Portage. Thank you very much! Arch teams, please test and keyword. Some instructions: cd Django-0.91/tests Create settings.py; example for postgres (or see docs/tutorial01.txt): DATABASE_ENGINE="postgresql" DATABASE_NAME="mydb" DATABASE_USER="lucass" ./runtests.py --settings settings Thanks. amd64 done ppc done No sparc user asked for this and it's not a dep for anything else that's already keyworded, so no keywording for sparc. Closing. django didn't installed with setuptools-0.6_alpha5. This happens:
---
>>> Install django-0.91 into /var/tmp/portage/django-0.91/image/ category dev-python
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
or: setup.py --help [cmd1 cmd2 ...]
or: setup.py --help-commands
or: setup.py cmd --help
error: option --single-version-externally-managed not recognized
---
But this version dependency is not reflected in ebuild. Adding to depend something like >=dev-python/setuptools-0.6_alpha11 may avoid problems for other users.
-- Nilton
|