Bug 114327 - New better tasting kde-base/qtjava and kde-base/kdejava ebuilds (3.4.3 and 3.5)
|
Bug#:
114327
|
Product: Gentoo Linux
|
Version: unspecified
|
Platform: All
|
|
OS/Version: Linux
|
Status: RESOLVED
|
Severity: normal
|
Priority: P2
|
|
Resolution: FIXED
|
Assigned To: kde@gentoo.org
|
Reported By: chriswhite@gentoo.org
|
|
Component: KDE
|
|
|
URL:
|
|
Summary: New better tasting kde-base/qtjava and kde-base/kdejava ebuilds (3.4.3 and 3.5)
|
|
Keywords:
|
|
Status Whiteboard:
|
|
Opened: 2005-12-03 00:21 0000
|
I was talking to compnerd today on how to test qtjava and kdejava. He looked
at
qtjava ebuild and said it needed some work. I have attached what he came up
with, and I confirm to have gotten working (with 3.4.3 at least).
Chris - I'm all for you updating this ebuild yourself (another KDE dev, step in
and disagree if you like). I don't use qtjava and I doubt any of the other KDE
folks here do as well, so if this works better than what's in portage now I'm
all for it.
Commited the ebuilds I worked with compnerd on. The java stuff is all solid
now.
Could someone please reopen this bug (or fix it)? The qtjava-3.4.3 ebuild was
committed (as qtjava-3.4.3-r1) but the qtjava-3.5.2 is still wrong. I've just
tested fixing this bug is as simple as:
# cp qtjava-3.4.3-r1.ebuild qtjava-3.5.2-r1
It does work and as a side effect it resolves bug #138924 (I think this bug
should block #138924).
Reopening bug per request.
There hasn't any progress on this bug, I don't want it to hold up stabilizing
the new Java system.
Looks like the patch (and for bug 138924 too) isn't perfect anyway, due to both
kde and java defining pkg_setup() and inherit order, only kde's pkg_setup() is
executed here, which means gen-1 java environment isn't set correctly. There
should be an ebuild-defined pkg_setup() calling both kde and java
pkg_setup()'s. Or now that gen-2 java is stable, we can use gen-2 eclasses
instead, where initialization is done via phase hooks.
Created an attachment (id=108767) [details]
patch needed for controlling source/target in gen-2
Because build system doesn't respect our JAVACFLAGS, we need to inject them
like this (inspired by kdejava injecting of CLASSPATH).
Created an attachment (id=108775) [details]
generation-2 java revbump patch for kdejava 3.5.6
KDE team, please check these out. If you want, I can commit it myself and add
java as second herd. This migration to generation-2 java eclasses will fix all
those blocked bugs (once stabled where appropriate).
(In reply to comment #15)
> If you want, I can commit it myself and add
> java as second herd.
Please do both. Thanks :)