Home | Docs | Forums | Lists | Bugs | Planet | Store | GMN | Get Gentoo!

Full Text Bug Listing

Hi,
look here for a description of the problem:
http://www.hydrogenaudio.org/index.php?act=ST&f=16&t=4455&s=92606aafd68b383e83a4e2c24d639774

Attached is a patch from the current lame CVS which solves this problem and an
ebuild which patches lame
lame will be soon released as version 3.93.1 with this patch

Bye

Created an attachment (id=5932) [details]
the patch, to fix the problem

Created an attachment (id=5933) [details]
the ebuild, which uses the patch

Now there's another patch in the lame cvs to work around a quality problem with
-q0
The patch sets -q0 to -q1 

Created an attachment (id=6025) [details]
patch to work around the -q0 problem

Created an attachment (id=6026) [details]
ebuild with both patches

Hey Sebastian,

i added it to the official tree. Thanks for the contribution.

You might want to take a look at the src_unpack(), i made it more portage conform.

-phoen][x-

phoenix, 
this doesn't work for me:
bash-2.05b# ebuild lame-3.93.0-r1.ebuild unpack
>>> md5 ;-) lame-3.93.0.tar.gz
>>> Unpacking source...
>>> Unpacking lame-3.93.0.tar.gz
patching file libmp3lame/lame.c
Hunk #1 FAILED at 20.
1 out of 2 hunks FAILED -- saving rejects to file libmp3lame/lame.c.rej
patching file libmp3lame/psymodel.c
Hunk #1 FAILED at 19.
1 out of 3 hunks FAILED -- saving rejects to file libmp3lame/psymodel.c.rej
>>> Source unpacked.
bash-2.05b# 

Impressive fix, no? ;)

Jonathan, give me an "emerge info" please.

-phoen][x-

Hmm... it works for me with the standard lame-3.93.0.tar.bz2...
But now there's version 3.93.1 so this bug can be closed :)

phoen][x, just for you...

bash-2.05b# emerge info
Portage 2.0.44 (default-ppc-1.4, gcc-sh: line 1: /usr/bin/gcc: No such file or
directory, glibc-2.2.5-r7)
=================================================================
System uname: 2.4.19-r6 ppc 
USE="dvd xv jpeg mitshm gif ppc gnome-libs gdbm berkdb slang aalib guile pam
libwww ssl perl python esd imlib oggvorbis qt opengl mozilla X gtk gtk2 gnome
bonobo evo gb gtkhtml tcltk ncurses sdl png tiff gd mpeg quicktime oss xmms
flash encode crypt imap ldap mbox tcpd cups readline spell truetype xml xml2
pdflib plotutils tetex mysql samba gpm zlib pcmcia moznomail java directfb
-motif -nls -avi -alsa -arts -kde"
ARCH="ppc"
COMPILER="gcc3"
CHOST="powerpc-unknown-linux-gnu"
CFLAGS="-O2 -pipe -mcpu=7400 -maltivec -mabi=altivec -mpowerpc-gfxopt -fsigned-char"
CXXFLAGS="-O2 -pipe -mcpu=7400 -maltivec -mabi=altivec -mpowerpc-gfxopt
-fsigned-char"
ACCEPT_KEYWORDS="ppc ~ppc"
CONFIG_PROTECT="/etc /var/qmail/control /usr/share/config
/usr/kde/2/share/config /usr/kde/3/share/config
/usr/kde/3/share/config:/usr/share/config"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
MAKEOPTS="-j2"
JDK_HOME="/opt/blackdown-jdk-1.3.1"
JAVA_HOME="/opt/blackdown-jdk-1.3.1"
AUTOCLEAN="yes"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
GENTOO_MIRRORS="http://www.ibiblio.org/gentoo"

added myself to CC list

Added lame-3.93.1 to the tree.
Give it a try, please.

-phoen][x-

phoenix,
3.93.1 compiles just fine. are you going to remove the patch from 3.93.0-r1 and
just let it have the quality issue?

I removed lame-3.93.0-r1 and tagged lame-3.93.1 stable for x86.

I ~hope~ it's safe to close this bug now.

Just REOP it again if you need something. :)

-phoen][x-