Bug 111233 - valgrind-3.0.1 and callgrind PIC fixes
Bug#: 111233 Product:  Gentoo Linux Version: 2005.1 Platform: x86
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: caleb@gentoo.org Reported By: solar@gentoo.org
Component: Development
URL:  http://bugs.kde.org/show_bug.cgi?id=115549
Summary: valgrind-3.0.1 and callgrind PIC fixes
Keywords:  
Status Whiteboard: 
Opened: 2005-11-02 05:07 0000
Description:   Opened: 2005-11-02 05:07 0000 
RCS file: /var/cvsroot/gentoo-x86/dev-util/valgrind/valgrind-3.0.1.ebuild,v
retrieving revision 1.1
diff -u -b -B -w -p -r1.1 valgrind-3.0.1.ebuild
--- valgrind-3.0.1.ebuild	30 Aug 2005 20:01:54 -0000	1.1
+++ valgrind-3.0.1.ebuild	2 Nov 2005 13:06:04 -0000
@@ -20,6 +20,10 @@ src_unpack() {
 	unpack ${A}
 	cd "${S}"
 
+	epatch "${FILESDIR}"/valgrind-3.0.1-pic-fix.patch
+	aclocal
+	automake
+
 	# make sure our CFLAGS are respected
 	einfo "Changing configure to respect CFLAGS"
 	sed -i -e 's:CFLAGS="-Wno-long-long":CFLAGS="$CFLAGS -Wno-long-long":' configure

------- Comment #1 From solar 2005-11-02 05:09:17 0000 ------- 
Created an attachment (id=71926) [details]
valgrind-3.0.1-pic-fix.patch

Corrects the miscompiled tools

------- Comment #2 From solar 2005-11-02 08:53:11 0000 ------- 
http://bugs.kde.org/show_bug.cgi?id=115549

------- Comment #3 From PaX Team 2005-11-03 04:18:11 0000 ------- 
Created an attachment (id=72002) [details]
fix for callgrind

since it's valgrind related (and the problem/fix is the same), i'm attaching
the patch to this bug. note that the file 'compile' has to be created, i don't
know where it normally comes from, maybe there's a better way of producing it,
running aclocal/autoconf/etc didn't do much but then i'm not the expert on this
;-). the corresponding ebuild needs the aclocal/automake run of course.

------- Comment #4 From Maurice van der Pot 2005-11-07 12:47:37 0000 ------- 
Valgrind fix has been applied.

Caleb, please check out the patch in comment #3.

------- Comment #5 From Maurice van der Pot 2005-12-05 10:29:30 0000 ------- 
I'm not sure it's relevant anymore with the new release of callgrind.

------- Comment #6 From PaX Team 2005-12-05 13:00:39 0000 ------- 
(In reply to comment #5)
> I'm not sure it's relevant anymore with the new release of callgrind.

it is, 0.10.1 still doesn't supply -fPIC and happily creates text relocations.

------- Comment #7 From SpanKY 2005-12-23 21:59:48 0000 ------- 
the "compile" file comes from autotools, no need to patch it in

------- Comment #8 From Caleb Tennis 2006-03-24 05:15:42 0000 ------- 
I've added the patch to callgrind-0.10.1-r1, removing the compile part of the
patch and changing the directory of the Makefile.am patch from src/ to
build30/.  

This ebuild also provides a build31/ directory, but it uses a bit different
nomenclature so I didn't touch that.  If we need to add a similar patch to that
directory, please reopen and let me know.