Summary: | rc-daemon.sh should correctly use --name (otherwise python daemons don't work) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Alexandre Rostovtsev (RETIRED) <tetromino> |
Component: | [OLD] baselayout | Assignee: | Printing Team <printing> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | dynamotwain, heiko.baums, langthang, samuel.robyr, uberlord |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 97033 | ||
Attachments: | Fixes hplip with baselayout-1.12.0 |
Description
Alexandre Rostovtsev (RETIRED)
2005-09-29 20:14:19 UTC
Actually -- what is the point of rc-daemon.sh ? It mostly appears to duplicate the existing functionality of start-stop-daemon, while introducing bugs like this one. Considering that start-stop-daemon is written in C, which is the language of the gods, while rc-daemon.sh is in bash, which is slow and bug-prone, it seems that the best solution might be to deprecate rc-daemon.sh entirely. (In reply to comment #1) > Actually -- what is the point of rc-daemon.sh ? To add extra functionality over start-stop-daemon - basically it's a wrapper. We also enforce stricter checks - we fail with invalid calling whereas start-stop-daemon has unpredictable behaviour but still works. Basically we enforce the man page. > It mostly appears to duplicate > the existing functionality of start-stop-daemon, while introducing bugs like > this one. It has introduced some bugs, and it has fixed others - namely daemons which claim to start whereas they don't or do start, spawn daemons and then bail due to a invalid config/compile and don't clean up these rogue daemons (asterisk, ntp, many others) It also stopped daemons more efficiently (infact it doesn't even call start-stop-daemon for this) > Considering that start-stop-daemon is written in C, which is the > language of the gods, while rc-daemon.sh is in bash, which is slow and > bug-prone, it seems that the best solution might be to deprecate rc-daemon.sh > entirely. A proficient developer can write code that has less bugs and is faster in bash than a novice developer in C. Language choice does not mean faster code ;) This error is either caused by pidof not worning with scripts that starts with #!/bin/env python or #!/usr/bin/env python Actually these could be perl or bash scripts - they would also fail. Created attachment 69970 [details, diff]
Fixes hplip with baselayout-1.12.0
|