Summary: | pnmtopng (netpbm 10.29) segmentation fault | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Heiko Baums <heiko.baums> |
Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | andychambers2002, vapier |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Fixes case where no alpha mask is not provided as argument
Revised patch that keeps the paths to the source file better matched Ebuild that applies the patch above Forgot to adjust the header Fixed header line |
Description
Heiko Baums
2005-08-31 16:59:44 UTC
Step to Reproduce is of course: pnmtopng input.pnm > output.png Sorry for the typo. Created attachment 67705 [details, diff]
Fixes case where no alpha mask is not provided as argument
Patch for the file /netpbm-10.29/converter/other/pnmtopng.c
Upstream has been notified of the bug and I presume a fix will
appear in a later version. This patch should fix the problem
now though
Created attachment 67761 [details, diff]
Revised patch that keeps the paths to the source file better matched
This is the same patch as before really, the only difference being
I copied how patches to packages are made in other packages.
An revised ebuild that uses the patch follows.
Andy
Created attachment 67762 [details]
Ebuild that applies the patch above
Nuff said
Comment on attachment 67762 [details]
Ebuild that applies the patch above
-r1
Created attachment 67763 [details]
Forgot to adjust the header
Created attachment 67764 [details]
Fixed header line
Apologies for all the wrong attachments. This should
now be correct
(In reply to comment #7) > Apologies for all the wrong attachments. This should > now be correct Never mind. Unfortunately I hadn't had time to test the patches until now. But with the attachments of comment #3 and comment #7 pnmtopng works. Thank you! The only thing that has to be done is to put the patches into the portage tree. thanks, patch now in 10.29-r1 Sorry but the new ebuild and patch in portage doesn't work. This is the error message I get: i686-pc-linux-gnu-gcc -c -I/usr/var/portage/netpbm-10.29-r1/work/netpbm-10.29/other -I. -I -DNDEBUG \ -march=athlon-xp -O2 -pipe -fomit-frame-pointer -o ppmsvgalib.o ppmsvgalib.c i686-pc-linux-gnu-gcc -o ppmsvgalib ppmsvgalib.o \ `/usr/var/portage/netpbm-10.29-r1/work/netpbm-10.29/buildtools/libopt /usr/var/portage/netpbm-10.29-r1/work/netpbm-10.29/lib/libnetpbm.so` libvga.so -lm \ i686-pc-linux-gnu-gcc: libvga.so: No such file or directory make[1]: *** [ppmsvgalib] Error 1 make[1]: Leaving directory `/usr/var/portage/netpbm-10.29-r1/work/netpbm-10.29/other' make: *** [other/all] Error 2 !!! ERROR: media-libs/netpbm-10.29-r1 failed. !!! Function src_compile, Line 567, Exitcode 2 !!! emake failed !!! If you need support, post the topmost build error, NOT this status message. Of course I had svgalib installed and reinstalled svgalib but I still get the same error message. I don't know if this error is caused by this but I found out that your patch is a bit different than Andy's patch in comment #3. In the first line of your patch there's a ~ missing. And are you sure that also in a patch the comments don't need a # at beginning of the line? And your ebuild is pretty different as Andy's in comment #7. Unfortunately I don't know much about building ebuilds, so I can't check this. unrelated this bug is about netpbm crashing, nothing else My bug from comment #10 is related to your bugfix from comment #9 so it is related to this bug. With the original patch and ebuild by Andy Chambers I don't get this installation error. I've just tried that again. That's why your bugfix must have an error somewhere. So my bug from comment #10 is an aftereffect from your fix. Therefore and because your patch has differences to Andy's patch I don't see a reason for opening a new bug. Sorry. no, it is not i rewrote the 10.29-r1 ebuild in addition to this one fix again, this bug is just about pnmtopng segfaulting which is now fixed, it is not about build failure with svga support enabled |