Bug 104384 - net-mail/fetchmail-6.2.5.2 does not really respect USE="-nls"
Bug#: 104384 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: CLOSED Severity: normal Priority: P2
Resolution: TEST-REQUEST Assigned To: net-mail@gentoo.org Reported By: natanael.copa@gmail.com
Component: Applications
URL: 
Summary: net-mail/fetchmail-6.2.5.2 does not really respect USE="-nls"
Keywords:  
Status Whiteboard: 
Opened: 2005-08-31 07:49 0000
Description:   Opened: 2005-08-31 07:49 0000 
Even if -nls is set in USE, fetchmail requires libiconv and gettext (its in the
DEPEND).

Reproducible: Always
Steps to Reproduce:
1. USE=-nls
2.
3.

Actual Results:  
fetchmail gets compiled with localization.

Expected Results:  
fetchmail should be compiled without localization.

libiconv and gettext creates problems in embedded.

------- Comment #1 From Natanael Copa 2005-08-31 07:57:11 0000 ------- 
Created an attachment (id=67344) [details]
fetchmail-6.2.5.2-nonls.patch

This patch should be applied when USE=-nls.
sys-devel/gettext should *only* be in RDEPEND when USE=nls

------- Comment #2 From Natanael Copa 2005-08-31 09:01:21 0000 ------- 
Created an attachment (id=67347) [details]
fetchmail-6.2.5.2-nonls.patch

This patch also strips some lines in the install section in Makefile.in that I
forgot in the previous.

------- Comment #3 From Natanael Copa 2005-08-31 09:03:41 0000 ------- 
Created an attachment (id=67348) [details]
fetchmail-6.2.5.2.ebuild.patch

Patch for the ebuild to apply the previously posted nonls patch.

------- Comment #4 From Natanael Copa 2005-10-08 08:40:21 0000 ------- 
Sorry for making noise, but...

I just fixed this thing once again and were just about to submit a new, very
similar patch when I found out that I already had submitted one.

While I were there, I noticed that the entire thing is trigged by the kerberos
patch who modifies configure.in. That makes make execute autoconf and autoconf
needs the AM_GNU_GETTEXT which fails on embedded (uclibc) systems.

So, I suggest this should happen:

if kerberos is turned on:
    apply kerberos path
    if nls is disabled: apply the nonls-patch
otherwise... just ingnore those patches.

That way will neither the kerberos patch or nonls patch be applied if kerberos
is turned off and autoconf will not be executed. That will dramatically reduce
build time for all non-kerberos users and it will work without the nonsl patch
on embedded.

------- Comment #5 From Natanael Copa 2005-10-08 08:44:10 0000 ------- 
Created an attachment (id=70159) [details]
fetchmail-6.2.5.2.ebuild.patch (update)

It would be nice if this could be commited. (so I won't forget it and fix it a
third time)

------- Comment #6 From Andrej Kacian (RETIRED) 2005-12-10 04:43:04 0000 ------- 
This should be OK in freshly added fetchmail-6.3.0 - it builds fine with
USE=-nls, and it doesn't install .po files into system.

Please test and comment here. Thank you.

------- Comment #7 From Natanael Copa 2005-12-16 02:02:04 0000 ------- 
Works like a charm.

Thanks!

------- Comment #8 From Andrej Kacian (RETIRED) 2005-12-16 02:15:38 0000 ------- 
I'm glad. Closing bug.