Bug 101875 - games-engines/stratagus-2.1 superfluous ogg use flag
Bug#: 101875 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: Linux Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: games@gentoo.org Reported By: carlo@gentoo.org
Component: Games
URL: 
Summary: games-engines/stratagus-2.1 superfluous ogg use flag
Keywords:  
Status Whiteboard: 
Opened: 2005-08-09 09:32 0000
Description:   Opened: 2005-08-09 09:32 0000 
The vorbis use flag denotes ogg/vorbis support (libvorbis depends on libogg).

------- Comment #1 From Carsten Lohrke 2005-08-09 09:34:24 0000 ------- 
Created an attachment (id=65540) [details]
The vorbis use flag denotes ogg/vorbis support, not the other way around
(libvorbis depends on libogg).

------- Comment #2 From SpanKY 2005-08-09 10:11:40 0000 ------- 
just because libvorbis depends on ogg now doesnt mean it always will does it ?

stragus looks for ogg.h and vorbisfile.h as well as libogg.so and libvorbis.so

------- Comment #3 From Carsten Lohrke 2005-08-09 10:48:09 0000 ------- 
>just because libvorbis depends on ogg now doesnt mean it always will does it ?

And in another hypothetical case the stratagus devs may be audiophilists and
feel it's time switch to flac. ;p Enabling vorbis support via ogg use flag is
simply wrong. It denotes only the container format, not the vorbis codec.

------- Comment #4 From Mr. Bones. 2005-09-23 23:36:41 0000 ------- 
Yeah, it's ugly, but I agree.  Especially since the configure script support
flac as well.  I changed the ebuild to only turn on oggvorbis support if both
the ogg and vorbis use flags are set.  I think that allows the ogg/flac
possibility and represents reality a little better.

Thanks for the bug report.