Home | Docs | Forums | Lists | Bugs | Planet | Store | GMN | Get Gentoo!

Full Text Bug Listing

Hi, 
 
I attached a new ebuild for the "Bruce Evans Compiler"; 
 
This is a simple small C compiler including assembler, linker, librarian, 
clib ... which generates code for the x86 in realmode, running on Linux, Elks, 
MS-DOS or standalone on BIOS. 
 
Some bootblocks are included too (I added a useflag for that).

Created an attachment (id=65440) [details]
New ebuild

Please fix the following and reopen:

* KEYWORDS don't follow policy.
* ${A}, ${D} should be quoted.
* cd ${P} looks wrong, shouldn't you be assigning S=?
* That export PATH command scares me.
* Any reason bootblocks needs to be a use flag? It doesn't pull in any deps...

Created an attachment (id=68358) [details]
New ebuild

Ok, here is the next verision of the new ebuild;

> * KEYWORDS don't follow policy.
I added a ~ to x86

> * ${A}, ${D} should be quoted.
done.

> * cd ${P} looks wrong, shouldn't you be assigning S=?
That's right, but the cd isn't neccessary any more so I removed it.

> * That export PATH command scares me.
Ok, I replaced the `pwd` by a '{S}'; however, I need the change to PATH to
allow the freshly build compiler to be found.

>* Any reason bootblocks needs to be a use flag? It doesn't pull in any deps...
I defined the useflag because the bootblocks are optional in the original
package; however, since there are no speed or size constraints, I removed the
useflag. The bootblocks are now always built.

New ebuild updated 

OK, some additional problems here that need fixing.

http://dev.gentoo.org/~ciaranm/docs/mw-faq/header.txt
http://dev.gentoo.org/~ciaranm/docs/mw-faq/hardcoded.txt
http://dev.gentoo.org/~ciaranm/docs/mw-faq/emake.txt

You've also missed the quoting in src_install(). ;)

Created an attachment (id=68429) [details]
new ebuild

So, ready for the next try ... :)

Added to cvs.. xen uses this to build it's firmware.. thanks for the ebuild
Olaf!