99983 2005-07-22 22:27 0000 games-emulation/gnuboy optional display backends and clean up 2006-09-28 05:46:31 0000 1 1 1 Unclassified Gentoo Linux Games unspecified All Linux RESOLVED FIXED P2 normal --- 1 jnrowe@gmail.com games@gentoo.org walch.martin@web.de jnrowe@gmail.com 2005-07-22 22:27:38 0000 The current gnuboy ebuild builds display backends based on whatever it finds on the system, and doesn't record the deps either. Also the package enables some strange GCC options by default, which one would hope a user would never add to their make.conf ;) The package also installs to /usr instead of the /usr/games heirachy that most games adhere to. And finally if you cross compile from an x86 box to a non-x86 target it wrongly tries to build some x86 asm source by default[1]. The attached patch changes the ebuild to: * Fix the deps, and allows the user to build only the frontends they want. * Use the games eclass, and installs to the normal place. * Disable the hardcoded compiler optimisations, allowing the user to set their own craziness. * Only enable the asm emulation core when building for an x86 box[2]. As the changes edit almost every line of the ebuild I decided not to split the patches up as they wouldn't easily apply out of order anyhow. 1. Checks 'uname -m' on the host. 2. To me this seems like the right thing to do in this instance, but maybe there is a better way to reach the right result? And I can't personally see the value in making asm really optional on x86. Hmm, nobody compiles to x86 from non-x86 do they because of [1] :/ Reproducible: Always Steps to Reproduce: 1. 2. 3. jnrowe@gmail.com 2005-07-22 22:28:12 0000 Created an attachment (id=64106) gnuboy-remix.patch jnrowe@gmail.com 2005-07-22 22:48:36 0000 Having just spotted Bug #99546 I want to point out the attached patch fixes that bug too. mr_bones_@gentoo.org 2005-07-31 21:57:36 0000 Couple issues: What happens if they don't have any of the use flags set? There should be a default. Is there a missing dep for fbcon? jnrowe@gmail.com 2005-08-13 06:05:40 0000 First up sorry for the delay, holiday season. (In reply to comment #3) > Couple issues: > > What happens if they don't have any of the use flags set? There should be a > default. Oops, of course there should be. It just really didn't occur to me :/ I've updated the ebuild and defaulted it to SDL, mainly because IMO it is the most usable. Surely there is a simpler way to do the above than the ugly mess I've added though? Comments welcome! (including flames and a pointer at an ebuild in the tree) > Is there a missing dep for fbcon? Unless I'm missing something there aren't any non-system deps for the framebuffer build. It does strictly depend on sys-kernel/linux-headers mind you(linux/fb.h), so it isn't going to work as-is on freebsd(is that supposed to be handled some way?). jnrowe@gmail.com 2005-08-13 06:06:35 0000 Created an attachment (id=65834) gnuboy-cleanup-v2.patch walch.martin@web.de 2005-08-17 05:13:30 0000 *** Bug 99546 has been marked as a duplicate of this bug. *** mr_bones_@gentoo.org 2005-08-28 21:19:30 0000 Ok, it's in there. resync/remerge for more GUIs. Thanks for the bug report and patch. jnrowe@gmail.com 2006-04-10 13:56:52 0000 games-emulation/gnuboy does have extra dependencies when building with support for fb, contrary to my *own* erroneous statement in comment #4. The attached patch adds the required fbset dep when fbcon USE is enabled, I really don't see why I didn't catch it before :/ jnrowe@gmail.com 2006-04-10 13:57:37 0000 Created an attachment (id=84389) gnuboy-fb_deps.patch jnrowe@gmail.com 2006-04-10 14:02:01 0000 Created an attachment (id=84390) gnuboy-fb_deps_fix.patch Should have changed RDEPEND, not DEPEND. nyhm@gentoo.org 2006-09-28 05:46:31 0000 Fixed, thanks. 64106 2005-07-22 22:28 0000 gnuboy-remix.patch gnuboy-remix.patch text/plain UHJlcmVxOiAxLjcKSW5kZXg6IGdudWJveS9nbnVib3ktMS4wLjMuZWJ1aWxkCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIGdudWJveS9nbnVib3ktMS4wLjMuZWJ1aWxkCXtjc2V0IDg4NjNhNzFjLTc3ZmItNGNiNy1h ZDM1LTNhMTNlYWY2YzdmMH0KKysrIGdudWJveS9nbnVib3ktMS4wLjMuZWJ1aWxkCXtsb2NhbCBj bG9uZX0KQEAgLTIsNiArMiw4IEBACiAjIERpc3RyaWJ1dGVkIHVuZGVyIHRoZSB0ZXJtcyBvZiB0 aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgdjIKICMgJEhlYWRlcjogL3Zhci9jdnNyb290 L2dlbnRvby14ODYvZ2FtZXMtZW11bGF0aW9uL2dudWJveS9nbnVib3ktMS4wLjMuZWJ1aWxkLHYg MS43IDIwMDQvMDYvMjQgMjI6Mjg6MjEgYWdyaWZmaXMgRXhwICQKIAoraW5oZXJpdCBnYW1lcwor CiBERVNDUklQVElPTj0iR2FtZWJveSBlbXVsYXRvciB3aXRoIG11bHRpcGxlIHJlbmRlcmVycyIK IEhPTUVQQUdFPSJodHRwOi8vZ251Ym95LnVuaXgtZnUub3JnLyIKIFNSQ19VUkk9Imh0dHA6Ly9n bnVib3kudW5peC1mdS5vcmcvc3JjLyR7UH0udGFyLmd6IgpAQCAtOSwxMSArMTEsMjYgQEAKIExJ Q0VOU0U9IkdQTC0yIgogU0xPVD0iMCIKIEtFWVdPUkRTPSJ4ODYgcHBjIGFtZDY0IgotSVVTRT0i IgorSVVTRT0iWCBmYmNvbiBzZGwgc3ZnYSB4ODYiCisKK1JERVBFTkQ9Ilg/ICggdmlydHVhbC94 MTEgKQorCXNkbD8gKCBtZWRpYS1saWJzL2xpYnNkbCApCisJc3ZnYT8gKCBtZWRpYS1saWJzL3N2 Z2FsaWIgKSIKIAotUkRFUEVORD0ibWVkaWEtbGlicy9saWJzZGwiCitzcmNfY29tcGlsZSgpIHsK KwllZ2FtZXNjb25mIFwKKwkJJCh1c2Vfd2l0aCBYIHgpIFwKKwkJJCh1c2Vfd2l0aCBmYmNvbiBm YikgXAorCQkkKHVzZV93aXRoIHNkbCkgXAorCQkkKHVzZV93aXRoIHN2Z2Egc3ZnYWxpYikgXAor CQkkKHVzZV9lbmFibGUgeDg2IGFzbSkgXAorIAkJLS1kaXNhYmxlLWFyY2ggXAorCQktLWRpc2Fi bGUtb3B0aW1pemUKKwllbWFrZSB8fCBkaWUgImVtYWtlIGZhaWxlZCIKK30KIAogc3JjX2luc3Rh bGwoKSB7Ci0JZG9kb2MgUkVBRE1FIGRvY3MvQ0hBTkdFUyBkb2NzL0NPTkZJRyBkb2NzL0NSRURJ VFMgZG9jcy9GQVEgZG9jcy9IQUNLSU5HIGRvY3MvV0hBVFNORVcKLQlkb2JpbiBmYmdudWJveSBz ZGxnbnVib3kgc2dudWJveSB4Z251Ym95IHx8IGRpZQorCWVnYW1lc2luc3RhbGwKKwlkb2RvYyBS RUFETUUgZG9jcy9DSEFOR0VTIGRvY3MvQ09ORklHIGRvY3MvQ1JFRElUUyBkb2NzL0ZBUSBcCisJ CWRvY3MvSEFDS0lORyBkb2NzL1dIQVRTTkVXCiB9Cg== 65834 2005-08-13 06:06 0000 gnuboy-cleanup-v2.patch gnuboy-cleanup-v2.patch text/plain LS0tIGdudWJveS9nbnVib3ktMS4wLjMuZWJ1aWxkCTIwMDQtMDYtMjQgMjM6Mzc6MDYuMDAwMDAw MDAwICswMTAwCisrKyBnbnVib3kvZ251Ym95LTEuMC4zLmVidWlsZAkyMDA1LTA4LTEzIDA3OjIx OjMzLjAwMDAwMDAwMCArMDEwMApAQCAtMiw2ICsyLDggQEAKICMgRGlzdHJpYnV0ZWQgdW5kZXIg dGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgogIyAkSGVhZGVy OiAvdmFyL2N2c3Jvb3QvZ2VudG9vLXg4Ni9nYW1lcy1lbXVsYXRpb24vZ251Ym95L2dudWJveS0x LjAuMy5lYnVpbGQsdiAxLjcgMjAwNC8wNi8yNCAyMjoyODoyMSBhZ3JpZmZpcyBFeHAgJAogCitp bmhlcml0IGdhbWVzCisKIERFU0NSSVBUSU9OPSJHYW1lYm95IGVtdWxhdG9yIHdpdGggbXVsdGlw bGUgcmVuZGVyZXJzIgogSE9NRVBBR0U9Imh0dHA6Ly9nbnVib3kudW5peC1mdS5vcmcvIgogU1JD X1VSST0iaHR0cDovL2dudWJveS51bml4LWZ1Lm9yZy9zcmMvJHtQfS50YXIuZ3oiCkBAIC05LDEx ICsxMSwzNCBAQAogTElDRU5TRT0iR1BMLTIiCiBTTE9UPSIwIgogS0VZV09SRFM9Ing4NiBwcGMg YW1kNjQiCi1JVVNFPSIiCitJVVNFPSJYIGZiY29uIHNkbCBzdmdhIHg4NiIKKworUkRFUEVORD0i WD8gKCB2aXJ0dWFsL3gxMSApCisJc2RsPyAoIG1lZGlhLWxpYnMvbGlic2RsICkKKwlzdmdhPyAo IG1lZGlhLWxpYnMvc3ZnYWxpYiApCisJIVg/ICggIXN2Z2EgKCAhZmJjb24gKCBtZWRpYS1saWJz L2xpYnNkbCApICkgKSIKKworc3JjX2NvbXBpbGUoKSB7CisJbG9jYWwgbXljb25mCiAKLVJERVBF TkQ9Im1lZGlhLWxpYnMvbGlic2RsIgorCWlmICEgdXNlIFggJiYgISB1c2Ugc3ZnYSAmJiAhIHVz ZSBmYmNvbjsgdGhlbgorCQlteWNvbmY9Ii0td2l0aC1zZGwiCisJZmkKKworCWVnYW1lc2NvbmYg XAorCQkkKHVzZV93aXRoIFggeCkgXAorCQkkKHVzZV93aXRoIGZiY29uIGZiKSBcCisJCSQodXNl X3dpdGggc2RsKSBcCisJCSQodXNlX3dpdGggc3ZnYSBzdmdhbGliKSBcCisJCSQodXNlX2VuYWJs ZSB4ODYgYXNtKSBcCisJCSR7bXljb25mfSBcCisgCQktLWRpc2FibGUtYXJjaCBcCisJCS0tZGlz YWJsZS1vcHRpbWl6ZQorCWVtYWtlIHx8IGRpZSAiZW1ha2UgZmFpbGVkIgorfQogCiBzcmNfaW5z dGFsbCgpIHsKLQlkb2RvYyBSRUFETUUgZG9jcy9DSEFOR0VTIGRvY3MvQ09ORklHIGRvY3MvQ1JF RElUUyBkb2NzL0ZBUSBkb2NzL0hBQ0tJTkcgZG9jcy9XSEFUU05FVwotCWRvYmluIGZiZ251Ym95 IHNkbGdudWJveSBzZ251Ym95IHhnbnVib3kgfHwgZGllCisJZWdhbWVzaW5zdGFsbAorCWRvZG9j IFJFQURNRSBkb2NzL0NIQU5HRVMgZG9jcy9DT05GSUcgZG9jcy9DUkVESVRTIGRvY3MvRkFRIFwK KwkJZG9jcy9IQUNLSU5HIGRvY3MvV0hBVFNORVcKIH0K 84389 2006-04-10 13:57 0000 gnuboy-fb_deps.patch gnuboy-fb_deps.patch text/plain UHJlcmVxOiAxLjExCkluZGV4OiBnbnVib3kvZ251Ym95LTEuMC4zLmVidWlsZAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBnbnVib3kvZ251Ym95LTEuMC4zLmVidWlsZAl7Y3NldCA3ZmNjNWQ0Yi1lZTlkLTQwZWYt OTVjZS03YzI1ZDRmZjIyMDd9CisrKyBnbnVib3kvZ251Ym95LTEuMC4zLmVidWlsZAl7bG9jYWwg Y2xvbmV9CkBAIC0yNiw3ICsyNiw4IEBAIERFUEVORD0iJHtSREVQRU5EfQogCQkJKAogCQkJCXgx MS1wcm90by94ZXh0cHJvdG8KIAkJICAgICAgCXgxMS1wcm90by94cHJvdG8gKQotCQkJdmlydHVh bC94MTEgKSApIgorCQkJdmlydHVhbC94MTEgKSApCisJZmJjb24/ICggc3lzLWFwcHMvZmJzZXQg KSIKIAogc3JjX2NvbXBpbGUoKSB7CiAJbG9jYWwgbXljb25mCg== 84390 2006-04-10 14:02 0000 gnuboy-fb_deps_fix.patch gnuboy-fb_deps_fix.patch text/plain UHJlcmVxOiAxLjExCkluZGV4OiBnbnVib3kvZ251Ym95LTEuMC4zLmVidWlsZAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBnbnVib3kvZ251Ym95LTEuMC4zLmVidWlsZAl7Y3NldCAzYThiZTdhYi0yMzQzLTRmNGIt YmIzNC03NGVlODg4NTFkNWJ9CisrKyBnbnVib3kvZ251Ym95LTEuMC4zLmVidWlsZAl7bG9jYWwg Y2xvbmV9CkBAIC0xOCw3ICsxOCw4IEBAIFJERVBFTkQ9InNkbD8gKCBtZWRpYS1saWJzL2xpYnNk bCApCiAJCSBYPyAoCiAJCSAJfHwgKAogCQkJCXgxMS1saWJzL2xpYlhleHQKLQkJCQl2aXJ0dWFs L3gxMSApICkiCisJCQkJdmlydHVhbC94MTEgKSApCisJZmJjb24/ICggc3lzLWFwcHMvZmJzZXQg KSIKIERFUEVORD0iJHtSREVQRU5EfQogCXN2Z2E/ICggbWVkaWEtbGlicy9zdmdhbGliICkKIAlY PyAoCg==