89241 2005-04-15 17:54 0000 media-libs/sdl-sound can use libmodplug when available 2005-06-20 21:36:40 0000 1 1 1 Unclassified Gentoo Linux Library unspecified All Linux RESOLVED FIXED P2 enhancement --- 1 tsm@accesscomm.ca games@gentoo.org tsm@accesscomm.ca 2005-04-15 17:54:44 0000 now that libmodplug's been seperated out into it's own library, sdl-sound ought to be able to check for and compile in support for it, and I'm happy that it can since modplug is higher-quality and much stabler that mikmod. This turned out to be slightly easier said than done, since it expects modplug.h under /usr/include instead of /usr/include/libmodplug, but a patch for configure.in and some flagomatic magic convinced it to work. I'll attach these. Reproducible: Always Steps to Reproduce: 1. emerge libmodplug 2. tar -zxf SDL_sound-1.0.1.tar.gz ; cd SDL_sound-1.0.1 2. patch < ../gcc311.patch 3. patch < ../libmodplug.patch 4. ./configure --with-modplug ... 5. make, etc Actual Results: sdl-sound compiled with working libmodplug support. Portage 2.0.51.19 (default-linux/amd64/2005.0, gcc-3.4.3-20050110, glibc-2.3.4.20041102-r0, 2.6.5 x86_64) ================================================================= System uname: 2.6.5 x86_64 AMD Opteron(tm) Processor 242 Gentoo Base System version 1.6.10 Python: dev-lang/python-2.2.3-r5,dev-lang/python-2.3.4 [2.3.4 (#1,Jun 29 2004, 09:40:45)] distcc 2.18.3 x86_64-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled] dev-lang/python: 2.2.3-r5, 2.3.4 sys-devel/autoconf: 2.59-r6, 2.13 sys-devel/automake: 1.7.9-r1, 1.8.5-r3, 1.5, 1.4_p6, 1.6.3, 1.9.5 sys-devel/binutils: 2.15.92.0.2-r8 sys-devel/libtool: 1.5.14 virtual/os-headers: 2.6.8.1-r4 ACCEPT_KEYWORDS="amd64 ~amd64" AUTOCLEAN="yes" CFLAGS="-O2 -m64 -mmmx -momit-leaf-frame-pointer -fomit-frame-pointer -pipe -ffast-math -fmerge-all-constants" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.1/share/config /usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3/share/config /usr/share/config /var/qmail/control" CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d" CXXFLAGS="-O2 -m64 -mmmx -momit-leaf-frame-pointer -fomit-frame-pointer -pipe -ffast-math -fmerge-all-constants" DISTDIR="/usr/portage/distfiles" FEATURES="autoaddcvs autoconfig ccache distlocks sandbox" GENTOO_MIRRORS="http://mirrors.tds.net/gentoo ftp://mirrors.tds.net/gentoo ftp://ftp.ndlug.nd.edu/pub/gentoo/" MAKEOPTS="-j3" PKGDIR="/var/backup" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="amd64 X aalib acpi alsa arts berkdb bitmap-fonts cdr crypt cups curl dga dvd esd fam flac font-server foomaticdb fortran gdbm ggi gif gpm gtk guile imagemagick imlib innodb ipv6 java jp2 jpeg kde libwww lzw lzw-tiff mad mikmod motif mp3 mysql ncurses nls nptl oggvorbis opengl oss pam pdflib perl png ppds python qt readline scanner sdl slang speex ssl tcltk tcpd tiff truetype truetype-fonts type1-fonts usb userlocales xml xml2 xmms xpm xrandr xv zlib" Unset: ASFLAGS, CBUILD, CTARGET, LANG, LC_ALL, LDFLAGS tsm@accesscomm.ca 2005-04-15 17:55:59 0000 Created an attachment (id=56391) patch for configure.in Tells configure.in to look for modplug.h in /usr/include/libmodplug/ tsm@accesscomm.ca 2005-04-15 17:57:33 0000 Created an attachment (id=56392) sdl-sound-1.0.1-r2.ebuild Modified ebuild to add support for libmodplug to sdl-sound vapier@gentoo.org 2005-04-15 19:29:28 0000 did you write this patch ? if so, has it been sent upstream ? tsm@accesscomm.ca 2005-04-16 11:15:53 0000 Yes, I wrote this patch. I didn't send upstream since I figured gentoo installing modplug.h in a nonstandard location caused it; but now I see that is not the case. I'll send it, but please don't mark this as upstream when we can fix this here; I don't think another release of SDL_sound 1.x is likely when the SDL_sound devs are occupied working on the 2.0 interface, slated for release sometime in the next 30 years. :p vapier@gentoo.org 2005-04-16 16:00:46 0000 i'll add it to our ebuild if upstream likes it ... sometimes sending patches upstream results in a completely diff way from solving the solution and i prefer to add the final result rather than a bunch of intermediates :p also, i think it'd be better if the configure check would work with either mod package tsm@accesscomm.ca 2005-04-16 21:31:32 0000 > i think it'd be better if the configure check would work with either > mod package It can, I had to build it with USE="-mikmod" to exclude it. It's possible for SDL_sound to have *both* linked in, though I don't know which one it defaults to. tsm@accesscomm.ca 2005-06-18 09:35:19 0000 No reply from upstream, their changelog hasn't changed in 2 years, and their current plans are for(in the distant future) an entirely new 2.0 API rather than changes to 1.0. In light of that, why not fix it in portage? vapier@gentoo.org 2005-06-20 11:40:20 0000 mabye ... but the current posted patch isnt acceptable tsm@accesscomm.ca 2005-06-20 19:55:38 0000 Your objection is that you'd like it to work with either mod package, yes? It *does*. It even works with both: libstdc++.so.6 => //usr/lib/gcc/x86_64-pc-linux-gnu/3.4.3-20050110/libstdc++.so.6 (0x00002aaaaabf4000) libc.so.6 => /lib/tls/libc.so.6 (0x00002aaaaae09000) libXext.so.6 => /usr/lib64/libXext.so.6 (0x00002aaaab02f000) libggi.so.2 => /usr/lib64/libggi.so.2 (0x00002aaaab141000) libgii.so.0 => /usr/lib64/libgii.so.0 (0x00002aaaab24d000) libgg.so.0 => /usr/lib64/libgg.so.0 (0x00002aaaab355000) libaa.so.1 => /usr/lib64/libaa.so.1 (0x00002aaaab45c000) libslang.so.1 => /usr/lib64/libslang.so.1 (0x00002aaaab57b000) libX11.so.6 => /usr/lib64/libX11.so.6 (0x00002aaaab70d000) libFLAC.so.7 => /usr/lib64/libFLAC.so.7 (0x00002aaaab8ef000) libsmpeg-0.4.so.0 => /usr/lib64/libsmpeg-0.4.so.0 (0x00002aaaaba27000) libSDL-1.2.so.0 => /usr/lib64/libSDL-1.2.so.0 (0x00002aaaabba1000) libpthread.so.0 => /lib/tls/libpthread.so.0 (0x00002aaaabd0c000) libmikmod.so.2 => /usr/lib64/libmikmod.so.2 (0x00002aaaabe21000) libdl.so.2 => /lib/libdl.so.2 (0x00002aaaabf6c000) libm.so.6 => /lib/tls/libm.so.6 (0x00002aaaac070000) libmodplug.so.0 => /usr/lib64/libmodplug.so.0 (0x00002aaaac1f6000) libgcc_s.so.1 => /usr/lib/gcc/x86_64-pc-linux-gnu/3.4.3-20050110/libgcc_s.so.1 (0x00002aaaac353000) /lib64/ld-linux-x86-64.so.2 (0x0000555555555000) It didn't use mikmod when I built it last time, because I told it not to use mikmod via USE flags on the commandline. vapier@gentoo.org 2005-06-20 21:36:40 0000 sorry, i thought your patch did something it didnt added to 1.0.1-r2 56391 2005-04-15 17:55 0000 patch for configure.in libmodplug.patch text/plain LS0tIGNvbmZpZ3VyZS5pbi5vcmlnCTIwMDUtMDQtMTUgMTg6MzI6MDQuMjk1NzE0NDY0IC0wNjAw CisrKyBjb25maWd1cmUuaW4JMjAwNS0wNC0xNSAxODozMjoyMC4xNTQzMDM1OTIgLTA2MDAKQEAg LTIxNCw3ICsyMTQsNyBAQAogWyAgLS1lbmFibGUtbW9kcGx1ZyAgICAgICAgICAgZW5hYmxlIE1P RCBkZWNvZGluZyB2aWEgbW9kcGx1ZyBbZGVmYXVsdD15ZXNdXSwKICAgICAgICAgICAgICAgLCBl bmFibGVfbW9kcGx1Zz15ZXMpCiBpZiB0ZXN0IHgkZW5hYmxlX21vZHBsdWcgPSB4eWVzOyB0aGVu Ci0gIEFDX0NIRUNLX0hFQURFUihtb2RwbHVnLmgsIGhhdmVfbW9kcGx1Z19oZHI9eWVzKQorICBB Q19DSEVDS19IRUFERVIobGlibW9kcGx1Zy9tb2RwbHVnLmgsIGhhdmVfbW9kcGx1Z19oZHI9eWVz KQogICBBQ19DSEVDS19MSUIobW9kcGx1ZywgTW9kUGx1Z19Mb2FkLCBoYXZlX21vZHBsdWdfbGli PXllcykKICAgaWYgdGVzdCB4JGhhdmVfbW9kcGx1Z19oZHIgPSB4eWVzIC1hIHgkaGF2ZV9tb2Rw bHVnX2xpYiA9IHh5ZXM7IHRoZW4KICAgICBMSUJTPSIkTElCUyAtbG1vZHBsdWciCg== 56392 2005-04-15 17:57 0000 sdl-sound-1.0.1-r2.ebuild sdl-sound-1.0.1-r2.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA0IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6IC92YXIvY3Zzcm9vdC9nZW50b28teDg2L21lZGlhLWxpYnMvc2RsLXNvdW5kL3NkbC1zb3Vu ZC0xLjAuMS5lYnVpbGQsdiAxLjcgMjAwNC8wNi8yNCAyMzoyMjoxNCBhZ3JpZmZpcyBFeHAgJAoK aW5oZXJpdCBldXRpbHMKaW5oZXJpdCBmbGFnLW8tbWF0aWMKCk1ZX1A9IiR7UC9zZGwtL1NETF99 IgpTPSR7V09SS0RJUn0vJHtNWV9QfQpERVNDUklQVElPTj0iQSBsaWJyYXJ5IHRoYXQgaGFuZGxl cyB0aGUgZGVjb2Rpbmcgb2Ygc291bmQgZmlsZSBmb3JtYXRzIgpIT01FUEFHRT0iaHR0cDovL2lj Y3VsdXMub3JnL1NETF9zb3VuZC8iClNSQ19VUkk9Imh0dHA6Ly9pY2N1bHVzLm9yZy9TRExfc291 bmQvZG93bmxvYWRzLyR7TVlfUH0udGFyLmd6IgoKTElDRU5TRT0iTEdQTC0yLjEiClNMT1Q9IjAi CktFWVdPUkRTPSJ4ODYgcHBjIHNwYXJjIGFtZDY0IgpJVVNFPSJmbGFjIG1pa21vZCBvZ2d2b3Ji aXMgc3BlZXggcGh5c2ZzIGxpYm1vZHBsdWciCgpERVBFTkQ9Ij49bWVkaWEtbGlicy9saWJzZGwt MS4yCgk+PW1lZGlhLWxpYnMvc21wZWctMC40LjQtcjEKCWZsYWM/ICggbWVkaWEtbGlicy9mbGFj ICkKCW1pa21vZD8gKCA+PW1lZGlhLWxpYnMvbGlibWlrbW9kLTMuMS45ICkKCWxpYm1vZHBsdWc/ ICggbWVkaWEtbGlicy9saWJtb2RwbHVnICkKCW9nZ3ZvcmJpcz8gKCA+PW1lZGlhLWxpYnMvbGli dm9yYmlzLTEuMF9iZXRhNCApCglzcGVleD8gKCBtZWRpYS1saWJzL3NwZWV4CgkJbWVkaWEtbGli cy9saWJvZ2cgKQoJcGh5c2ZzPyAoIGRldi1nYW1lcy9waHlzZnMgKSIKCnNyY191bnBhY2soKSB7 Cgl1bnBhY2sgJHtBfQoJY2QgJHtTfQoJZXBhdGNoICR7RklMRVNESVJ9L2djYzMzMS5wYXRjaAoJ ZXBhdGNoICR7RklMRVNESVJ9L2xpYm1vZHBsdWcucGF0Y2gKCXJtIGFjbG9jYWwubTQKCgkjIHRo ZSBwYXRjaCBhYm92ZSBwbHVzIHRoaXMgb3ZlcmtpbGwgcmlwcGVkIG9mZiB0aGUgYm9vdHN0cmFw IHNjaXB0IGZyb20KCSMgdGhlIHNkbF9zb3VuZCBDVlMgdG8gYWRkcmVzcyBidWcgMzExNjMgdW50 aWwgdGhlIG5leHQgcmVsZWFzZS4KCWFjbG9jYWwgfHwgZGllICJhY2xvY2FsIGZhaWxlZCIKCWxp YnRvb2xpemUgLS1hdXRvbWFrZSAtLWNvcHkgLS1mb3JjZSB8fCBkaWUgImxpYnRvb2xpemUgZmFp bGVkIgoJYXV0b2hlYWRlciB8fCBkaWUgImF1dG9oZWFkZXIgZmFpbGVkIgoJYXV0b21ha2UgLS1m b3JlaWduIC0tYWRkLW1pc3NpbmcgLS1jb3B5IHx8IGRpZSAiYXV0b21ha2UgZmFpbGVkIgoJYXV0 b2NvbmYgfHwgZGllICJhdXRvY29uZiBmYWlsZWQiCn0KCnNyY19jb21waWxlKCkgewoJYXBwZW5k LWZsYWdzIC1JL3Vzci9pbmNsdWRlL2xpYm1vZHBsdWcvCgllY29uZiBcCgkJYHVzZV9lbmFibGUg ZmxhY2AgXAoJCWB1c2VfZW5hYmxlIGxpYm1vZHBsdWcgfCBzZWQgcy9saWIvL2dgIFwKCQlgdXNl X2VuYWJsZSBtaWttb2RgIFwKCQlgdXNlX2VuYWJsZSBvZ2d2b3JiaXMgb2dnYCBcCgkJYHVzZV9l bmFibGUgcGh5c2ZzYCBcCgkJYHVzZV9lbmFibGUgc3BlZXhgIFwKCQktLWVuYWJsZS1taWRpIFwK CQl8fCBkaWUKCWVtYWtlIHx8IGRpZSAiZW1ha2UgZmFpbGVkIgp9CgpzcmNfaW5zdGFsbCgpIHsK CWVpbnN0YWxsIHx8IGRpZQoJZG9kb2MgQ0hBTkdFTE9HIENSRURJVFMgSU5TVEFMTCBSRUFETUUg VE9ETwp9Cg==