89174 2005-04-15 05:58 0000 groff fails to compile with non-bash shell due to groff-1.18-no-netpbm-depend.patch 2005-04-26 20:47:05 0000 1 1 1 Unclassified Gentoo Linux Core system unspecified All All RESOLVED FIXED P2 normal --- 1 haubi@gentoo.org base-system@gentoo.org haubi@gentoo.org 2005-04-15 05:58:21 0000 If for some reason groff uses a non-bash shell {sh,ksh} for compilation, the groff-1.18-no-netpbm-depend.patch breaks this. Reproducible: Always Steps to Reproduce: 1. Look at bug 87877 for the backgrounds of such a build-environment. 2. Try to install groff on a sparc-sun-solaris2.8 box with the groff-*.ebuild 3. You do not actually need to do this: there's a patch attached here. Actual Results: for f in ; do \ rm -f /tools/haubi/toolsbox-4-patchespre.haubi/SunOS/var/tmp/portage/groff-1.19.1-r2/image//tools/haubi/toolsbox-4-patchespre.haubi/SunOS/share/doc/groff-1.19.1-r2/examples/$f; \ /tools/haubi/toolsbox-4-patchespre.haubi/SunOS/bin/install -c -m 644 ./$f /tools/haubi/toolsbox-4-patchespre.haubi/SunOS/var/tmp/portage/groff-1.19.1-r2/image//tools/haubi/toolsbox-4-patchespre.haubi/SunOS/share/doc/groff-1.19.1-r2/examples/$f; \ done /bin/ksh: syntax error at line 1 : `;' unexpected make[2]: *** [install_data] Error 2 make[2]: Leaving directory `/wamas/tools/haubi/toolsbox-4-patchespre.haubi/SunOS/var/tmp/portage/groff-1.19.1-r2/work/groff-1.19.1/doc' make[1]: *** [doc] Error 2 make[1]: Leaving directory `/wamas/tools/haubi/toolsbox-4-patchespre.haubi/SunOS/var/tmp/portage/groff-1.19.1-r2/work/groff-1.19.1' make: *** [install] Error 2 haubi@gentoo.org 2005-04-15 06:00:30 0000 Created an attachment (id=56349) let groff compile with non-bash shells too vapier@gentoo.org 2005-04-15 11:09:57 0000 the netpbm patch is just very ugly anyways ... should rewrite it to not suck ... vapier@gentoo.org 2005-04-15 15:35:52 0000 changed the patch so it sets the variables to '' rather than '# ...' haubi@gentoo.org 2005-04-18 07:05:51 0000 Well, the macros _are_ already empty, the '#' is seen by _make_ as a comment. The problem is the shell-code (part 2 in my patch), where _make_ calls the shell like this: system("/bin/sh -c 'for f in ; do ...'") The non-bash-Shell does not accept the "for f in ; do ...", but would accept "for f in ${list} ; do ..." where ${list} expands to empty. vapier@gentoo.org 2005-04-26 20:47:05 0000 *now* you tell me :P updated the netpbm patch 56349 2005-04-15 06:00 0000 let groff compile with non-bash shells too bug.g.o.89174.patch text/plain SW5kZXg6IGdyb2ZmLTEuMTkuMS1yMi5lYnVpbGQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2c3Jv b3Qvd2FtYXMtcG9ydGFnZS9zeXMtYXBwcy9ncm9mZi9ncm9mZi0xLjE5LjEtcjIuZWJ1aWxkLHYK cmV0cmlldmluZyByZXZpc2lvbiAxLjIKZGlmZiAtdSAtcjEuMiBncm9mZi0xLjE5LjEtcjIuZWJ1 aWxkCi0tLSBncm9mZi0xLjE5LjEtcjIuZWJ1aWxkCTEyIEFwciAyMDA1IDA4OjAwOjIwIC0wMDAw CTEuMgorKysgZ3JvZmYtMS4xOS4xLXIyLmVidWlsZAkxNSBBcHIgMjAwNSAxMjo1OToyMyAtMDAw MApAQCAtMjgsNiArMjgsOCBAQAogCSMgRG8gbm90IGdlbmVyYXRlIGV4YW1wbGUgZmlsZXMgdGhh dCByZXF1aXJlIHVzIHRvCiAJIyBkZXBlbmQgb24gbmV0cGJtLgogCWVwYXRjaCAke0ZJTEVTRElS fS9ncm9mZi0xLjE4LW5vLW5ldHBibS1kZXBlbmQucGF0Y2gKKwkjIExldCB0aGlzIHBhdGNoIHdv cmsgd2l0aCBub24tYmFzaCBzaGVsbHMgdG9vICgjODkxNzQpLgorCWVwYXRjaCAke0ZJTEVTRElS fS9ncm9mZi0xLjE4LW5vLW5ldHBibS1kZXBlbmQtbm9iYXNoLnBhdGNoCiAKIAkjIE1ha2UgZGFz aGVzIHRoZSBzYW1lIGFzIG1pbnVzIG9uIHRoZSBrZXlib2FyZCBzbyB0aGF0IHlvdQogCSMgY2Fu IHNlYXJjaCBmb3IgaXQuIEZpeGVzICMxNzU4MCBhbmQgIzE2MTA4CkluZGV4OiBmaWxlcy9ncm9m Zi0xLjE4LW5vLW5ldHBibS1kZXBlbmQtbm9iYXNoLnBhdGNoCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6 IGZpbGVzL2dyb2ZmLTEuMTgtbm8tbmV0cGJtLWRlcGVuZC1ub2Jhc2gucGF0Y2gKZGlmZiAtTiBm aWxlcy9ncm9mZi0xLjE4LW5vLW5ldHBibS1kZXBlbmQtbm9iYXNoLnBhdGNoCi0tLSAvZGV2L251 bGwJMSBKYW4gMTk3MCAwMDowMDowMCAtMDAwMAorKysgZmlsZXMvZ3JvZmYtMS4xOC1uby1uZXRw Ym0tZGVwZW5kLW5vYmFzaC5wYXRjaAkxNSBBcHIgMjAwNSAxMjo1OToyMyAtMDAwMApAQCAtMCww ICsxLDE3IEBACitkaWZmIC1ydU4gZ3JvZmYtMS4xOS4xLm9yaWcvZG9jL01ha2VmaWxlLnN1YiBn cm9mZi0xLjE5LjEvZG9jL01ha2VmaWxlLnN1YgorLS0tIGdyb2ZmLTEuMTkuMS5vcmlnL2RvYy9N YWtlZmlsZS5zdWIJMjAwNS0wNC0xNSAxNDoxODo1Mi45MjAwMDMwMDAgKzAyMDAKKysrKyBncm9m Zi0xLjE5LjEvZG9jL01ha2VmaWxlLnN1YgkyMDA1LTA0LTE1IDE0OjIxOjA1LjM5MDAwMjAwMCAr MDIwMAorQEAgLTE3MCwxMSArMTcwLDExIEBACisgCSAgJChJTlNUQUxMX0RBVEEpICQkZiAkKGRv Y2RpcikvJCRmOyBcCisgCWRvbmUKKyAJLXRlc3QgLWQgJChleGFtcGxlZGlyKSB8fCAkKG1raW5z dGFsbGRpcnMpICQoZXhhbXBsZWRpcikKKy0JZm9yIGYgaW4gJChFWEFNUExFRklMRVMpOyBkbyBc CisrCWxpc3Q9IiQoRVhBTVBMRUZJTEVTKSI7IGZvciBmIGluICQke2xpc3R9OyBkbyBcCisgCSAg cm0gLWYgJChleGFtcGxlZGlyKS8kJGY7IFwKKyAJICAkKElOU1RBTExfREFUQSkgJChzcmNkaXIp LyQkZiAkKGV4YW1wbGVkaXIpLyQkZjsgXAorIAlkb25lCistCWZvciBmIGluICQoUFJPQ0VTU0VE RVhBTVBMRUZJTEVTKTsgZG8gXAorKwlsaXN0PSIkKFBST0NFU1NFREVYQU1QTEVGSUxFUykiOyBm b3IgZiBpbiAkJHtsaXN0fTsgZG8gXAorIAkgIHJtIC1mICQoZXhhbXBsZWRpcikvJCRmOyBcCisg CSAgJChJTlNUQUxMX0RBVEEpICQkZiAkKGV4YW1wbGVkaXIpLyQkZjsgXAorIAlkb25lCg==