84228 2005-03-05 13:41 0000 sysfsutils: libsysfs write_attribute bug if attribute is empty 2005-05-20 05:54:33 0000 1 1 1 Unclassified Gentoo Linux Core system unspecified All Linux RESOLVED FIXED InCVS P2 normal --- 84234 1 linux@brodo.de gregkh@gentoo.org gurligebis@gentoo.org henrik@brixandersen.dk linux@brodo.de 2005-03-05 13:41:46 0000 The check in libsysfs::write_attribute() which tests whether the value to be written into a sysfs attribute is already there should only trigger if the length of both strings is the same. This patch, already accepted by upstream for sysfsutils-1.4.0, is needed for pcmciautils to work correctly. Reproducible: Always Steps to Reproduce: linux@brodo.de 2005-03-05 13:42:39 0000 Created an attachment (id=52742) patch for libsysfs-1.2.0 linux@brodo.de 2005-03-05 13:43:25 0000 Created an attachment (id=52743) ebuild for sysfsutils-1.2.0-r1 henrik@brixandersen.dk 2005-05-15 01:52:09 0000 Greg, can we get this patch merged into portage? It's the only issue holding back the addition of pcmciautils to portage (bug #84234). If you want, I can add the patch and do the revision bump of sysfsutils. gregkh@gentoo.org 2005-05-16 20:57:06 0000 Sorry, feel free to do it yourself, haven't had much gentoo specific time lately :( henrik@brixandersen.dk 2005-05-20 05:54:33 0000 Added write_attribute() patch to sys-fs/sysfsutils-1.2.0-r1. Thanks. 52742 2005-03-05 13:42 0000 patch for libsysfs-1.2.0 libsysfs-write-attribute.patch text/plain SGksCgppbnQgc3lzZnNfd3JpdGVfYXR0cmlidXRlKHN0cnVjdCBzeXNmc19hdHRyaWJ1dGUgKnN5 c2F0dHIsCiAgICAgICAgICAgICAgICBjb25zdCBjaGFyICpuZXdfdmFsdWUsIHNpemVfdCBsZW4p CgpoYXMgYSBwcm9ibGVtYXRpYyAiZmVhdHVyZSI6IGlmIHRoZSBmaWxlIGlzIGVtcHR5IGJ1dCBy ZWFkYWJsZSwgbm90aGluZyBnZXRzCndyaXR0ZW4gaW50byBpdC4gVGhlIGF0dGFjaGVkIHBhdGNo ICh1bnRlc3RlZCkgc2hvdWxkIGZpeCBpdC4KCglEb21pbmlrCgoKVGhlIGNoZWNrIHdoaWNoIHRl c3RzIHdoZXRoZXIgdGhlIHZhbHVlIHRvIGJlIHdyaXR0ZW4gaW50byBhIHN5c2ZzIGF0dHJpYnV0 ZQppcyBhbHJlYWR5IHRoZXJlIHNob3VsZCBvbmx5IHRyaWdnZXIgaWYgdGhlIGxlbmd0aCBvZiBi b3RoIHN0cmluZ3MgaXMgdGhlCnNhbWUuCgpTaWduZWQtb2ZmLWJ5OiBEb21pbmlrIEJyb2Rvd3Nr aSA8bGludXhAZG9taW5pa2Jyb2Rvd3NraS5uZXQ+CgotLS0gc3lzZnN1dGlscy0xLjIuMC9saWIv c3lzZnNfZGlyLmMub3JpZ2luYWwJMjAwNS0wMi0yMSAwODoxMDozMy4wMDAwMDAwMDAgKzAxMDAK KysrIHN5c2ZzdXRpbHMtMS4yLjAvbGliL3N5c2ZzX2Rpci5jCTIwMDUtMDItMjEgMDg6MTQ6MDEu MDAwMDAwMDAwICswMTAwCkBAIC0xOTQsNyArMTk0LDggQEAKIAkJCWRwcmludGYoIkVycm9yIHJl YWRpbmcgYXR0cmlidXRlXG4iKTsKIAkJCXJldHVybiAtMTsKIAkJfQotCQlpZiAoKHN0cm5jbXAo c3lzYXR0ci0+dmFsdWUsIG5ld192YWx1ZSwgc3lzYXR0ci0+bGVuKSkgPT0gMCkgeworCQlpZiAo KChzdHJuY21wKHN5c2F0dHItPnZhbHVlLCBuZXdfdmFsdWUsIHN5c2F0dHItPmxlbikpID09IDAp JiYKKwkJICAgIChsZW4gPT0gc3lzYXR0ci0+bGVuKSkgewogCQkJZHByaW50ZigiQXR0ciAlcyBh bHJlYWR5IGhhcyB0aGUgcmVxdWVzdGVkIHZhbHVlICVzXG4iLAogCQkJCQlzeXNhdHRyLT5uYW1l LCBuZXdfdmFsdWUpOwogCQkJcmV0dXJuIDA7CQo= 52743 2005-03-05 13:43 0000 ebuild for sysfsutils-1.2.0-r1 sysfsutils-1.2.0-r1.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA1IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6IC92YXIvY3Zzcm9vdC9nZW50b28teDg2L3N5cy1mcy9zeXNmc3V0aWxzL3N5c2ZzdXRpbHMt MS4yLjAuZWJ1aWxkLHYgMS40IDIwMDUvMDMvMDMgMTY6NTI6MzEgY29yc2FpciBFeHAgJAoKaW5o ZXJpdCBldXRpbHMgbGlidG9vbCBnbnVjb25maWcKCkRFU0NSSVBUSU9OPSJTeXN0ZW0gVXRpbGl0 aWVzIEJhc2VkIG9uIFN5c2ZzIgpIT01FUEFHRT0iaHR0cDovL2xpbnV4LWRpYWcuc291cmNlZm9y Z2UubmV0L1N5c2ZzdXRpbHMuaHRtbCIKU1JDX1VSST0ibWlycm9yOi8vc291cmNlZm9yZ2UvbGlu dXgtZGlhZy8ke1B9LnRhci5neiIKCkxJQ0VOU0U9IkdQTC0yIExHUEwtMi4xIgpTTE9UPSIwIgpL RVlXT1JEUz0ifng4NiB+cHBjIH5zcGFyYyB+bWlwcyB+YXJtIH5ocHBhIH5hbWQ2NCB+YWxwaGEg fnBwYzY0IgpJVVNFPSIiCgpERVBFTkQ9InZpcnR1YWwvbGliYyIKCnNyY19jb21waWxlKCkgewoJ IyBEZXRlY3QgbWlwcyBzeXN0ZW1zIHByb3Blcmx5CglnbnVjb25maWdfdXBkYXRlCgoJY2QgJHtT fQoJZXBhdGNoICR7RklMRVNESVJ9L2xpYnN5c2ZzLXdyaXRlLWF0dHJpYnV0ZS5wYXRjaAoKCWVj b25mIHx8IGRpZSAiLi9jb25maWd1cmUgZmFpbGVkIgoKCWVtYWtlIHx8IGRpZQp9CgpzcmNfaW5z dGFsbCgpIHsKCW1ha2UgREVTVERJUj0ke0R9IGluc3RhbGwgfHwgZGllCgoJIyBXZSBkbyBub3Qg ZGlzdHJpYnV0ZSB0aGlzCglybSAtZiAke0R9L3Vzci9iaW4vZGxpc3RfdGVzdAoKCWRvZG9jIEFV VEhPUlMgQ2hhbmdlTG9nIE5FV1MgUkVBRE1FIFRPRE8KCSMgRklYTUU6IGNtZC9HUEwgYW5kIGxp Yi9MR1BMIGRvIG5vdCBleGlzdCAtIHNob3VsZCB3ZQoJIyAgICAgICAgdGhlbiByYXRoZXIgYWRk IHRoZW0gbWFudWFsbHkgPwoJZG9kb2MgY21kL0dQTCBsaWIvTEdQTCBkb2NzL2xpYnN5c2ZzLnR4 dAp9Cg==