83978 2005-03-03 10:29 0000 net-www/awstats ebuild erroneously replaces default value in awstats.model.conf.file 2005-03-21 05:36:05 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED P2 trivial --- 1 jakub@gentoo.org ka0ttic@gentoo.org jakub@gentoo.org 2005-03-03 10:29:22 0000 Ebuild is replacing values in awstats.model.conf via sed, but the following value should NOT be replaced, it needs to be boolean. Reproducible: Always Steps to Reproduce: 1. emerge awstats Actual Results: # Possible values: 0 or 1 # Default: 0 # PurgeLogFile="/var/log/apache/access_log" # This parameter is not used if PurgeLogFile="/var/log/apache/access_log" # Change : Effective for new updates only # Possible values: 0 or 1 # Default: 0 # ArchiveLogRecords=0 Expected Results: # Possible values: 0 or 1 # Default: 0 # PurgeLogFile=0 # When PurgeLogFile is setup to 1, AWStats will clean your log file after # processing it. You can however keep an archive file (saved in "DirData") of # all processed log records by setting this to 1 (For example if you want to # use another log analyzer). # This parameter is not used if PurgeLogFile=0 Tutonka3000@aol.com 2005-03-03 12:19:30 0000 While we're looking at this ebuild, I noticed that the ebuild did not correctly execute line 50. The configuration file erroneously points to /var/log/apache/access_log instead of /var/log/apache2/access_log. Line 50 uses a variable APACHEVER which may not exist: john # echo $APACHEVER john # Maybe I'm doing something wrong? I tried googleing APACHEVER and all it comes up with is makefiles which aren't that helpful. jakub@gentoo.org 2005-03-03 12:27:32 0000 John: Yes, that jakub@gentoo.org 2005-03-03 12:27:32 0000 John: Yes, that´s another error (ebuild does not detect installed Apache version correctly). I did not notice this one. ;-) Anyway, PurgeLogFile takes boolean only, i.e. 0/1. ka0ttic@gentoo.org 2005-03-21 05:36:05 0000 Yeah the problem was the first sed expression should've used ^LogFile instead of just LogFile. It was replacing both LogFile and PurgeLogFile. Also, thanks for pointing out ${APACHEVER}. I think it is left over from the mess that was (or still is mostly) awstats prior to me taking over maintainership. Fixed in both 6.3-r2 and 6.4.