83000 2005-02-22 13:27 0000 portmap Makefile SYS variable usage breaks compile 2005-02-22 14:36:03 0000 1 1 1 Unclassified Gentoo Linux Core system unspecified All All RESOLVED FIXED http://forums.gentoo.org/viewtopic-t-299090.html P2 normal --- 1 mihailim@gmail.com net-fs@gentoo.org mihailim@gmail.com 2005-02-22 13:27:13 0000 The net-nds/portmap Makefile contains the following snippet around line 110: COPT = $(CONST) -Dperror=xperror $(CHECK_PORT) \ $(SYS) -DFACILITY=$(FACILITY) $(ULONG) $(ZOMBIES) $(SA_LEN) \ $(LOOPBACK) $(SETPGRP) If the user has the environment variable SYS set to anything besides whitespace, the compile bombs out. Examples: http://forums.gentoo.org/viewtopic-t-299090.html http://bugs.gentoo.org/show_bug.cgi?id=81430 I haven't seen any situation yet where it would be useful for a Gentoo Linux system to let the Makefile blindly pull this in from the environment, but I've encountered reports of this type of problem a few times already. So it would seem the default behavior should be changed to *not* pull in $(SYS) from the environment since it's a variable name likely to be used. I think we should patch portmap's Makefile to either use a different name there, or to simply not use it at all. I'm not sure about the implications of not using SYS on a Solaris system, but since Portaris is very much under work I don't think it should be a blocker. Reproducible: Always Steps to Reproduce: SYS="whatever" emerge net-nds/portmap Actual Results: Compile fails with "cannot specify -o with -c or -S and multiple compilations" mihailim@gmail.com 2005-02-22 13:30:33 0000 I forgot an additional argument for patching it: The resulting errors give no clue whatsoever to the typical user as to the root cause of the problem and to what one should do to fix it. Tracking it down requires an unpack step and an understanding on Makefile and compiler command line syntax. That's a no-no. mihailim@gmail.com 2005-02-22 13:42:10 0000 Created an attachment (id=51900) Patch renaming $(SYS) This patch alters the Makefile usage of the environment variable SYS to GLOCAL_SYS. mihailim@gmail.com 2005-02-22 13:42:34 0000 Created an attachment (id=51901) Patch to ebuild to use portmap-5b-renamesysvar.patch vapier@gentoo.org 2005-02-22 14:36:03 0000 deleted the variable all together since the makefile doesnt use it at all 51900 2005-02-22 13:42 0000 Patch renaming $(SYS) portmap-5b-renamesysvar.patch text/plain ZGlmZiAtTmF1ciBwb3J0bWFwXzViZXRhL01ha2VmaWxlIHBvcnRtYXBfNWJldGFfbm9zeXMvTWFr ZWZpbGUKLS0tIHBvcnRtYXBfNWJldGEvTWFrZWZpbGUJMjAwNS0wMi0yMiAyMzoxNzozMS41MTAx ODQ4OTYgKzAyMDAKKysrIHBvcnRtYXBfNWJldGFfbm9zeXMvTWFrZWZpbGUJMjAwNS0wMi0yMiAy MzozNTowNy44NDc1OTcyMDAgKzAyMDAKQEAgLTEwOSw3ICsxMDksNyBAQAogU0hFTEwJPSAvYmlu L3NoCiAKIENPUFQJPSAkKENPTlNUKSAtRHBlcnJvcj14cGVycm9yICQoQ0hFQ0tfUE9SVCkgXAot CSQoU1lTKSAtREZBQ0lMSVRZPSQoRkFDSUxJVFkpICQoVUxPTkcpICQoWk9NQklFUykgJChTQV9M RU4pIFwKKwkkKEdMT0NBTF9TWVMpIC1ERkFDSUxJVFk9JChGQUNJTElUWSkgJChVTE9ORykgJCha T01CSUVTKSAkKFNBX0xFTikgXAogCSQoTE9PUEJBQ0spICQoU0VUUEdSUCkKIENGTEFHUwk9ICQo Q09QVCkgJChPKSAkKE5TQVJDSFMpCiBPQkpFQ1RTCT0gcG9ydG1hcC5vIHBtYXBfY2hlY2subyBm cm9tX2xvY2FsLm8gJChBVVgpCg== 51901 2005-02-22 13:42 0000 Patch to ebuild to use portmap-5b-renamesysvar.patch portmap-ebuild.patch text/plain LS0tIC91c3IvcG9ydGFnZS9uZXQtbmRzL3BvcnRtYXAvcG9ydG1hcC01Yi1yOS5lYnVpbGQJMjAw NS0wMi0wNyAyMjoxMToxMS4wMDAwMDAwMDAgKzAyMDAKKysrIC91c3IvbG9jYWwvcG9ydGFnZS9u ZXQtbmRzL3BvcnRtYXAvcG9ydG1hcC01Yi1yOS5lYnVpbGQJMjAwNS0wMi0yMiAyMzozODo0OC42 ODkwMjQyMDAgKzAyMDAKQEAgLTQ2LDYgKzQ2LDEwIEBACiAKIAkjIE1ha2UgdGNwIHdyYXBwZXIg Y2hlY2tzIGVhc2llcgogCWVwYXRjaCAke0ZJTEVTRElSfS8ke1B9LW9wdGlvbmFsLXRjcGQucGF0 Y2gKKworCSMgU1lTIHZhcmlhYmxlIHJlbmFtaW5nCisJZXBhdGNoICR7RklMRVNESVJ9LyR7UH0t cmVuYW1lc3lzdmFyLnBhdGNoCisKIH0KIAogc3JjX2NvbXBpbGUoKSB7Cg==