<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://bugs.gentoo.org/bugzilla.dtd">

<bugzilla version="2.22.7"
          urlbase="http://bugs.gentoo.org/"
          maintainer="bugzilla@gentoo.org"
>

    <bug>
          <bug_id>79692</bug_id>
          
          <creation_ts>2005-01-27 02:49 0000</creation_ts>
          <short_desc>pbbuttonsd version bump to 0.6.7</short_desc>
          <delta_ts>2005-02-18 20:16:36 0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>Gentoo Linux</product>
          <component>Applications</component>
          <version>unspecified</version>
          <rep_platform>PPC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          <bug_file_loc>http://pbbuttons.sourceforge.net/</bug_file_loc>
          
          
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>toojays@toojays.net</reporter>
          <assigned_to>ppc@gentoo.org</assigned_to>
          <cc>ppc@gentoo.org</cc>

      

      
          <long_desc isprivate="0">
            <who>toojays@toojays.net</who>
            <bug_when>2005-01-27 02:49:56 0000</bug_when>
            <thetext>This version includes my patch for ALSA support. :)
It also adds support to switch on/off display mirroring using hotkeys, but I haven&apos;t tried this feature, not sure how/if it will work on my iBook G4.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>lu_zero@gentoo.org</who>
            <bug_when>2005-01-27 04:18:35 0000</bug_when>
            <thetext>Anybody with a working laptop is willing to test?</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>josejx@gentoo.org</who>
            <bug_when>2005-01-27 08:27:45 0000</bug_when>
            <thetext>Tests okay here.  I had to change my config to reflect the ALSA changes (I was getting segfaults with my old config), but that was probably user error.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>toojays@toojays.net</who>
            <bug_when>2005-01-27 23:16:41 0000</bug_when>
            <thetext>Joe,

If you are getting segfaults, can you writeup a report for me or Matthias? A problem with the config file should not be causing a segfault.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>toojays@toojays.net</who>
            <bug_when>2005-01-27 23:18:06 0000</bug_when>
            <thetext>To clarify my last comment: It is probably true that the config file is causing the segfault, but we consider that to be a bug in the program, and would like to fix it.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>josejx@gentoo.org</who>
            <bug_when>2005-01-28 16:48:16 0000</bug_when>
            <thetext>Created an attachment (id=49783)
Config that causes segfaults

Okay, here is the config that causes segfaults here.  I was using this config
sucessfully on previous versions of pbbuttonsd.  Switching the config to the
ALSA settings that are commented out stops the segfaults.  I do use ALSA and
not OSS, but I would think that OSS should still work since I have OSS
emulation enabled.  If I get a chance, I&apos;ll try and look at it.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>toojays@toojays.net</who>
            <bug_when>2005-01-30 03:06:05 0000</bug_when>
            <thetext>I haven&apos;t had a chance to test this patch against Joe&apos;s config, but it may be the same issue reported by debian:

http://sourceforge.net/mailarchive/forum.php?thread_id=6430700&amp;forum_id=40677

The patch looks like:
--- pbbuttonsd-0.6.7/src/module_alsamixer.c	2005-01-24 19:50:37.000000000 +0100
+++ pbbuttonsd-0.6.7-new/src/module_alsamixer.c	2005-01-27 16:24:18.000000000 +0100
@@ -434,9 +434,15 @@
 alsamixer_exit ()
 {
 	struct moddata_alsamixer *base = &amp;modbase_alsamixer;
-	free (base-&gt;elements);
-	base-&gt;elements = NULL;
-	snd_mixer_free (base-&gt;mixer);
+
+	if (base-&gt;elements) {
+		free (base-&gt;elements);
+		base-&gt;elements = NULL;
+	}
+
+	if (base-&gt;mixer)
+		snd_mixer_free (base-&gt;mixer);
+	
 	base-&gt;init_complete = 0;
 	return 0;
 }</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <who>josejx@gentoo.org</who>
            <bug_when>2005-02-18 20:16:36 0000</bug_when>
            <thetext>Okay, the patch supplied fixed the problem, I&apos;ve added the new version of pbbuttonsd to CVS as ~ppc, along with the patch.</thetext>
          </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>49783</attachid>
            <date>2005-01-28 16:48 0000</date>
            <desc>Config that causes segfaults</desc>
            <filename>pbbuttonsd.conf</filename>
            <type>text/plain</type>
            <data encoding="base64">IyBDb25maWd1cmF0aW9uIGZpbGUgZm9yIFBCQnV0dG9uc2QgPj0gVmVyc2lvbiAwLjUKIyBmb3Ig
Y29tcGxldGUgbGlzdCBvZiBvcHRpb25zIHBsZWFzZSBzZWUgcGJidXR0b25zZC5jb25mIG1hbi1w
YWdlCgojIFtTWVNURU1dCiN1c2VyYWxsb3dlZCAgICAgICAgICAgPSAicGFyYW5vaWQiIDsgdXNl
ciB3aG8gaXMgYWxsb3dlZCB0byB1c2UgSVBDCmF1dG9yZXNjYW4gICAgICAgICAgICA9IG5vCTsg
YXV0b21hdGljIHJlc2NhbiBvZiBldmVudCBkZXZpY2VzCkNtZFRpbWVvdXQgICAgICAgICAgICA9
IDQKCiMgW01PRFVMRSBQT1dFUlNBVkVdCm9uQUNfcG9saWN5ICAgICAgICAgICA9IHBlcmZvcm1h
bmNlICAgIDsgbm9jaGFuZ2UsIHBlcmZvcm1hbmNlLCBjdXN0b20gb3IgcG93ZXJzYXZlCm9uQUNf
VGltZXJBY3Rpb24gICAgICA9IG5vbmUgICAgICAgICAgIDsgbm9uZSwgc3VzcGVuZC10by1yYW0s
IHN1c3BlbmQtdG8tZGlzaywgYmxhbmtzY3JlZW4Kb25BQ19Db3ZlckFjdGlvbiAgICAgID0gc3Vz
cGVuZC10by1yYW0Kb25BQ19LZXlBY3Rpb24gICAgICAgID0gc3VzcGVuZC10by1yYW0gOyBTbGVl
cEtleQpvbkFDX1N1c3BlbmRUaW1lICAgICAgPSAwICAgICAgICAgICAgICA7IHRpbWUgaW4gMS8x
MCBzZWNvbmRzCm9uQUNfRGltVGltZSAgICAgICAgICA9IDAgICAgICAgICAgICAgIDsgdGltZSBp
biAxLzEwIHNlY29uZHMKCm9uQmF0dGVyeV9wb2xpY3kgICAgICA9IHBvd2Vyc2F2ZQpvbkJhdHRl
cnlfVGltZXJBY3Rpb24gPSBzdXNwZW5kLXRvLXJhbSA7IG5vbmUsIHN1c3BlbmQtdG8tcmFtLCBz
dXNwZW5kLXRvLWRpc2ssIGJsYW5rc2NyZWVuCm9uQmF0dGVyeV9Db3ZlckFjdGlvbiA9IHN1c3Bl
bmQtdG8tcmFtCm9uQmF0dGVyeV9LZXlBY3Rpb24gICA9IHN1c3BlbmQtdG8tcmFtIDsgU2xlZXBL
ZXkKb25CYXR0ZXJ5X1N1c3BlbmRUaW1lID0gMzAwMCAgICAgICAgICAgOyB0aW1lIGluIDEvMTAg
c2Vjb25kcwpvbkJhdHRlcnlfRGltVGltZSAgICAgPSA2MDAgICAgIDsgdGltZSBpbiAxLzEwIHNl
Y29uZHMKClNsZWVwS2V5ICAgICAgICAgICAgICA9IDExNgpTbGVlcEtleURlbGF5ICAgICAgICAg
PSAwCTsgdmFsdWVzID4gMCBtYXkgYmUgZGFuZ2Vyb3VzLCBpZiB0aGUgcG93ZXIga2V5IGlzIHVz
ZWQgdG8gdHJpZ2dlciBzbGVlcApCV0xfZmlyc3QgICAgICAgICAgICAgPSAyMgk7IGZpcnN0IGJh
dHRlcnkgd2FybmxldmVsLCB0aW1lIGluIG1pbnV0ZXMKQldMX3NlY29uZCAgICAgICAgICAgID0g
MTAJOyBzZWNvbmQgYmF0dGVyeSB3YXJubGV2ZWwsIHRpbWUgaW4gbWludXRlcwpCV0xfbGFzdCAg
ICAgICAgICAgICAgPSAzCTsgbGFzdCBiYXR0ZXJ5IHdhcm5sZXZlbCwgdGltZSBpbiBtaW51dGVz
ClNjcmlwdF9QTUNTICAgICAgICAgICA9ICIvZXRjL3Bvd2VyL3BtY3MtcGJidXR0b25zZCAlcyAl
cyAlcyIKRW1lcmdlbmN5QWN0aW9uICAgICAgID0gc2xlZXAJOyBhY3Rpb24sIGlmIGJhdHRlcnkg
aXMgY3JpdGljYWxseSBsb3cKSGVhcnRiZWF0QmVlcCAgICAgICAgID0gbm8JOyBiZWVwLCBpZiBu
b3RoaW5nIGVsc2Ugc2hvd2VkIHRoYXQgdGhlIGNvbXB1dGVyIGxpdmVzCkNQVUxvYWRfc2xlZXBs
b2NrICAgICA9IHllcwpDUFVMb2FkX21pbiAgICAgICAgICAgPSAyMAk7IHZhbHVlIGluIHBlcmNl
bnQKQ1BVTG9hZF9wZXJpb2QgICAgICAgID0gMjAJOyB0aW1lIGluIHNlY29uZHMKTkVUTG9hZF9z
bGVlcGxvY2sgICAgID0geWVzCk5FVExvYWRfbWluICAgICAgICAgICA9IDQwOTYJOyB0cmFmZmlj
IGluIEJ5dGVzL3MKTkVUTG9hZF9wZXJpb2QgICAgICAgID0gMjAJOyB0aW1lIGluIHNlY29uZHMK
TkVUTG9hZF9kZXZpY2UgICAgICAgID0gImV0aDAiCgojIFtNT0RVTEUgRElTUExBWV0KTENEX0Jy
aWdodG5lc3MgICAgICAgID0gMTUJOyBpbml0aWFsIExDRCBicmlnaHRuZXNzIGxldmVsCkxDRF9G
YWRpbmdTcGVlZCAgICAgICA9IDUJOyAwID0gbm8gc21vb3RoIGZhZGluZwpMQ0RfQXV0b0FkanVz
dCAgICAgICAgPSB5ZXMJOyBvbmx5IG9uIEFsdW1pbnVtIFBvd2VyQm9va3MKTENEX0lsbHVtVXBL
ZXkgICAgICAgID0gMjI1CkxDRF9JbGx1bURvd25LZXkgICAgICA9IDIyNApMQ0RfVGhyZXNob2xk
ICAgICAgICAgPSA5NApMQ0RfQXV0b0Fkak1pbl9CYXQgICAgPSAyICAgICAgIDsgYXV0b2FkanVz
dCBwYXJhbWV0ZXIKTENEX0F1dG9BZGpNYXhfQmF0ICAgID0gNwpMQ0RfQXV0b0Fkak1pbl9BQyAg
ICAgPSAxCkxDRF9BdXRvQWRqTWF4X0FDICAgICA9IDE1CiNLQkRfQnJpZ2h0bmVzcyAgICAgICAg
PSAwCTsgaW5pdGlhbCBrZXlib2FyZCBpbGx1bWluYXRpb24gbGV2ZWwKS0JEX09uQnJpZ2h0bmVz
cyAgICAgID0gNSAgICAgICA7IGluaXRpYWwgbGV2ZWwgaWYgS0JEIG9uL29mZiBrZXkgaXMgcHJl
c3NlZApLQkRfRmFkaW5nU3BlZWQgICAgICAgPSA1CTsgMCA9IG5vIHNtb290aCBmYWRpbmcKS0JE
X0F1dG9BZGp1c3QgICAgICAgID0geWVzCTsgb25seSBvbiBBbHVtaW51bSBQb3dlckJvb2tzCktC
RF9JbGx1bVVwS2V5ICAgICAgICA9IDIzMApLQkRfSWxsdW1Eb3duS2V5ICAgICAgPSAyMjkKS0JE
X0lsbHVtT25LZXkgICAgICAgID0gMjI4CktCRF9UaHJlc2hvbGQgICAgICAgICA9IDI4CTsgb25s
eSBvbiBBbHVtaW51bSBQb3dlckJvb2tzCmRldl9GcmFtZUJ1ZmZlciAgICAgICA9ICIvZGV2L2Zi
MCIKVXNlRkJCbGFuayAgICAgICAgICAgID0geWVzCkRpbUZ1bGx5RGFyayAgICAgICAgICA9IG5v
CkNSVF9NaXJyb3JLZXkgICAgICAgICA9IDY1ICsgY3RybAoKIyBbTU9EVUxFIE1JWEVSXQpTb3Vu
ZFN5c3RlbSAgICAgICAgICAgPSBPU1MgIDsgT1NTIG9yIEFMU0EKI1NvdW5kU3lzdGVtICAgICAg
ICAgICA9IEFMU0EgIDsgT1NTIG9yIEFMU0EKI1ZvbHVtZSAgICAgICAgICAgICAgICA9IDUwCTsg
aW5pdGlhbCB2b2x1bWUgbGV2ZWwKU3BlYWtlcnNfbXV0ZWQgICAgICAgID0gbm8JOyBtdXRlIGFm
dGVyIHN0YXJ0dXA/ClZvbHVtZVVwS2V5ICAgICAgICAgICA9IDExNQpWb2x1bWVEb3duS2V5ICAg
ICAgICAgPSAxMTQKTXV0ZUtleSAgICAgICAgICAgICAgID0gMTEzCmRldl9NaXhlciAgICAgICAg
ICAgICA9ICIvZGV2L21peGVyIiA7IGZvciBPU1MKI01peGVyQ2FyZCAgICAgICAgICAgICA9ICJk
ZWZhdWx0IiAgICA7IGZvciBBTFNBCk1peGVySW5pdERlbGF5ICAgICAgICA9IG5vCk1peGVyQ2hh
bm5lbHMgICAgICAgICA9ICJ2b2x1bWUsIHNwZWFrZXIiICAgICAgICA7IHNldHRpbmdzIGZvciBP
U1MKI01peGVyQ2hhbm5lbHMgICAgICAgICA9ICJNYXN0ZXIsICdQQyBTcGVha2VyJyIgIDsgc2V0
dGluZ3MgZm9yIEFMU0EKCiMgW01PRFVMRSBDRFJPTV0KZGV2X0NEUk9NICAgICAgICAgICAgID0g
Ii9kZXYvY2Ryb20iCkVqZWN0Q0RLZXkgICAgICAgICAgICA9IDE2MQpFamVjdENES2V5RGVsYXkg
ICAgICAgPSAwCgojIFtNT0RVTEUgUE1BQ10KZGV2X1BNVSAgICAgICAgICAgICAgID0gIi9kZXYv
cG11IgpkZXZfQURCICAgICAgICAgICAgICAgPSAiL2Rldi9hZGIiClRQTW9kZVVwS2V5ICAgICAg
ICAgICA9IDIyNSArIGFsdApUUE1vZGVEb3duS2V5ICAgICAgICAgPSAyMjQgKyBhbHQKVFBNb2Rl
ICAgICAgICAgICAgICAgID0gZHJhZwpLQkRNb2RlICAgICAgICAgICAgICAgPSBma2V5c2ZpcnN0
CkJhdGxvZyAgICAgICAgICAgICAgICA9IG5vbmUK
</data>        

          </attachment>
    </bug>

</bugzilla>