79655 2005-01-26 17:15 0000 Patch for mail-client/mailx-8.1.2.20040524 to use CFLAGS 2005-01-28 13:14:36 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All Linux RESOLVED FIXED P2 enhancement --- 1 sbriesen@gentoo.org net-mail@gentoo.org sbriesen@gentoo.org 2005-01-26 17:15:35 0000 litte patch to enforce using CFLAGS from /etc/make.conf and not just -O2. Reproducible: Always Steps to Reproduce: sbriesen@gentoo.org 2005-01-26 17:16:31 0000 Created an attachment (id=49622) mailx-8.1.2.20040524.ebuild.diff ferdy@gentoo.org 2005-01-27 00:02:01 0000 Instead of using sed (thus adding it as a dependancy) I've patched the Makefile. To add EXTRAFLAGS that will override prior defined flags. Cheers, Ferdy sbriesen@gentoo.org 2005-01-27 12:35:56 0000 'sed' is part of the coreutils. So your computer won't run w/o it. ;-) using 'sed' is sexy for very small patches, because normally you don't have a version dependency. With your patch-file, you have to re-create a patch every time a new version arrives. But nonetheless, important is that CFLAGS is used now! sbriesen@gentoo.org 2005-01-27 12:40:42 0000 You should also remove the "-O2", because now you have gcc -D_BSD_SOURCE -DDEBIAN -g -Wall -IEXT <your CFLAGS> -O2 [..] So just put the $(EXTRAFLAGS) to the place where the -O2 is and you're doing the same as my 'sed'-patch. sbriesen@gentoo.org 2005-01-27 12:45:10 0000 Created an attachment (id=49685) mailx-2004-cflags.diff corrected CFLAGS-patch. Just replace the old one. ferdy@gentoo.org 2005-01-27 13:44:39 0000 Fixed in CVS, I haven't bumped the ebuild anyway. I don't think It worths it. BTW, sorry for changing to the patch and then reverting back to sed... Cheers, Ferdy sbriesen@gentoo.org 2005-01-28 12:57:13 0000 well, it's me again ;) you did this: sed -i -e "s: -O2: ${CFLAGS}:g" Makefile [..] make EXTRAFLAGS="${CFLAGS}" well, either you remove the "EXTRAFLAGS" stuff, or -BETTER- do this: sed -i -e "s: -O2: \$(EXTRAFLAGS):g" Makefile [..] make EXTRAFLAGS="${CFLAGS}" I don't reopen the bug again. But it would be nice, if you would (silently) fix this. No revision bump needed. ferdy@gentoo.org 2005-01-28 13:14:36 0000 You're damn right. Sorry again I don't know what I was thinking on... commited to CVS. Cheers, Ferdy 49622 2005-01-26 17:16 0000 mailx-8.1.2.20040524.ebuild.diff mailx-8.1.2.20040524.ebuild.diff text/plain LS0tIG1haWx4LTguMS4yLjIwMDQwNTI0LmVidWlsZC5vcmlnCTIwMDUtMDEtMjYgMTk6MzI6MjQu MDAwMDAwMDAwICswMTAwCisrKyBtYWlseC04LjEuMi4yMDA0MDUyNC5lYnVpbGQJMjAwNS0wMS0y NyAwMTozNDowMy4wMDAwMDAwMDAgKzAxMDAKQEAgLTMwLDYgKzMwLDcgQEAKIAl1bnBhY2sgJHtB fQogCWNkICR7U30KIAllcGF0Y2ggJHtESVNURElSfS8ke1BOfS0yMDA0MDUyNC1jdnMuZGlmZi5i ejIgfHwgZGllICJlcGF0Y2ggZmFpbGVkIgorCXNlZCAtaSAtZSAiczogLU8yOiAke0NGTEFHU306 ZyIgTWFrZWZpbGUKIH0KIAogc3JjX2NvbXBpbGUoKSB7Cg== 49685 2005-01-27 12:45 0000 mailx-2004-cflags.diff mailx-2004-cflags.diff text/plain LS0tIE1ha2VmaWxlLm9yaWcJMjAwNS0wMS0yNyAyMTo0MjozOC4xNTc2MDE0ODggKzAxMDAKKysr IE1ha2VmaWxlCTIwMDUtMDEtMjcgMjE6NDM6MDIuMjM3MzYyNDk5ICswMTAwCkBAIC04LDcgKzgs NyBAQAogaWZuZXEgKCwkKGZpbmRzdHJpbmcgbm9vcHQsJChERUJfQlVJTERfT1BUSU9OUykpKQog ICBDRkxBR1MgKz0gLU8wCiBlbHNlCi0gIENGTEFHUyArPSAtTzIKKyAgQ0ZMQUdTICs9ICQoRVhU UkFGTEFHUykKIGVuZGlmCiBpZmVxICgsJChmaW5kc3RyaW5nIG5vc3RyaXAsJChERUJfQlVJTERf T1BUSU9OUykpKQogICBMREZMQUdTICs9IC1zCg==