77184 2005-01-08 16:38 0000 net-dialup/slmodem should stay on old version 2005-01-21 13:12:03 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All All RESOLVED FIXED P2 normal --- 1 dsd@gentoo.org net-dialup@gentoo.org jos.delbar@ugent.be dsd@gentoo.org 2005-01-08 16:38:29 0000 The main developer for the slmodem linux drivers no longer works for smartlink. I do not know the reason for this. slmodem-2.9.10 introduced a license change which makes it quite a bit more restrictive. I think we should stick to the older version (with BSD-like license) so that we can continue to provide it on livecds. I'm guessing that it is likely we won't see another slmodem release for a while now that Sasha is gone. The linmodems developers have picked up maintenance of the last "free" version (2.9.9) and have also produced some newer releases (-alsa releases, not sure what is new here but it looks interesting). I suggest we drop 2.9.10 from the tree, and the attached patch to 2.9.9 to (properly) enable 2.6.10 compatibility, and investigate the -alsa packages which linmodems have produced. Here is the new source of slmodem packages: http://linmodems.technion.ac.il/packages/smartlink/ dsd@gentoo.org 2005-01-08 16:39:00 0000 Created an attachment (id=47982) 2.6.10 compatibility patch dsd@gentoo.org 2005-01-08 18:30:00 0000 Sasha also tells me that there are no differences between 2.9.9 and 2.9.10 other than the licensing. linmodems will be doing a 2.9.9a release shortly which will incorporate the patch attached here. dsd@gentoo.org 2005-01-12 12:51:12 0000 I have added the 2.9.9a ebuild into portage. It just needs to be marked stable before 2005.0 is made. dsd@gentoo.org 2005-01-16 16:43:25 0000 Bump..snapshot date is creeping up jos.delbar@ugent.be 2005-01-19 03:29:22 0000 There is at least one difference between version 2.9.9 and version 2.9.10, concerning ALSA modem device selection. See: http://bugs.gentoo.org/show_bug.cgi?id=60676 I'll take a look at the linmodems ALSA version and let you know if they have corrected the problem there as well. jos.delbar@ugent.be 2005-01-19 05:43:03 0000 Created an attachment (id=48937) patches slmodem-2.9.9a/modem/modem_cmdline.c linmodems did not fix the issue, so I'm attaching a new patch that applies to their slmodem-2.9.9a. dsd@gentoo.org 2005-01-19 06:02:45 0000 Where did you get this code from? we cannot take code from 2.9.10 as it has a very restrictive license jos.delbar@ugent.be 2005-01-19 06:15:45 0000 This is basically the patch I wrote for version 2.9.9, reapplied to the new linmodems version. I submitted this patch to SmartLink a few months ago. I didn't get any response from them, but the issue was fixed in 2.9.10. There shouldn't be any license issues with this patch. As you can see in BUG #60676, I created this patch independently before 2.9.10 was available. dsd@gentoo.org 2005-01-21 08:09:30 0000 2.9.9a-r1 is in portage with this fix. Could you please confirm that it works ASAP. I'd like to mark this stable before the 2005.0 snapshot which is a matter of hours away... jos.delbar@ugent.be 2005-01-21 08:48:12 0000 I'll have access to a phone line in a few hours. I'll try to get back to you ASAP. jos.delbar@ugent.be 2005-01-21 12:09:20 0000 I can confirm the patch does what it is supposed to do, slmodemd will no longer force to ALSA device hw:1. dsd@gentoo.org 2005-01-21 13:12:03 0000 Thanks for the quick test. This is now stable :) 47982 2005-01-08 16:39 0000 2.6.10 compatibility patch [patch] amrmo_init.c for 2.6.10.eml text/plain UmV0dXJuLXBhdGg6IDxzYXNoYWtAbG9jYWxob3N0LmJlemVxaW50Lm5ldD4KRW52ZWxvcGUtdG86 IGRzZEBnZW50b28ub3JnCkRlbGl2ZXJ5LWRhdGU6IFN1biwgMDkgSmFuIDIwMDUgMDA6MjU6NDgg KzAwMDAKUmVjZWl2ZWQ6IGZyb20gZGV2LmdlbnRvby5vcmcgWzE1Ni41Ni4xMTEuMTk3XQoJYnkg bG9jYWxob3N0IHdpdGggUE9QMyAoZmV0Y2htYWlsLTYuMi41KQoJZm9yIGRzZEBsb2NhbGhvc3Qg KHNpbmdsZS1kcm9wKTsgU3VuLCAwOSBKYW4gMjAwNSAwMDo0MDozNSArMDAwMCAoR01UKQpSZWNl aXZlZDogZnJvbSBzYTMuYmV6ZXFpbnQubmV0IChbMTkyLjExNS4xMDQuMTddKQoJYnkgc210cC5n ZW50b28ub3JnIHdpdGggZXNtdHAgKEV4aW0gNC40MikKCWlkIDFDblF0dy0wMDAxZ3QtR2gKCWZv ciBkc2RAZ2VudG9vLm9yZzsgU3VuLCAwOSBKYW4gMjAwNSAwMDoyNTo0OCArMDAwMApSZWNlaXZl ZDogZnJvbSBsb2NhbGhvc3QgKHVua25vd24gWzEyNy4wLjAuMV0pCglieSBzYTMuYmV6ZXFpbnQu bmV0IChCZXplcSBJbnRlcm5hdGlvbmFsIFNNVFAgb3V0IE1haWwgU2VydmVyKSB3aXRoIEVTTVRQ IGlkIDc1NUU0MzM5ODY7CglTdW4sICA5IEphbiAyMDA1IDAyOjEzOjU1ICswMjAwIChJU1QpClJl Y2VpdmVkOiBmcm9tIHNhMy5iZXplcWludC5uZXQgKFsxMjcuMC4wLjFdKQogYnkgbG9jYWxob3N0 IChzYTMgWzEyNy4wLjAuMV0pIChhbWF2aXNkLW5ldywgcG9ydCAxMDAyNCkgd2l0aCBFU01UUAog aWQgMTI0NjEtMDQ7IFN1biwgIDkgSmFuIDIwMDUgMDI6MTM6NTQgKzAyMDAgKElTVCkKUmVjZWl2 ZWQ6IGZyb20gbG9jYWxob3N0ICh1bmtub3duIFs4MS4yMTguMTE5LjIyXSkKCWJ5IHNhMy5iZXpl cWludC5uZXQgKEJlemVxIEludGVybmF0aW9uYWwgU01UUCBvdXQgTWFpbCBTZXJ2ZXIpIHdpdGgg RVNNVFA7CglTdW4sICA5IEphbiAyMDA1IDAyOjEzOjU0ICswMjAwIChJU1QpClJlY2VpdmVkOiBi eSBsb2NhbGhvc3QgKFBvc3RmaXgsIGZyb20gdXNlcmlkIDEwMDApCglpZCA4MjZDNTQyQTE7IFN1 biwgIDkgSmFuIDIwMDUgMDI6NDQ6MDEgKzAyMDAgKElTVCkKRGF0ZTogU3VuLCA5IEphbiAyMDA1 IDAyOjQ0OjAxICswMjAwCkZyb206IFNhc2hhIEtoYXB5b3Jza3kgPHNhc2hha0BzbWxpbmsuY29t PgpUbzogZ29sZGJlcmdAcHJlcDIudGVjaG5pb24uYWMuaWwsIG1hcnZzdG9kQGNvbWNhc3QuY29t CkNjOiBkc2RAZ2VudG9vLm9yZywgZGlzY3Vzc0BsaW5tb2RlbXMub3JnClN1YmplY3Q6IFtwYXRj aF0gYW1ybW9faW5pdC5jIGZvciAyLjYuMTAKTWVzc2FnZS1JRDogPDIwMDUwMTA5MDA0NDAxLkdB MTIyNDZAdGVjcj4KTWFpbC1Gb2xsb3d1cC1UbzogZ29sZGJlcmdAcHJlcDIudGVjaG5pb24uYWMu aWwsCgltYXJ2c3RvZEBjb21jYXN0LmNvbSwgZHNkQGdlbnRvby5vcmcsIGRpc2N1c3NAbGlubW9k ZW1zLm9yZwpNaW1lLVZlcnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJz ZXQ9dXMtYXNjaWkKQ29udGVudC1EaXNwb3NpdGlvbjogaW5saW5lClVzZXItQWdlbnQ6IE11dHQv MS41LjZpClgtVmlydXMtU2Nhbm5lZDogYW1hdmlzZC1uZXcgYXQgYmV6ZXFpbnQubmV0ClgtVmly dXMtU2Nhbjogc2Nhbm5lZApYLVNwYW0tQ2hlY2tlci1WZXJzaW9uOiBTcGFtQXNzYXNzaW4gMy4w LjItZ3IwICgyMDA0LTExLTE2KSBvbiAKCXpvZy5yZWFjdGl2YXRlZC5uZXQKWC1TcGFtLUxldmVs OiAKWC1TcGFtLVN0YXR1czogTm8sIHNjb3JlPS0xLjAgcmVxdWlyZWQ9NS4wIHRlc3RzPUFXTCxC QVlFU18wMCxOT19ETlNfRk9SX0ZST00gCglhdXRvbGVhcm49bm8gdmVyc2lvbj0zLjAuMi1ncjAK CkhlbGxvIEphY3F1ZXMsIE1hcnZTLAoKQmVsb3cgaXMgcGF0Y2ggZm9yIHNsbW9kZW0tMi45Ljlb LWFsc2FdL2RyaXZlcnMvYW1ybW9faW5pdC5jIC4KClRoaXMgc2hvdWxkIGZpeCAyLjYuMTAgaW5j b21wYXRpYmlsaXRpZXMgYW5kIHN0aWxsIHdvcmsgd2l0aCBlYXJsaWVyIGtlcm5lbHMuCgpUaGFu a3MgYW5kIEJlc3QgUmVnYXJkcywKU2FzaGEuCgoKLS0tIG9yaWcvZHJpdmVycy9hbXJtb19pbml0 LmMKKysrIG1vZC9kcml2ZXJzL2Ftcm1vX2luaXQuYwpAQCAtNTgsNiArNTgsOSBAQAogI2lmIExJ TlVYX1ZFUlNJT05fQ09ERSA8IEtFUk5FTF9WRVJTSU9OKDIsNSwwKQogI2RlZmluZSBPTERfS0VS TkVMIDEKICNlbmRpZgorI2lmIExJTlVYX1ZFUlNJT05fQ09ERSA8IEtFUk5FTF9WRVJTSU9OKDIs NiwxMCkKKyNkZWZpbmUgcGNpX3JlZ2lzdGVyX2RyaXZlcihkcnYpICggcGNpX3JlZ2lzdGVyX2Ry aXZlcihkcnYpID8gMCA6IC1FTk9ERVYgKQorI2VuZGlmCiAKICNpZmRlZiBPTERfS0VSTkVMCiAj ZGVmaW5lIGltaW5vcihpKSBNSU5PUigoaSktPmlfcmRldikKQEAgLTM1MCw3ICszNTMsOCBAQAog CWlmIChjb3VudCA+IHNpemVvZihhbXJtby0+aWJ1ZikpCiAJCWNvdW50ID0gc2l6ZW9mKGFtcm1v LT5pYnVmKTsKIAlyZXQgPSBhbXJtb19jYXJkX3JlYWQoYW1ybW8tPmNhcmQsYW1ybW8tPmlidWYs Y291bnQpOwotCWNvcHlfdG9fdXNlcihidWZmZXIsYW1ybW8tPmlidWYscmV0KTsKKwlpZihjb3B5 X3RvX3VzZXIoYnVmZmVyLGFtcm1vLT5pYnVmLHJldCkpCisJCXJldHVybiAtRUZBVUxUOwogCXJl dHVybiByZXQ7CiB9CiAKQEAgLTM2Myw3ICszNjcsOCBAQAogCQlyZXR1cm4gLUVGQVVMVDsKIAlp ZiAoY291bnQgPiBzaXplb2YoYW1ybW8tPm9idWYpKQogCQljb3VudCA9IHNpemVvZihhbXJtby0+ b2J1Zik7Ci0JY29weV9mcm9tX3VzZXIoYW1ybW8tPm9idWYsYnVmZmVyLGNvdW50KTsKKwlpZihj b3B5X2Zyb21fdXNlcihhbXJtby0+b2J1ZixidWZmZXIsY291bnQpKQorCQlyZXR1cm4gLUVGQVVM VDsKIAlyZXQgPSBhbXJtb19jYXJkX3dyaXRlKGFtcm1vLT5jYXJkLGFtcm1vLT5vYnVmLGNvdW50 KTsKIAlyZXR1cm4gcmV0OwogfQpAQCAtNjkyLDYgKzY5Nyw3IEBACiBzdGF0aWMgaW50IF9faW5p dCBhbXJtb19pbml0KHZvaWQpCiB7CiAJc3RydWN0IHBjaV9kZXYgKmRldiA9IE5VTEw7CisJaW50 IGVycjsKICNpZmRlZiBPTERfS0VSTkVMCiAJaWYgKCFwY2lfcHJlc2VudCgpKQogCQlyZXR1cm4g LUVOT0RFVjsKQEAgLTcxNyw3ICs3MjMsNyBAQAogCQkJaWYgKGRldi0+ZHJpdmVyICYmIGRldi0+ ZHJpdmVyLT5yZW1vdmUpCiAJCQkJZGV2LT5kcml2ZXItPnJlbW92ZShkZXYpOwogCQkJZGV2LT5k cml2ZXIgPSBOVUxMOwotI2Vsc2UKKyNlbGlmIExJTlVYX1ZFUlNJT05fQ09ERSA8IEtFUk5FTF9W RVJTSU9OKDIsNiwxMCkKIAkJCXN0cnVjdCBkZXZpY2UgKnJlbGRldiA9IGdldF9kZXZpY2UoJmRl di0+ZGV2KTsKIAkJCUFNUk1PX0RCRygiZGV2aWNlICUwNHg6JTA0eCBpcyBncmFiYmVkIGJ5IGRy aXZlciAlczogdHJ5IHRvIHJlbGVhc2VcbiIsCiAJCQkJICBkZXYtPnZlbmRvcixkZXYtPmRldmlj ZSwKQEAgLTcyNyw2ICs3MzMsOSBAQAogCQkJCWRldmljZV9yZWxlYXNlX2RyaXZlcihyZWxkZXYp OwogCQkJCXB1dF9kZXZpY2UocmVsZGV2KTsKIAkJCX0KKyNlbHNlCisJCQlBTVJNT19EQkcoImRl dmljZSAlMDR4OiUwNHggaXMgZ3JhYmJlZCBieSBhbm90aGVyIGRyaXZlclxuIiwKKwkJCQkgIGRl di0+dmVuZG9yLGRldi0+ZGV2aWNlKTsKICNlbmRpZgogCQl9CiAJfQpAQCAtNzM5LDEzICs3NDgs MTIgQEAKIAkJcmV0dXJuIGVycjsKIAl9CiAjZW5kaWYKLQotCWlmICghcGNpX3JlZ2lzdGVyX2Ry aXZlcigmYW1ybW9fcGNpX2RyaXZlcikpIHsKKwlpZiAoKGVyciA9IHBjaV9yZWdpc3Rlcl9kcml2 ZXIoJmFtcm1vX3BjaV9kcml2ZXIpKSA8IDApIHsKIAkJcGNpX3VucmVnaXN0ZXJfZHJpdmVyKCZh bXJtb19wY2lfZHJpdmVyKTsKICNpZm5kZWYgT0xEX0tFUk5FTAogCQljbGFzc19zaW1wbGVfZGVz dHJveShhbXJtb19jbGFzcyk7CiAjZW5kaWYKLSAgICAgICAgICAgICAgICByZXR1cm4gLUVOT0RF VjsKKyAgICAgICAgICAgICAgICByZXR1cm4gZXJyOwogCX0KIAogCWlmKHJlZ2lzdGVyX2NocmRl dihBTVJNT19NQUpPUiwgInNsYW1yIiwgJmFtcm1vX2ZvcHMpIDwgMCkgewoK 48937 2005-01-19 05:43 0000 patches slmodem-2.9.9a/modem/modem_cmdline.c slmodem-2.9.9a-alsa-device-patch.diff text/plain LS0tIHNsbW9kZW0tMi45LjlhL21vZGVtL21vZGVtX2NtZGxpbmUuYwkyMDA1LTAxLTE5IDE0OjM0 OjE2LjAwOTU3ODE5MyArMDEwMAorKysgc2xtb2RlbS0yLjkuOWEtZml4ZWQvbW9kZW0vbW9kZW1f Y21kbGluZS5jCTIwMDUtMDEtMTkgMTQ6MzY6NTcuOTg3NTg5NTE3ICswMTAwCkBAIC0xMDMsNyAr MTAzLDcgQEAKIAl7J3YnLCJ2ZXJzaW9uIiwic2hvdyB2ZXJzaW9uIGFuZCBleGl0In0sCiAJeydj JywiY291bnRyeSIsImRlZmF1bHQgbW9kZW0gY291bnRyeSBuYW1lIixNQU5EQVRPUlksU1RSSU5H LCJVU0EifSwKIAl7IDAgLCJjb3VudHJ5bGlzdCIsInNob3cgbGlzdCBvZiBzdXBwb3J0ZWQgY291 bnRyaWVzIn0sCi0JeydhJywiYWxzYSIsIkFMU0EgbW9kZSAoc2VlIFJFQURNRSBmb3IgaG93dG8p In0sCisJeydhJywiYWxzYSIsIkFMU0EgbW9kZSAoc2VlIFJFQURNRSBmb3IgaG93dG8pIixPUFRJ T05BTCxTVFJJTkcsImh3OjEifSwKIAl7J2cnLCJncm91cCIsIk1vZGVtIFRUWSBncm91cCIsTUFO REFUT1JZLFNUUklORywidXVjcCJ9LAogCXsncCcsInBlcm0iLCJNb2RlbSBUVFkgcGVybWlzc2lv biIsTUFOREFUT1JZLElOVEVHRVIsIjA2NjAifSwKIAl7J24nLCJub3J0cHJpb3JpdHkiLCJydW4g d2l0aCByZWd1bGFyIHByaW9yaXR5In0sCkBAIC0yMzcsNyArMjM3LDcgQEAKIAkJUFJfSU5GTygi QUxTQSBzdXBwb3J0IGlzIG5vdCBjb21waWxlZCBpbiAoc2VlIFJFQURNRSBmb3IgaG93dG8pLlxu Iik7CiAJCWV4aXQoMSk7CiAjZW5kaWYKLQkJbW9kZW1fZGV2X25hbWUgPSBtb2RlbV9hbHNhX2Rl dl9uYW1lOworCQltb2RlbV9kZXZfbmFtZSA9IG9wdF9saXN0W09QVF9BTFNBXS5hcmdfdmFsOwog CQl1c2VfYWxzYSA9IDE7CiAJfQogCWlmKG9wdF9saXN0W09QVF9HUk9VUF0uZm91bmQpCg==