75656 2004-12-25 15:56 0000 net-dialup/slmodem fix for 2.6.10 2005-01-18 06:00:22 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All All RESOLVED FIXED Inclusion P2 normal --- 1 dsd@gentoo.org net-dialup@gentoo.org gregkh@gentoo.org kronenpj@kronenpj.dyndns.org dsd@gentoo.org 2004-12-25 15:56:10 0000 Please apply this patch for users who are running 2.6.10 or newer. Some in-kernel API has changed. dsd@gentoo.org 2004-12-25 15:56:24 0000 Created an attachment (id=46885) slmodem-2.9.10-fix-for-2.6.10.patch genstef@gentoo.org 2004-12-25 23:21:05 0000 The driver does not work for me: slamr: module license 'Smart Link Ltd.' taints kernel. slamr: Unknown symbol get_device slamr: Unknown symbol put_device slamr: Unknown symbol device_release_driver so your fix is not really sufficient, any clue on this problem? other thing is: should we not put your code change in ifdefs and apply it only when we detect a 2.6.10 kernel? dsd@gentoo.org 2004-12-26 02:16:45 0000 Those functions are now only available to GPL modules :( Greg, whats the way to approach this? mrness@gentoo.org 2004-12-29 14:08:45 0000 For the time being, I've blocked the installation for kernels >= 2.6.10. Usage of kernel exported symbols have been restricted to GPL modules: http://www.uwsg.iu.edu/hypermail/linux/kernel/0110.2/0369.html I think this bug should be closed with UPSTREAM resolution. Opinions? genstef@gentoo.org 2004-12-29 14:20:45 0000 Only slamr is affected, so we could simply remove that module for kernels >= 2.6.10 Slamr is fully replaced by snd-intel8x0m I think. However slusb in the ebuild has no replacement, so please compile it for all kernels and do not bail out on >=2.6.10 Also the slmodemd is always needed .. so we really need that ebuild .. mrness@gentoo.org 2004-12-29 14:43:52 0000 Ok, I've rolled back r[12] revisions and changed r3 as follows: - allow installation for kernels >= 2.6.10 but don't install slamr module - apply Daniel's patch if and only if kernel ver >= 2.6.10 Are these changes ok? dsd@gentoo.org 2004-12-29 16:41:48 0000 You can make one simplification in src_unpack - # http://marc.theaimsgroup.com/?l=gentoo-dev&m=109672618708314&w=2 - if kernel_is ge 2 6 6; then - sed -i 's:SUBDIRS=:M=:g' drivers/Makefile - fi + convert_to_m drivers/Makefile mrness@gentoo.org 2004-12-30 00:42:12 0000 patch applied. jsanjuan@pingvin-it.no 2005-01-02 06:05:28 0000 It is not a bug, but what Alin Nastac pointed out. There are 2 controversial workarounds that will probably have to be applied by the user manually; 1) Change all entries to MODULE_LICENSE("GPL") in slmodem's source code, 2) Patch the kernel to export the required symbols to non-GPL drivers. dsd@gentoo.org 2005-01-02 06:16:14 0000 Neither of those are suitable here. I also dont think slmodem using device_release_driver is correct (have not looked at the other 2). I think the slmodem source code can be worked in a better way. jsanjuan@pingvin-it.no 2005-01-02 08:22:36 0000 The main problem lies on "Unknown symbol" due to the required symbols are not exported (EXPORT_SYMBOL_GPL is used and not EXPORT_SYMBOL) because the slmodem driver is not licensed with GPL. A suitable fix, in terms of licensing and kernel developers' ideology, is to make a GPL licensed wrapper driver for the slmodem binary driver. dsd@gentoo.org 2005-01-02 08:34:30 0000 That is not up to us to decide. Plus my last point still stands. I read something like device_release_driver should only be used if it was previously registered with device_register_driver, which it is not. jsanjuan@pingvin-it.no 2005-01-02 09:14:10 0000 I just read Smart Link's license (http://www.smlink.com/main/item.php?ln=en&item_id=24&main_id=20) and they prohibit any kind of modifications of their driver. So there is actually no point of fixing this driver if they will call you a criminal bt doing so. I've also checked Nvidia's driver and they reimplemented the GPL only symbols. dsd@gentoo.org 2005-01-02 09:58:11 0000 That does not apply to smartlinks glue code, which is released under a different (BSD-like) license. I have sent code fixes to smartlink in the past which are incorporated in these releases. gregkh@gentoo.org 2005-01-02 19:23:57 0000 nvidia does not have wrappers around the gpl licensed functions, they merely call different functions. If such wrappers were created for this driver, it would be time to call my employer's lawyers, as that is my code they are violating by doing so. So please, either get upstream to use the proper kernel interfaces (that are not marked GPL only), or get them to change their license of the code, not much we can do here about this (nor do I want to have gentoo make such changes, as it is not legal for us to do so, as has been pointed out.) dsd@gentoo.org 2005-01-03 06:22:59 0000 Created an attachment (id=47478) slmodem license This is the slmodem license as included in the source code. It's not GPL compatible but is fairly "open" at the same time. And they didn't seem to have a problem with me hacking the source the last time around. dsd@gentoo.org 2005-01-03 07:28:22 0000 Created an attachment (id=47481) slmodem-2.9.10-pci-workaround.patch The init function currently scans the hardware, and if any supported hardware has been claimed by another driver, it tries to unregister it frmo that driver before claiming it itself. This seems rather messy, dropping that code altogether is a good workaround for this problem. mrness@gentoo.org 2005-01-06 15:13:07 0000 patch applied in r4 kronenpj@kronenpj.dyndns.org 2005-01-11 15:33:56 0000 In response to comment #5, slamr is not fully replaced by snd-intel8x0. I have a modem that works 99% with slamr but is completely unrecognized by snd-intel8x0. Any suggestions? kronenpj@kronenpj.dyndns.org 2005-01-11 16:12:13 0000 Stupid user error... 1. Insert snd-intel8x0m 2. Use slmodem and hw:1, not modem:0 or modem:1. Continue life in a happy and joyous way... Many apologies. MasterOne@MHR.at 2005-01-17 10:24:46 0000 Can someone point out, which way to go now? Is it fully working by using just snd-intel8x0m, without the use of the slamr module? If the problem with the slmodem-archive, so building the slamr module on a 2.6.10 kernel got fixed, what is it about "-r4" since slmodem-2.9.10-r1.ebuild is still the last one showing up in portage? dsd@gentoo.org 2005-01-17 12:47:09 0000 You need snd-intel8x0m, not slamr. But I think you also need the slmodemd program from this package (maybe you could confirm or deny this? I don't think any of us own this hardware...) The newest version is 2.9.9a (yes, even newer than 2.9.10) gekylafas@gmail.com 2005-01-18 00:12:07 0000 Version 2.9.9a may be newer than 2.9.10, but this is not how portage sees it: # emerge -pv slmodem These are the packages that I would merge, in order: Calculating dependencies ...done! [ebuild U ] net-dialup/slmodem-2.9.10-r1 [2.9.9a] -alsa -usb 0 kB This is solved only if I add: ">=net-dialup/slmodem-2.9.10" to /etc/portage/package.mask, and "net-dialup/slmodem ~x86" to /etc/portage/package.keywords. dsd@gentoo.org 2005-01-18 06:00:22 0000 2.9.10 will be removed soon due to licensing issues 46885 2004-12-25 15:56 0000 slmodem-2.9.10-fix-for-2.6.10.patch slmodem-2.9.10-fix-for-2.6.10.patch text/plain RnJvbSBMaW51eCAyLjYuMTAgb253YXJkcywgcGNpX3JlZ2lzdGVyX2RyaXZlciByZXR1cm5zIDAg b24gc3VjY2VzcyBhbmQgbmVnYXRpdmUgb24gZmFpbHVyZQoKLSBEYW5pZWwgRHJha2UgPGRzZEBn ZW50b28ub3JnPgoKLS0tIHNsbW9kZW0tMi45LjEwL2RyaXZlcnMvYW1ybW9faW5pdC5jLm9yaWcJ MjAwNC0xMi0yNSAyMzo1Mzo1MS4zNDUyNTg4NDggKzAwMDAKKysrIHNsbW9kZW0tMi45LjEwL2Ry aXZlcnMvYW1ybW9faW5pdC5jCTIwMDQtMTItMjUgMjM6NTQ6MzMuNTI4ODQ1OTY4ICswMDAwCkBA IC03NDAsNyArNzQwLDcgQEAKIAl9CiAjZW5kaWYKIAotCWlmICghcGNpX3JlZ2lzdGVyX2RyaXZl cigmYW1ybW9fcGNpX2RyaXZlcikpIHsKKwlpZiAocGNpX3JlZ2lzdGVyX2RyaXZlcigmYW1ybW9f cGNpX2RyaXZlcikgPCAwKSB7CiAJCXBjaV91bnJlZ2lzdGVyX2RyaXZlcigmYW1ybW9fcGNpX2Ry aXZlcik7CiAjaWZuZGVmIE9MRF9LRVJORUwKIAkJY2xhc3Nfc2ltcGxlX2Rlc3Ryb3koYW1ybW9f Y2xhc3MpOwo= 47478 2005-01-03 06:22 0000 slmodem license license text/plain ICogICBDb3B5cmlnaHQgKGMpIDIwMDIsIFNtYXJ0IExpbmsgTHRkLgogKiAgIEFsbCByaWdodHMg cmVzZXJ2ZWQuCiAqCiAqICAgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJp bmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAqICAgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0 dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCiAqICAgYXJlIG1ldDoK ICoKICogICAgICAgMS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWlu IHRoZSBhYm92ZSBjb3B5cmlnaHQKICogICAgICAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29u ZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgogKiAgICAgICAyLiBSZWRpc3Ry aWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlCiAqICAgICAg ICAgIGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9s bG93aW5nCiAqICAgICAgICAgIGRpc2NsYWltZXIgaW4gdGhlIGRvY3VtZW50YXRpb24gYW5kL29y IG90aGVyIG1hdGVyaWFscyBwcm92aWRlZAogKiAgICAgICAgICB3aXRoIHRoZSBkaXN0cmlidXRp b24uCiAqICAgICAgIDMuIE5laXRoZXIgdGhlIG5hbWUgb2YgdGhlIFNtYXJ0IExpbmsgTHRkLiBu b3IgdGhlIG5hbWVzIG9mIGl0cwogKiAgICAgICAgICBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQg dG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQKICogICAgICAgICAgZnJvbSB0 aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLgog KgogKiAgIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJT IEFORCBDT05UUklCVVRPUlMKICogICAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVE IFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVAogKiAgIExJTUlURUQgVE8sIFRIRSBJTVBM SUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUgogKiAgIEEg UEFSVElDVUxBUiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUg Q09QWVJJR0hUCiAqICAgT1dORVIgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJ UkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsCiAqICAgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBD T05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAogKiAgIExJTUlURUQgVE8s IFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNF LAogKiAgIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZF UiBDQVVTRUQgQU5EIE9OIEFOWQogKiAgIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4g Q09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKICogICAoSU5DTFVESU5HIE5FR0xJ R0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKICog ICBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9G IFNVQ0ggREFNQUdFLgoK 47481 2005-01-03 07:28 0000 slmodem-2.9.10-pci-workaround.patch slmodem-2.9.10-pci-workaround.patch text/plain Z2V0X2RldmljZSwgcHV0X2RldmljZSBhbmQgZGV2aWNlX3JlbGVhc2VfZHJpdmVyIGFyZSBubyBs b25nZXIgYXZhaWxhYmxlIHRvIG5vbi1HUEwgbW9kdWxlcy4KVGhlIHdob2xlIHByb2Nlc3Mgb2Yg dW5yZWdpc3RlcmluZyB0aGUgZGV2aWNlIGZyb20gYW5vdGhlciBkcml2ZXIgc2VlbXMgZG9kZ3ks IGxldHMganVzdCBza2lwIGl0CgotLS0gc2xtb2RlbS0yLjkuMTAvZHJpdmVycy9hbXJtb19pbml0 LmMub3JpZwkyMDA1LTAxLTAzIDE0OjUyOjIzLjE3ODI4NzkxMiArMDAwMAorKysgc2xtb2RlbS0y LjkuMTAvZHJpdmVycy9hbXJtb19pbml0LmMJMjAwNS0wMS0wMyAxNTowNjo0Ni42MDMwMjc0MDAg KzAwMDAKQEAgLTcxOCwxNSArNzE4LDggQEAKIAkJCQlkZXYtPmRyaXZlci0+cmVtb3ZlKGRldik7 CiAJCQlkZXYtPmRyaXZlciA9IE5VTEw7CiAjZWxzZQotCQkJc3RydWN0IGRldmljZSAqcmVsZGV2 ID0gZ2V0X2RldmljZSgmZGV2LT5kZXYpOwotCQkJQU1STU9fREJHKCJkZXZpY2UgJTA0eDolMDR4 IGlzIGdyYWJiZWQgYnkgZHJpdmVyICVzOiB0cnkgdG8gcmVsZWFzZVxuIiwKLQkJCQkgIGRldi0+ dmVuZG9yLGRldi0+ZGV2aWNlLAotCQkJCSAgKHJlbGRldiYmcmVsZGV2LT5kcml2ZXIpPwotCQkJ CSAgIHJlbGRldi0+ZHJpdmVyLT5uYW1lOiJ1bmtub3duIik7Ci0JCQlpZiAocmVsZGV2KSB7Ci0J CQkJZGV2aWNlX3JlbGVhc2VfZHJpdmVyKHJlbGRldik7Ci0JCQkJcHV0X2RldmljZShyZWxkZXYp OwotCQkJfQorCQkJQU1STU9fREJHKCJkZXZpY2UgJTA0eDolMDR4IGlzIGdyYWJiZWQgYnkgYW5v dGhlciBkcml2ZXIsIGlnbm9yaW5nIiwKKwkJCQkgIGRldi0+dmVuZG9yLGRldi0+ZGV2aWNlKTsK ICNlbmRpZgogCQl9CiAJfQo=