73527 2004-12-06 00:01 0000 Scorched3d ebuild with the new wxwidgets.eclass to solve wxGTK problems 2004-12-09 01:32:16 0000 1 1 1 Unclassified Gentoo Linux Games unspecified All Linux RESOLVED FIXED http://bugs.gentoo.org/show_bug.cgi?id=39931 P2 enhancement --- 1 kristiaan.lenaerts@gmail.com games@gentoo.org basic@mozdev.org kristiaan.lenaerts@gmail.com 2004-12-06 00:01:41 0000 The ebuild for scorched3d uses a crude way to check if the right version of wxGTK is available, and if the right version is installed. If the unicode version is installed, the installation will not complete. However, the new wxwidgets eclass makes it possible to use all three versions side by side. The bug report in the link describes the solution, and how to adapt ebuilds to using it. I adapted the 38 ebuild to use this. Reproducible: Always Steps to Reproduce: kristiaan.lenaerts@gmail.com 2004-12-06 00:02:26 0000 Created an attachment (id=45365) modified ebuild mr_bones_@gentoo.org 2004-12-06 00:42:23 0000 modified the ebuild in CVS. Thanks for pointing that out. The checking still needs to be in pkg_setup though. Check the current ebuild in CVS and make sure I didn't mess something up. Thanks. kristiaan.lenaerts@gmail.com 2004-12-06 02:03:06 0000 When testing the new ebuild, I noticed that the test does nothing. I have all 3 versions of wxGTK installed (gtk, gkt2 and gtk2u). Although I get the comment "* Using /usr/bin/wxgtk2-2.4-config", it is the gtk2u version that is included while compiling (the default version?). Apparantly the options that "need-wxwidgets gtk2" sets are not used when set in pkg_setup. Maybe it is a bug in in wxwidgets.eclass, but it only works when that section is right before the configure. It looks like the eclass only sets an environment variable (WX_CONFIG), and it stays local to pkg_setup, but egamesconf is done in src_compile... I'm not sure what the right way is for solving this. basic@mozdev.org 2004-12-08 00:29:00 0000 Created an attachment (id=45497) patch here's a patch, just call pkg_setup or ... (another patch coming up) basic@mozdev.org 2004-12-08 00:32:36 0000 Created an attachment (id=45498) patch alt move the check to global ... or if you don't like this or the earlier patch, make a copy of the check in src_compile mr_bones_@gentoo.org 2004-12-08 00:38:09 0000 both of those look nasty to me. mr_bones_@gentoo.org 2004-12-08 00:49:12 0000 Just so we're clear. The claim is, if I put the check in the src_compile function, it works. If it's in the pkg_setup, then things don't work. Is that correct? I think I see the problem but I want to make sure I'm understanding the failure condition. basic@mozdev.org 2004-12-08 01:19:18 0000 > both of those look nasty to me. another alternative is to have the code checking for wxWidget in a seperate function and have both pkg_setup and src_compile call it > Just so we're clear. The claim is, if I put the check in the src_compile function, it works. If it's in the pkg_setup, then things don't work. Is that correct? > I think I see the problem but I want to make sure I'm understanding the failure condition. yes, the problem seems to be that enviroment variables declared in pkg_setup is not preserved. mr_bones_@gentoo.org 2004-12-08 22:16:50 0000 ok, it's ugly but it's in there. Give the latest ebuild a shot and reopen if it's still a problem. This is a bug with portage where portage doesn't export the variables that need to be exported when carrying variables over from one function to another. kristiaan.lenaerts@gmail.com 2004-12-09 01:32:16 0000 Just emerged it, it works fine for me, thanks :-) 45365 2004-12-06 00:02 0000 modified ebuild scorched3d-38.ebuild text/plain IyBDb3B5cmlnaHQgMTk5OS0yMDA0IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6IC92YXIvY3Zzcm9vdC9nZW50b28teDg2L2dhbWVzLXN0cmF0ZWd5L3Njb3JjaGVkM2Qvc2Nv cmNoZWQzZC0zOC5lYnVpbGQsdiAxLjEgMjAwNC8xMi8wNSAxMToxNDo1MiBtcl9ib25lc18gRXhw ICQKCmluaGVyaXQgZ2FtZXMgd3h3aWRnZXRzCgpERVNDUklQVElPTj0iTXVsdGktcGxheWVyIHRh bmsgYmF0dGxlIGluIDNEIChPcGVuR0wpIgpIT01FUEFHRT0iaHR0cDovL3d3dy5zY29yY2hlZDNk LmNvLnVrLyIKU1JDX1VSST0ibWlycm9yOi8vc291cmNlZm9yZ2Uvc2NvcmNoZWQzZC9TY29yY2hl ZDNELSR7UFZ9LXNyYy50YXIuZ3oiCgpMSUNFTlNFPSJHUEwtMiIKU0xPVD0iMCIKS0VZV09SRFM9 Ing4NiBwcGMiCklVU0U9Im15c3FsIGd0azIiCgpERVBFTkQ9Ij49bWVkaWEtbGlicy9saWJzZGwt MS4wLjEKCW1lZGlhLWxpYnMvc2RsLW5ldAoJbWVkaWEtbGlicy9zZGwtbWl4ZXIKCT49eDExLWxp YnMvd3hHVEstMi4zLjQKCW1lZGlhLWxpYnMvZnJlZXR5cGUKCT49c3lzLWxpYnMvemxpYi0xLjEu NAoJbXlzcWw/ICggZGV2LWRiL215c3FsICkiCgpTPSIke1dPUktESVJ9L3Njb3JjaGVkIgoKc3Jj X2NvbXBpbGUoKSB7CglpZiAhIHVzZSBndGsyOyB0aGVuCgkJbmVlZC13eHdpZGdldHMgZ3RrIHx8 IGRpZSAiTm8gZ3RrMSB2ZXJzaW9uIG9mIHgxMS1saWJzL3d4R1RLIGZvdW5kIgoJZWxzZQoJCW5l ZWQtd3h3aWRnZXRzIGd0azIgfHwgZGllICJZb3UgbmVlZCB0byBlbWVyZ2Ugd3hHVEsgd2l0aCBV U0U9J2d0azInIgoJZmkKCWVnYW1lc2NvbmYgXAoJCS0tZGlzYWJsZS1kZXBlbmRlbmN5LXRyYWNr aW5nIFwKCQktLWV4ZWNfcHJlZml4PSIke0dBTUVTX1BSRUZJWH0iIFwKCQktLWRhdGFkaXI9IiR7 R0FNRVNfREFUQURJUn0vJHtQTn0iIFwKCQktLXdpdGgtZG9jZGlyPSIvdXNyL3NoYXJlL2RvYy8k e1BGfSIgXAoJCSQodXNlX3dpdGggbXlzcWwpIFwKCQl8fCBkaWUKCWVtYWtlIHx8IGRpZSAiZW1h a2UgZmFpbGVkIgp9CgpzcmNfaW5zdGFsbCgpIHsKCW1ha2UgREVTVERJUj0iJHtEfSIgaW5zdGFs bCB8fCBkaWUgIm1ha2UgaW5zdGFsbCBmYWlsZWQiCglwcmVwZ2FtZXNkaXJzCn0K 45497 2004-12-08 00:29 0000 patch scorched3d-38.patch text/plain LS0tIHNjb3JjaGVkM2QtMzguZWJ1aWxkCTIwMDQtMTItMDggMTY6MTY6MTAuMDAwMDAwMDAwICsw ODAwCisrKyBzY29yY2hlZDNkLTM4LXIxLmVidWlsZAkyMDA0LTEyLTA4IDE2OjI1OjU0LjI4NTAy NDEyOCArMDgwMApAQCAtMzMsNiArMzMsNyBAQAogfQogCiBzcmNfY29tcGlsZSgpIHsKKwlwa2df c2V0dXAKIAllZ2FtZXNjb25mIFwKIAkJLS1kaXNhYmxlLWRlcGVuZGVuY3ktdHJhY2tpbmcgXAog CQktLWV4ZWNfcHJlZml4PSIke0dBTUVTX1BSRUZJWH0iIFwK 45498 2004-12-08 00:32 0000 patch alt scorched3d-38.alt.patch text/plain LS0tIHNjb3JjaGVkM2QtMzguZWJ1aWxkCTIwMDQtMTItMDggMTY6MTY6MTAuMDAwMDAwMDAwICsw ODAwCisrKyBzY29yY2hlZDNkLTM4LXIxLmVidWlsZAkyMDA0LTEyLTA4IDE2OjE3OjM1LjAwMDAw MDAwMCArMDgwMApAQCAtMjMsMTIgKzIzLDEzIEBACiAKIFM9IiR7V09SS0RJUn0vc2NvcmNoZWQi CiAKK2lmICEgdXNlIGd0azI7IHRoZW4KKwluZWVkLXd4d2lkZ2V0cyBndGsgfHwgZGllICJObyBn dGsxIHZlcnNpb24gb2YgeDExLWxpYnMvd3hHVEsgZm91bmQiCitlbHNlCisJbmVlZC13eHdpZGdl dHMgZ3RrMiB8fCBkaWUgIllvdSBuZWVkIHRvIGVtZXJnZSB3eEdUSyB3aXRoIFVTRT0nZ3RrMici CitmaQorCiBwa2dfc2V0dXAoKSB7Ci0JaWYgISB1c2UgZ3RrMjsgdGhlbgotCQluZWVkLXd4d2lk Z2V0cyBndGsgfHwgZGllICJObyBndGsxIHZlcnNpb24gb2YgeDExLWxpYnMvd3hHVEsgZm91bmQi Ci0JZWxzZQotCQluZWVkLXd4d2lkZ2V0cyBndGsyIHx8IGRpZSAiWW91IG5lZWQgdG8gZW1lcmdl IHd4R1RLIHdpdGggVVNFPSdndGsyJyIKLQlmaQogCWdhbWVzX3BrZ19zZXR1cAogfQogCg==