61922 2004-08-27 07:00 0000 media-gfx/jpeg2ps-1.9 uses hardcoded default paper size 2008-05-03 15:59:49 0000 1 1 1 Unclassified Gentoo Linux Applications unspecified All Linux RESOLVED FIXED P2 normal --- 1 ulm@gentoo.org pclouds@gentoo.org gpvos+gnt@xs4all.nl graphics@gentoo.org pylon@gentoo.org ulm@gentoo.org 2004-08-27 07:00:12 0000 The ebuild uses "letter" as hardcoded default paper size. This should be configurable. Suggestion: Use /etc/localtime to determine the continent, as in net-misc/hylafax-4.2.0_rc2. Or introduce a useflag. (See also bugs #34741, #38465, and #52716. Maybe it is time for a general solution for this issue.) jakub@gentoo.org 2005-07-27 18:18:39 0000 Re-assign a stale bug. pclouds@gentoo.org 2005-07-28 23:14:01 0000 It's not the ebuild hardcode this but the program jpeg2ps itself. As the ebuild says, you may you -p to specify other paper size. I mark this as WONTFIX. Please request to upstream. ulm@gentoo.org 2005-07-29 02:18:10 0000 It is more complicated. The Makefile from the source tar defaults to A4 paper format ("-DA4" compile time option). The ebuild meddles with this, effectively changing the default to Letter. Now, I completely disagree about this being an upstream issue. What should upstream do about this? They already provide a compile time and a run time option. Upstream knows nothing about the environment where the program will be installed. IMHO, it is the responsibility of the distribution to get things right. ulm@gentoo.org 2005-07-29 02:21:27 0000 Created an attachment (id=64597) Proposed patch for jpeg2ps-1.9.ebuild Determines the default pagesize depending on the continent. pclouds@gentoo.org 2005-07-31 18:32:15 0000 Ok. I misread the ebuild :( Applied your patch as jpeg2ps-1.9-r1. Please test it. Thanks pylon@gentoo.org 2005-07-31 19:02:28 0000 I think the timezone is bad to rely on. Usually you should use LC_PAPER for it (probably I _want_ to use letter, but I have a European timezone set). Sorry that I can't send patches yet. Probably later or you have an idea to ask for the locale-settings. ulm@gentoo.org 2005-08-01 03:54:28 0000 In reply to comment #5: Works fine for me. Minor issue: pkg_postinst outputs the wrong message; the "local" in the declaration of pagesize (in src_compile) should be removed. Sorry for that. ulm@gentoo.org 2005-08-31 01:23:34 0000 Created an attachment (id=67327) Proposed patch for jpeg2ps-1.9-r1.ebuild Again: If the remaining minor issue with the postinst message is fixed, this bug can IMHO be marked as resolved. See attached patch. pclouds@gentoo.org 2005-12-02 22:46:08 0000 Fixed in CVS. I'm really sorry it took too long to solve such a minor issue. ulm@gentoo.org 2008-04-11 06:41:01 0000 Reopening. The taken solution does not work anymore, since /etc/localtime is no longer a symlink. And meanwhile I think that the default should not depend on the configuration of the installed system. ulm@gentoo.org 2008-04-11 06:44:56 0000 Created an attachment (id=149370) Proposed patch for jpeg2ps-1.9-r1.ebuild Probably a USE flag is the cleanest thing we can do here, see attached patch. There is already: media-gfx/potrace:metric - default to a4 paper size and metric measurement So we could go with the "metric" flag, too: media-gfx/jpeg2ps:metric - Default to A4 paper size ulm@gentoo.org 2008-04-13 12:54:53 0000 (In reply to comment #11) > Created an attachment (id=149370) [edit] > Proposed patch for jpeg2ps-1.9-r1.ebuild Committed, as discussed with maekke on irc. gpvos+gnt@xs4all.nl 2008-04-16 20:39:59 0000 No; it would be much better if jpeg2ps, potrace and others use libpaper (/etc/papersize) instead. I'll prepare a patch. ulm@gentoo.org 2008-04-17 08:01:35 0000 Created an attachment (id=150026) jpeg2ps-1.9-libpaper.patch (In reply to comment #13) > No; it would be much better if jpeg2ps, potrace and others use libpaper > (/etc/papersize) instead. This looks obvious, and in fact was my first approach, too. I attach my patch for reference (it may still have some rough edges, but basically should work). However, it would introduce some subtle incompatibilities: - The "p11x17" page size is not known to libpaper (or rather, it uses a different name for it). - For page sizes other than A4 or Letter, the size of the bounding box may differ by 1 or 2 Postscript points. Therefore, one probably would want another USE flag to enable usage of libpaper. I'm not sure if it's worth the effort. ulm@gentoo.org 2008-05-03 15:59:49 0000 We might also have a licence problem if we link against libpaper. From the jpeg2ps licence: | This software is free. You are granted the right to use and copy it. | This software may not be sold or bundled with any commercial package | without express written permission of the author. And unfortunately, libpaper is not licenced under the LGPL, but under the GPL (version 2 only). I think that this is incompatible with the above (but IANAL). I've also contacted upstream (Thomas Merz) about this issue. He doesn't want to re-release jpeg2ps under a different licence. 64597 2005-07-29 02:21 0000 Proposed patch for jpeg2ps-1.9.ebuild patch text/plain LS0tIGpwZWcycHMtMS45LmVidWlsZH4JMjAwNS0wNi0wNSAxNDozNTo0NC4wMDAwMDAwMDAgKzAy MDAKKysrIGpwZWcycHMtMS45LmVidWlsZAkyMDA1LTA3LTI5IDExOjEzOjI5LjAwMDAwMDAwMCAr MDIwMApAQCAtMTUsMTIgKzE1LDEyIEBACiBSREVQRU5EPSIiCiAKIHNyY19jb21waWxlKCkgewot CSMgcmVtb3ZlIHRoZSAtREE0IHBhcGVyIHNpemUgZGVmYXVsdCBhbmQgdXNlIG91ciAke0NGTEFH U30KLQlzZWQgLWkgXAotCQktZSAicy9DRkxBR1M9LWMgLURBNCQvQ0ZMQUdTPS1jICR7Q0ZMQUdT fS8iIFwKLQkJTWFrZWZpbGUgfHwgXAotCQkJZGllICJzZWQgTWFrZWZpbGUgZmFpbGVkIgotCWVt YWtlIHx8IGRpZSAiZW1ha2UgZmFpbGVkIgorCWxvY2FsIHBhZ2VzaXplPSIiCisJaWYgWyAtaCAv ZXRjL2xvY2FsdGltZSBdOyB0aGVuCisJCWxvY2FsIGNvbnRpbmVudD0kKHJlYWRsaW5rIC9ldGMv bG9jYWx0aW1lIHwgY3V0IC1kIC8gLWYgNSkKKwkJWyAiJHtjb250aW5lbnR9IiA9ICJFdXJvcGUi IF0gJiYgcGFnZXNpemU9Ii1EQTQiCisJZmkKKwllbWFrZSBDRkxBR1M9Ii1jICR7Q0ZMQUdTfSAk e3BhZ2VzaXplfSIgfHwgZGllICJlbWFrZSBmYWlsZWQiCiB9CiAKIHNyY19pbnN0YWxsKCkgewpA QCAtMzMsOSArMzMsMTQgQEAKIAogcGtnX3Bvc3RpbnN0KCkgewogCWVpbmZvCi0JZWluZm8gIkJ5 IGRlZmF1bHQsIHRoaXMgaW5zdGFsbGF0aW9uIG9mIGpwZWcycHMgd2lsbCBnZW5lcmF0ZSIKLQll aW5mbyAibGV0dGVyIHNpemUgb3V0cHV0LiAgWW91IGNhbiBmb3JjZSBBNCBvdXRwdXQgd2l0aCIK LQllaW5mbyAiICAgIGpwZWcycHMgLXAgYTQgZmlsZS5qcGcgPiBmaWxlLnBzIgorCWlmIFsgLXog JHtwYWdlc2l6ZX0gXTsgdGhlbgorCQllaW5mbyAiQnkgZGVmYXVsdCwgdGhpcyBpbnN0YWxsYXRp b24gb2YganBlZzJwcyB3aWxsIGdlbmVyYXRlIgorCQllaW5mbyAibGV0dGVyIHNpemUgb3V0cHV0 LiAgWW91IGNhbiBmb3JjZSBBNCBvdXRwdXQgd2l0aCIKKwkJZWluZm8gIiAgICBqcGVnMnBzIC1w IGE0IGZpbGUuanBnID4gZmlsZS5wcyIKKwllbHNlCisJCWVpbmZvICJCeSBkZWZhdWx0LCB0aGlz IGluc3RhbGxhdGlvbiBvZiBqcGVnMnBzIHdpbGwgZ2VuZXJhdGUiCisJCWVpbmZvICJBNCBzaXpl IG91dHB1dC4gIFlvdSBjYW4gZm9yY2UgbGV0dGVyIG91dHB1dCB3aXRoIgorCQllaW5mbyAiICAg IGpwZWcycHMgLXAgbGV0dGVyIGZpbGUuanBnID4gZmlsZS5wcyIKKwlmaQogCWVpbmZvCiB9Ci0K 67327 2005-08-31 01:23 0000 Proposed patch for jpeg2ps-1.9-r1.ebuild patch text/plain LS0tIGpwZWcycHMtMS45LXIxLmVidWlsZH4JMjAwNS0wOC0zMSAxMDoxMDozOS4wMDAwMDAwMDAg KzAyMDAKKysrIGpwZWcycHMtMS45LXIxLmVidWlsZAkyMDA1LTA4LTMxIDEwOjEwOjQ5LjAwMDAw MDAwMCArMDIwMApAQCAtMTUsNyArMTUsNyBAQAogUkRFUEVORD0iIgogCiBzcmNfY29tcGlsZSgp IHsKLQlsb2NhbCBwYWdlc2l6ZT0iIgorCXBhZ2VzaXplPSIiCiAJaWYgWyAtaCAvZXRjL2xvY2Fs dGltZSBdOyB0aGVuCiAJCWxvY2FsIGNvbnRpbmVudD0kKHJlYWRsaW5rIC9ldGMvbG9jYWx0aW1l IHwgY3V0IC1kIC8gLWYgNSkKIAkJWyAiJHtjb250aW5lbnR9IiA9ICJFdXJvcGUiIF0gJiYgcGFn ZXNpemU9Ii1EQTQiCg== 149370 2008-04-11 06:44 0000 Proposed patch for jpeg2ps-1.9-r1.ebuild jpeg2ps-1.9-r1.ebuild.diff text/plain SW5kZXg6IGpwZWcycHMtMS45LXIxLmVidWlsZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvdmFyL2N2 c3Jvb3QvZ2VudG9vLXg4Ni9tZWRpYS1nZngvanBlZzJwcy9qcGVnMnBzLTEuOS1yMS5lYnVpbGQs dgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTUKZGlmZiAtdSAtQiAtcjEuMTUganBlZzJwcy0xLjkt cjEuZWJ1aWxkCi0tLSBqcGVnMnBzLTEuOS1yMS5lYnVpbGQJMjYgSmFuIDIwMDggMTA6Mzc6NTgg LTAwMDAJMS4xNQorKysganBlZzJwcy0xLjktcjEuZWJ1aWxkCTExIEFwciAyMDA4IDA2OjM0OjMx IC0wMDAwCkBAIC0xMSw3ICsxMSw3IEBACiBMSUNFTlNFPSJmcmVlLW5vbmNvbW0iCiBTTE9UPSIw IgogS0VZV09SRFM9ImFtZDY0IHBwYyB+cHBjNjQgc3BhcmMgeDg2IgotSVVTRT0iIgorSVVTRT0i bWV0cmljIgogCiBERVBFTkQ9InN5cy1hcHBzL3NlZCIKIFJERVBFTkQ9IiIKQEAgLTI1LDEwICsy NSw3IEBACiAKIHNyY19jb21waWxlKCkgewogCXBhZ2VzaXplPSIiCi0JaWYgWyAtaCAvZXRjL2xv Y2FsdGltZSBdOyB0aGVuCi0JCWxvY2FsIGNvbnRpbmVudD0kKHJlYWRsaW5rIC9ldGMvbG9jYWx0 aW1lIHwgY3V0IC1kIC8gLWYgNSkKLQkJWyAiJHtjb250aW5lbnR9IiA9ICJFdXJvcGUiIF0gJiYg cGFnZXNpemU9Ii1EQTQiCi0JZmkKKwl1c2UgbWV0cmljICYmIHBhZ2VzaXplPSItREE0IgogCWVt YWtlIENGTEFHUz0iLWMgJHtDRkxBR1N9ICR7cGFnZXNpemV9IiB8fCBkaWUgImVtYWtlIGZhaWxl ZCIKIH0KIAo= 150026 2008-04-17 08:01 0000 jpeg2ps-1.9-libpaper.patch jpeg2ps-1.9-libpaper.patch text/plain LS0tIGpwZWcycHMtMS45LW9yaWcvanBlZzJwcy5jCTIwMDItMDItMDQgMTI6Mzk6MjEuMDAwMDAw MDAwICswMTAwCisrKyBqcGVnMnBzLTEuOS9qcGVnMnBzLmMJMjAwOC0wNC0wOSAyMjoxNDoxOS4w MDAwMDAwMDAgKzAyMDAKQEAgLTMyLDYgKzMyLDExIEBACiAjaW5jbHVkZSA8dW5pc3RkLmg+CiAj ZW5kaWYKIAorI2lmZGVmIEhBVkVfTElCUEFQRVIKKyNpbmNsdWRlIDxtYXRoLmg+CisjaW5jbHVk ZSA8cGFwZXIuaD4KKyNlbmRpZgorCiAjaWZuZGVmIE1BQwogZXh0ZXJuIGNoYXIgKm9wdGFyZzsK IGV4dGVybiBpbnQgb3B0aW5kOwpAQCAtNzMsNiArNzgsNyBAQAogc3RhdGljIGNoYXIgYnVmZmVy W0JVRkZFUlNJWkVdOwogc3RhdGljIGNoYXIgKkNvbG9yU3BhY2VOYW1lc1tdID0geyIiLCAiR3Jh eSIsICIiLCAiUkdCIiwgIkNNWUsiIH07CiAKKyNpZm5kZWYgSEFWRV9MSUJQQVBFUgogLyogQXJy YXkgb2Yga25vd24gcGFnZSBzaXplcyBpbmNsdWRpbmcgbmFtZSwgd2lkdGgsIGFuZCBoZWlnaHQg Ki8KIAogdHlwZWRlZiBzdHJ1Y3QgeyBjb25zdCBjaGFyICpuYW1lOyBpbnQgd2lkdGg7IGludCBo ZWlnaHQ7IH0gUGFnZVNpemVfczsKQEAgLTk2LDYgKzEwMiw3IEBACiB9OwogCiAjZGVmaW5lIFBB R0VTSVpFTElTVAkoc2l6ZW9mKFBhZ2VTaXplcykvc2l6ZW9mKFBhZ2VTaXplc1swXSkpCisjZW5k aWYKIAogI2lmZGVmIEE0CiBpbnQgUGFnZVdpZHRoICA9IDU5NTsgICAgICAgICAgIC8qIHBhZ2Ug d2lkdGggQTQgKi8KQEAgLTI5NCw4ICszMDEsMTIgQEAKICAgZnByaW50ZihzdGRlcnIsICItYiAg ICAgICAgYmluYXJ5IG1vZGU6IG91dHB1dCA4IGJpdCBkYXRhIChkZWZhdWx0OiA3IGJpdCB3aXRo IEFTQ0lJODUpXG4iKTsKICAgZnByaW50ZihzdGRlcnIsICItaCAgICAgICAgaGV4IG1vZGU6IG91 dHB1dCA3IGJpdCBkYXRhIGluIEFTQ0lJSGV4IGVuY29kaW5nXG4iKTsKICAgZnByaW50ZihzdGRl cnIsICItbyA8bmFtZT4gb3V0cHV0IGZpbGUgbmFtZVxuIik7CisjaWZkZWYgSEFWRV9MSUJQQVBF UgorICBmcHJpbnRmKHN0ZGVyciwgIi1wIDxzaXplPiBwYWdlIHNpemUgbmFtZS4gU2VlIFwicGFw ZXJjb25mIC1hXCIgZm9yIGEgbGlzdCBvZiBrbm93biBuYW1lc1xuIik7CisjZWxzZQogICBmcHJp bnRmKHN0ZGVyciwgIi1wIDxzaXplPiBwYWdlIHNpemUgbmFtZS4gS25vd24gbmFtZXMgYXJlOlxu Iik7CiAgIGZwcmludGYoc3RkZXJyLCAiICAgICAgICAgIGEwLCBhMSwgYTIsIGEzLCBhNCwgYTUs IGE2LCBiNSwgbGV0dGVyLCBsZWdhbCwgbGVkZ2VyLCBwMTF4MTdcbiIpOworI2VuZGlmCiAgIGZw cmludGYoc3RkZXJyLCAiLXEgICAgICAgIHF1aWV0IG1vZGU6IHN1cHByZXNzIGFsbCBpbmZvcm1h dGlvbmFsIG1lc3NhZ2VzXG4iKTsKICAgZnByaW50ZihzdGRlcnIsICItciA8ZHBpPiAgcmVzb2x1 dGlvbiB2YWx1ZSAoZG90cyBwZXIgaW5jaClcbiIpOwogICBmcHJpbnRmKHN0ZGVyciwgIiAgICAg ICAgICAwIG1lYW5zIHVzZSB2YWx1ZSBnaXZlbiBpbiBmaWxlLCBpZiBhbnkgKGRpc2FibGVzIGF1 dG9yb3RhdGUpXG4iKTsKQEAgLTMxNCw2ICszMjUsMTAgQEAKICAgaW50IG9wdCwgcGFnZXNpemVp bmRleCA9IC0xOwogI2VuZGlmCiAKKyNpZmRlZiBIQVZFX0xJQlBBUEVSCisgIGNvbnN0IHN0cnVj dCBwYXBlciAqcGluZm9fZGVmYXVsdCwgKnBpbmZvID0gTlVMTDsKKyNlbmRpZgorCiAgIGltYWdl LmZpbGVuYW1lID0gTlVMTDsKICAgaW1hZ2UubW9kZSAgICAgPSBBU0NJSTg1OwogICBpbWFnZS5z dGFydHBvcyA9IDBMOwpAQCAtMzI2LDYgKzM0MSwxNSBAQAogIGlmIChhcmdjID09IDEpCiAgICAg dXNhZ2UoKTsKIAorI2lmZGVmIEhBVkVfTElCUEFQRVIKKyAgLyogZ2V0IGRlZmF1bHQgcGFwZXIg c2l6ZSBmcm9tIGxpYnBhcGVyICovCisgIHBhcGVyaW5pdCgpOworICBpZiAoKHBpbmZvX2RlZmF1 bHQgPSBwYXBlcmluZm8oc3lzdGVtcGFwZXJuYW1lKCkpKSkgeworICAgIFBhZ2VXaWR0aCA9IHJp bnQocGFwZXJwc3dpZHRoKHBpbmZvX2RlZmF1bHQpKTsKKyAgICBQYWdlSGVpZ2h0ID0gcmludChw YXBlcnBzaGVpZ2h0KHBpbmZvX2RlZmF1bHQpKTsKKyAgfQorI2VuZGlmCisKICNpZm5kZWYgTUFD CiAgIHdoaWxlICgob3B0ID0gZ2V0b3B0KGFyZ2MsIGFyZ3YsICJhYmhvOnA6cXI6IikpICE9IC0x KQogICAgIHN3aXRjaCAob3B0KSB7CkBAIC0zNDYsNiArMzcwLDE4IEBACiAJICB9IAogCSAgYnJl YWs7CiAgICAgICBjYXNlICdwJzoKKyNpZmRlZiBIQVZFX0xJQlBBUEVSCisJICBmb3IgKHBpbmZv ID0gcGFwZXJmaXJzdCgpOyBwaW5mbzsgcGluZm8gPSBwYXBlcm5leHQocGluZm8pKQorCSAgICBp ZiAoIXN0cmNtcCgoY29uc3QgY2hhciAqKW9wdGFyZywgcGFwZXJuYW1lKHBpbmZvKSkpIHsKKwkg ICAgICBQYWdlV2lkdGggPSByaW50KHBhcGVycHN3aWR0aChwaW5mbykpOworCSAgICAgIFBhZ2VI ZWlnaHQgPSByaW50KHBhcGVycHNoZWlnaHQocGluZm8pKTsKKwkgICAgICBicmVhazsKKwkgICAg fQorCSAgaWYgKCFwaW5mbykgewkJLyogcGFnZSBzaXplIG5hbWUgbm90IGZvdW5kICovCisJICAg IGZwcmludGYoc3RkZXJyLCAiRXJyb3I6IFVua25vd24gcGFnZSBzaXplICVzLlxuIiwgb3B0YXJn KTsKKwkgICAgZXhpdCgtMyk7CisJICB9CisjZWxzZQogCSAgZm9yKHBhZ2VzaXplaW5kZXg9MDsg cGFnZXNpemVpbmRleCA8IFBBR0VTSVpFTElTVDsgcGFnZXNpemVpbmRleCsrKQogCSAgICBpZiAo IXN0cmNtcCgoY29uc3QgY2hhciAqKSBvcHRhcmcsIFBhZ2VTaXplc1twYWdlc2l6ZWluZGV4XS5u YW1lKSkgewogCQlQYWdlSGVpZ2h0ID0gUGFnZVNpemVzW3BhZ2VzaXplaW5kZXhdLmhlaWdodDsK QEAgLTM1Niw2ICszOTIsNyBAQAogCQlmcHJpbnRmKHN0ZGVyciwgIkVycm9yOiBVbmtub3duIHBh Z2Ugc2l6ZSAlcy5cbiIsIG9wdGFyZyk7CiAJCWV4aXQoLTMpOwogCSAgfQorI2VuZGlmCiAJICBi cmVhazsKICAgICAgIGNhc2UgJ3EnOgogICAgICAgICAgIHF1aWV0ID0gVFJVRTsKQEAgLTM3MSw5 ICs0MDgsMTUgQEAKIAkgIHVzYWdlKCk7CiAgICAgfQogCisjaWZkZWYgSEFWRV9MSUJQQVBFUgor ICBpZiAocGluZm8gJiYgIXF1aWV0KQkJLyogcGFnZSBzaXplIHVzZXIgb3B0aW9uIGdpdmVuICov CisgICAgZnByaW50ZihzdGRlcnIsICJOb3RlOiBVc2luZyAlcyBwYWdlIHNpemUuXG4iLCBwYXBl cm5hbWUocGluZm8pKTsKKyAgcGFwZXJkb25lKCk7CisjZWxzZQogICBpZiAocGFnZXNpemVpbmRl eCAhPSAtMSAmJiAhIHF1aWV0KQkvKiBwYWdlIHNpemUgdXNlciBvcHRpb24gZ2l2ZW4gKi8KICAg ICAgIGZwcmludGYoc3RkZXJyLCAiTm90ZTogVXNpbmcgJXMgcGFnZSBzaXplLlxuIiwKIAkJICAg IFBhZ2VTaXplc1twYWdlc2l6ZWluZGV4XS5uYW1lKTsKKyNlbmRpZgogCiAgIGlmIChvcHRpbmQg PT0gYXJnYykJLyogZmlsZW5hbWUgbWlzc2luZyAqLwogICAgIHVzYWdlKCk7Cg==