61531 2004-08-24 09:52 0000 fbzx-1.4 won't work on PPC 2004-08-26 19:58:18 0000 1 1 1 Unclassified Gentoo Linux Games unspecified PPC Linux RESOLVED FIXED P2 normal --- 1 mat@esi.com.pl games@gentoo.org ppc@gentoo.org mat@esi.com.pl 2004-08-24 09:52:49 0000 While the program compiles fine it lacks the necessary changes described in PORTS file to work properly on PPC (and other big-endian system). Reproducible: Always Steps to Reproduce: 1. 2. 3. So I did a little patch that solved the problem for me. --------------------------------------------------- fbzx-1.4-endian_patch --- fbzx/Z80.h 2003-12-19 21:37:22.000000000 +0100 +++ fbzx.new/Z80.h 2004-08-24 18:26:50.696481080 +0200 @@ -12,7 +12,10 @@ /*************************************************************/ #ifndef Z80_H #define Z80_H +#include <endian.h> +#if __BYTE_ORDER == __LITTLE_ENDIAN #define LSB_FIRST +#endif /* Compilation options: */ /* #define DEBUG */ /* Compile debugging version */ /* #define LSB_FIRST */ /* Compile for low-endian CPU */ ------------------------------------------------------------------------- mat@esi.com.pl 2004-08-24 09:58:25 0000 Created an attachment (id=38104) fbzx-1.4-endian_patch wolf31o2@gentoo.org 2004-08-24 10:14:00 0000 Have you checked if this has been fixed upstream? I only ask so that we know if we should submit the patch to them or not... =] mat@esi.com.pl 2004-08-24 10:20:09 0000 No. I didn't checked as I don't think author of fbzx considers it a bug. There is a note in PORTS readme stating that when you compile it on big-endian machine you should remove one #define. What I did is the extension of this note to automate the build. vapier@gentoo.org 2004-08-26 19:58:18 0000 awesome, thanks again gonna try to contact upstream author ... 38104 2004-08-24 09:58 0000 fbzx-1.4-endian_patch fbzx-1.4-endian_patch text/plain LS0tIGZiengvWjgwLmgJMjAwMy0xMi0xOSAyMTozNzoyMi4wMDAwMDAwMDAgKzAxMDAKKysrIGZi engubmV3L1o4MC5oCTIwMDQtMDgtMjQgMTg6MjY6NTAuNjk2NDgxMDgwICswMjAwCkBAIC0xMiw3 ICsxMiwxMCBAQAogLyoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKiovDQogI2lmbmRlZiBaODBfSA0KICNkZWZpbmUgWjgwX0gNCisjaW5j bHVkZSA8ZW5kaWFuLmg+DQorI2lmIF9fQllURV9PUkRFUiA9PSBfX0xJVFRMRV9FTkRJQU4NCiAj ZGVmaW5lIExTQl9GSVJTVA0KKyNlbmRpZg0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAvKiBDb21waWxhdGlvbiBvcHRpb25zOiAgICAgICAqLw0KIC8qICNkZWZpbmUgREVCVUcgKi8g ICAgICAgICAgICAvKiBDb21waWxlIGRlYnVnZ2luZyB2ZXJzaW9uICAqLw0KIC8qICNkZWZpbmUg TFNCX0ZJUlNUICovICAgICAgICAvKiBDb21waWxlIGZvciBsb3ctZW5kaWFuIENQVSAqLw0K