59832 2004-08-09 01:01 0000 sg3_utils fails to compile with USE=pic 2004-08-09 14:39:24 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified All All RESOLVED FIXED P2 major --- 1 merlin@gentoo.org plasmaroo@gentoo.org merlin@gentoo.org 2004-08-09 01:01:16 0000 sg3_utils uses llseek.c from util-linux. solar fixed util-linux's llseek.c with files/util-linux-2.11z-pic.patch in July of 2003 (see the ChangeLog). The _llseek() system call is actually the wrong way to call llseek now, and while his patch does compile with -fPIC, I believe my implementation is better (see Bug 51962). With this change I believe we can compile safely with enhanced CFLAGS. Finally, I removed the HAS_LONG_LONG check, since there is no configure script that will ever define this, and the rest of the code uses long long liberally. Attached is an ebuild and source code patch. I will submit the source code patch upstream, too. merlin@gentoo.org 2004-08-09 01:02:17 0000 Created an attachment (id=37081) sg3_utils-llseek.patch merlin@gentoo.org 2004-08-09 01:02:41 0000 Created an attachment (id=37082) sg3_utils-1.06.ebuild.patch plasmaroo@gentoo.org 2004-08-09 14:39:24 0000 Now fixed in CVS, it should reach the rsync mirrors shortly - closing as FIXED. Thanks for the patch and please reopen this bug if you have any further issues... 37081 2004-08-09 01:02 0000 sg3_utils-llseek.patch sg3_utils-llseek.patch text/plain ZGlmZiAtTmF1ciBzZzNfdXRpbHMtMS4wNi1vcmlnL2xsc2Vlay5jIHNnM191dGlscy0xLjA2L2xs c2Vlay5jCi0tLSBzZzNfdXRpbHMtMS4wNi1vcmlnL2xsc2Vlay5jCTIwMDMtMTAtMTkgMDU6MzY6 NDAuMDAwMDAwMDAwIC0wNDAwCisrKyBzZzNfdXRpbHMtMS4wNi9sbHNlZWsuYwkyMDA0LTA4LTA5 IDAzOjQ2OjE5Ljk3Mzg2NDk2OSAtMDQwMApAQCAtMTQsNyArMTQsNyBAQAogI2luY2x1ZGUgPGVy cm5vLmg+CiAjaW5jbHVkZSA8dW5pc3RkLmg+CiAKLSNpZiBkZWZpbmVkKF9fR05VQ19fKSB8fCBk ZWZpbmVkKEhBU19MT05HX0xPTkcpCisjaWYgZGVmaW5lZChfX0dOVUNfXykKIHR5cGVkZWYgbG9u ZyBsb25nICAgICAgIGxsc2VfbG9mZl90OwogI2Vsc2UKIHR5cGVkZWYgbG9uZyAgICAgICAgICAg IGxsc2VfbG9mZl90OwpAQCAtMjQsNTQgKzI0LDE2IEBACiAKICNpZmRlZiBfX2xpbnV4X18KIAot I2lmZGVmIEhBVkVfTExTRUVLCi0jaW5jbHVkZSA8c3lzY2FsbC5oPgotCi0jZWxzZSAgIC8qIEhB VkVfTExTRUVLICovCi0KICNpZiBkZWZpbmVkKF9fYWxwaGFfXykgfHwgZGVmaW5lZChfX2lhNjRf XykgIHx8IGRlZmluZWQoX19zMzkweF9fKQogCiAjZGVmaW5lIG15X2xsc2VlayBsc2VlawogCiAj ZWxzZQotI2luY2x1ZGUgPGxpbnV4L3VuaXN0ZC5oPiAgICAgICAvKiBmb3IgX19OUl9fbGxzZWVr ICovCi0KLXN0YXRpYyBpbnQgX2xsc2VlayAodW5zaWduZWQgaW50LCB1bnNpZ25lZCBsb25nLAot ICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcsIGxsc2VfbG9mZl90ICosIHVuc2lnbmVk IGludCk7Ci0KLSNpZmRlZiBfX05SX19sbHNlZWsKLQotc3RhdGljIF9zeXNjYWxsNShpbnQsX2xs c2Vlayx1bnNpZ25lZCBpbnQsZmQsdW5zaWduZWQgbG9uZyxvZmZzZXRfaGlnaCwKLSAgICAgICAg ICAgICAgICAgdW5zaWduZWQgbG9uZywgb2Zmc2V0X2xvdyxsbHNlX2xvZmZfdCAqLHJlc3VsdCwK LSAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50LCBvcmlnaW4pCi0KLSNlbHNlCi0KLS8qIG5v IF9fTlJfX2xsc2VlayBvbiBjb21waWxhdGlvbiBtYWNoaW5lIC0gbWlnaHQgZ2l2ZSBpdCBleHBs aWNpdGx5ICovCi1zdGF0aWMgaW50IF9sbHNlZWsgKHVuc2lnbmVkIGludCBmZCwgdW5zaWduZWQg bG9uZyBvaCwKLSAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBvbCwgbGxzZV9sb2Zm X3QgKnJlc3VsdCwKLSAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG9yaWdpbikgewot ICAgICAgICBlcnJubyA9IEVOT1NZUzsKLSAgICAgICAgcmV0dXJuIC0xOwotfQotCi0jZW5kaWYK IAotc3RhdGljIGxsc2VfbG9mZl90IG15X2xsc2VlayAodW5zaWduZWQgaW50IGZkLCBsbHNlX2xv ZmZfdCBvZmZzZXQsCi0gICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG9yaWdpbikKLXsKLSAg ICAgICAgbGxzZV9sb2ZmX3QgcmVzdWx0OwotICAgICAgICBpbnQgcmV0dmFsOwotCi0gICAgICAg IHJldHZhbCA9IF9sbHNlZWsgKGZkLCAoKHVuc2lnbmVkIGxvbmcgbG9uZykgb2Zmc2V0KSA+PiAz MiwKLSAgICAgICAgICAgICAgICAgICAgICAgICgodW5zaWduZWQgbG9uZyBsb25nKSBvZmZzZXQp ICYgMHhmZmZmZmZmZiwKLSAgICAgICAgICAgICAgICAgICAgICAgICZyZXN1bHQsIG9yaWdpbik7 Ci0gICAgICAgIHJldHVybiAocmV0dmFsID09IC0xID8gKGxsc2VfbG9mZl90KSByZXR2YWwgOiBy ZXN1bHQpOwotfQorI2RlZmluZSBteV9sbHNlZWsgbHNlZWs2NAogCi0jZW5kaWYgLyogX19hbHBo YV9fICovCisjZW5kaWYgLyogYWxwaGEsIGlhNjQsIHMzOTB4ICovCiAKLSNlbmRpZiAgLyogSEFW RV9MTFNFRUsgKi8KIAogbGxzZV9sb2ZmX3QgbGxzZV9sbHNlZWsgKHVuc2lnbmVkIGludCBmZCwg bGxzZV9sb2ZmX3Qgb2Zmc2V0LAogICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGlu dCBvcmlnaW4pCg== 37082 2004-08-09 01:02 0000 sg3_utils-1.06.ebuild.patch sg3_utils-1.06.ebuild.patch text/plain LS0tIC91c3IvcG9ydGFnZS9zeXMtYXBwcy9zZzNfdXRpbHMvc2czX3V0aWxzLTEuMDYuZWJ1aWxk CTIwMDQtMDYtMjQgMTg6Mzc6MzguMDAwMDAwMDAwIC0wNDAwCisrKyBzZzNfdXRpbHMtMS4wNi5l YnVpbGQJMjAwNC0wOC0wOSAwMzo1MzoyMS4wODkwMjY4NjUgLTA0MDAKQEAgLTIsNiArMiw4IEBA CiAjIERpc3RyaWJ1dGVkIHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGlj IExpY2Vuc2UgdjIKICMgJEhlYWRlcjogL3Zhci9jdnNyb290L2dlbnRvby14ODYvc3lzLWFwcHMv c2czX3V0aWxzL3NnM191dGlscy0xLjA2LmVidWlsZCx2IDEuMyAyMDA0LzA2LzI0IDIyOjI2OjEx IGFncmlmZmlzIEV4cCAkCiAKK2luaGVyaXQgZXV0aWxzCisKIERFU0NSSVBUSU9OPSJTZzNfdXRp bHMgcHJvdmlkZSBhIGNvbGxlY3Rpb24gb2YgcHJvZ3JhbXMgdGhhdCB1c2UgdGhlIHNnIFNDU0kg aW50ZXJmYWNlIgogSE9NRVBBR0U9Imh0dHA6Ly93d3cudG9ycXVlLm5ldC9zZy8iCiBTUkNfVVJJ PSJodHRwOi8vd3d3LnRvcnF1ZS5uZXQvc2cvcC9zZzNfdXRpbHMtMS4wNi50Z3oiCkBAIC0xNCw2 ICsxNiwxNSBAQAogCiBERVBFTkQ9IiIKIAorc3JjX3VucGFjaygpIHsKKwl1bnBhY2sgJHtBfQor CWNkICR7U30KKworCWVwYXRjaCAke0ZJTEVTRElSfS8ke1BOfS1sbHNlZWsucGF0Y2gKKworCXNl ZCAtaSAiczotTzI6JENGTEFHUzpnIiBNYWtlZmlsZQorfQorCiBzcmNfY29tcGlsZSgpIHsKIAll bWFrZSB8fCBkaWUKIH0K