59743 2004-08-07 19:35 0000 log4cxx compile fails on errno 2005-01-06 05:48:49 0000 1 1 1 Unclassified Gentoo Linux Development unspecified All Linux RESOLVED FIXED P2 normal --- 1 bencollins@tamu.edu ka0ttic@gentoo.org gurligebis@gentoo.org bencollins@tamu.edu 2004-08-07 19:35:44 0000 An unwise #define causes errno.h to not be included when compiling on linux. Patch is attached. Reproducible: Always Steps to Reproduce: 1. 2. 3. bencollins@tamu.edu 2004-08-07 19:38:19 0000 Created an attachment (id=36997) patch for log4cxx-0.9.5 ~/src/filewatchdog.cpp bencollins@tamu.edu 2004-08-07 19:42:17 0000 (From update of attachment 36997) >--- filewatchdog.cpp.orig 2004-08-07 21:36:34.987676584 -0500 >+++ filewatchdog.cpp 2004-08-07 21:36:41.562677032 -0500 >@@ -17,10 +17,7 @@ > #include <log4cxx/helpers/filewatchdog.h> > #include <log4cxx/helpers/loglog.h> > #include <sys/stat.h> >- >-#ifdef WIN32 >-#include <errno.h> >+#include <cerrno> >-#endif > > using namespace log4cxx; > using namespace log4cxx::helpers; bencollins@tamu.edu 2004-08-07 20:18:51 0000 Created an attachment (id=36998) patch #2 for log4cxx-0.9.5 gurligebis@gentoo.org 2004-08-07 23:02:10 0000 Compiles fine for me when using changed patch 1, and patch 2. I have combined them into one, and corrected the path (added src/ before the filenames). This obsoletes patch 1 and 2. gurligebis@gentoo.org 2004-08-07 23:02:54 0000 Created an attachment (id=37000) combined patch ka0ttic@gentoo.org 2004-12-26 05:54:54 0000 Do you still run into this problem with 0.9.7? ka0ttic@gentoo.org 2005-01-06 05:48:49 0000 Fixed. Thanks guys. 36997 2004-08-07 19:38 0000 patch for log4cxx-0.9.5 filewatchdog.patch text/plain LS0tIGZpbGV3YXRjaGRvZy5jcHAub3JpZwkyMDA0LTA4LTA3IDIxOjM2OjM0Ljk4NzY3NjU4NCAt MDUwMAorKysgZmlsZXdhdGNoZG9nLmNwcAkyMDA0LTA4LTA3IDIxOjM2OjQxLjU2MjY3NzAzMiAt MDUwMApAQCAtMTcsMTAgKzE3LDcgQEAKICNpbmNsdWRlIDxsb2c0Y3h4L2hlbHBlcnMvZmlsZXdh dGNoZG9nLmg+CiAjaW5jbHVkZSA8bG9nNGN4eC9oZWxwZXJzL2xvZ2xvZy5oPgogI2luY2x1ZGUg PHN5cy9zdGF0Lmg+Ci0KLSNpZmRlZiBXSU4zMgogI2luY2x1ZGUgPGNlcnJubz4KLSNlbmRpZgog CiB1c2luZyBuYW1lc3BhY2UgbG9nNGN4eDsKIHVzaW5nIG5hbWVzcGFjZSBsb2c0Y3h4OjpoZWxw ZXJzOwo= 36998 2004-08-07 20:18 0000 patch #2 for log4cxx-0.9.5 socketimpl.patch text/plain LS0tIHNvY2tldGltcGwuY3BwLm9yaWcJMjAwNC0wOC0wNyAyMjowMTowMi41Nzc1NjkwMDggLTA1 MDAKKysrIHNvY2tldGltcGwuY3BwCTIwMDQtMDgtMDcgMjI6MDE6MjMuODY4MzMyMzIwIC0wNTAw CkBAIC0xNSw2ICsxNSw3IEBACiAgKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqLwogCiAjaW5jbHVkZSA8bG9n NGN4eC9jb25maWcuaD4KKyNpbmNsdWRlIDxjZXJybm8+CiAKICNpZmRlZiBXSU4zMgogI2luY2x1 ZGUgPHdpbmRvd3MuaD4K 37000 2004-08-07 23:02 0000 combined patch combined-patch.diff text/plain LS0tIHNyYy9maWxld2F0Y2hkb2cuY3BwLm9yaWcJMjAwNC0wOC0wNyAyMTozNjozNC45ODc2NzY1 ODQgLTA1MDAKKysrIHNyYy9maWxld2F0Y2hkb2cuY3BwCTIwMDQtMDgtMDcgMjE6MzY6NDEuNTYy Njc3MDMyIC0wNTAwCkBAIC0xNywxMCArMTcsNyBAQAogI2luY2x1ZGUgPGxvZzRjeHgvaGVscGVy cy9maWxld2F0Y2hkb2cuaD4KICNpbmNsdWRlIDxsb2c0Y3h4L2hlbHBlcnMvbG9nbG9nLmg+CiAj aW5jbHVkZSA8c3lzL3N0YXQuaD4KLQotI2lmZGVmIFdJTjMyCi0jaW5jbHVkZSA8ZXJybm8uaD4K KyNpbmNsdWRlIDxjZXJybm8+Ci0jZW5kaWYKIAogdXNpbmcgbmFtZXNwYWNlIGxvZzRjeHg7CiB1 c2luZyBuYW1lc3BhY2UgbG9nNGN4eDo6aGVscGVyczsKLS0tIHNyYy9zb2NrZXRpbXBsLmNwcC5v cmlnCTIwMDQtMDgtMDcgMjI6MDE6MDIuNTc3NTY5MDA4IC0wNTAwCisrKyBzcmMvc29ja2V0aW1w bC5jcHAJMjAwNC0wOC0wNyAyMjowMToyMy44NjgzMzIzMjAgLTA1MDAKQEAgLTE1LDYgKzE1LDcg QEAKICAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKiovCiAKICNpbmNsdWRlIDxsb2c0Y3h4L2NvbmZpZy5oPgor I2luY2x1ZGUgPGNlcnJubz4KIAogI2lmZGVmIFdJTjMyCiAjaW5jbHVkZSA8d2luZG93cy5oPgo=