5746 2002-07-29 15:19 0000 vpopmail 5.2.1 has a major flaw (patch inside) 2003-02-04 19:42:18 0000 1 1 1 Unclassified Gentoo Linux Ebuilds unspecified x86 Linux RESOLVED FIXED P2 major --- 1 kryptolus@gmail.com nick@capital-internet.net kryptolus@gmail.com 2002-07-29 15:19:02 0000 All the work was done by Vladimir Berezniker (vladimir@berezniker.com). I am just entering this bug report on his behalf. vpopmail 5.2.1 has a bug where the login string is null-terminated in the wrong location causing login failure in a lot of cases. The problem was narrowed down to the parse_email function and looking through the changelog for newer (development) versions of vpopmail, you can see that this bug was already fixed in later versions. Instead of recreating the patch, Vladimir simply backported the parse_email function from the latest development version to 5.2.1 Now all the logins on our system work properly. Attached is the diff for the ebuild and diff to vpopmail. (the diff would have to be given an appropriate name and referenced properly in the ebuil) kryptolus@gmail.com 2002-07-29 15:21:50 0000 Created an attachment (id=2670) ebuild patch This patch should be applied to vpopmail-5.2.1-r2.ebuild kryptolus@gmail.com 2002-07-29 15:23:13 0000 Created an attachment (id=2671) vpopmail diff This patch should be placed in the files/ directory for vpopmail package. The ebuild should be corrected to reference whatever name this file gets. nick@capital-internet.net 2002-07-30 08:32:57 0000 The patch and fixed ebuild are now in portage. Thanks for the patches! kryptolus@gmail.com 2002-07-30 15:16:20 0000 My brother is gonna be pissed. The credit was supposed to go to him :-P Now he's gonna kill me. 2670 2002-07-29 15:21 0000 ebuild patch vlad.fix text/plain NjVhNjYsNzAKPiAKPiAJIyBUaGFua3MgdG8gVmxhZGltaXIgQmVyZXpuaWtlciAodmxhZGltaXJA YmVyZXpuaWtlci5jb20pCj4gCSMgQmFja3BvcnRlZCBwYXJzZV9lbWFpbCBmcm9tIDUuMy43IHRv IDUuMi4xCj4gCSMgRml4ZXMgYSBwcm9ibGVtIHdoZXJlIHRoZSBsb2dpbiBzdHJpbmcgd291bGQg YmUgbnVsbCB0ZXJtaW5hdGVkIGluIHRoZSB3cm9uZyBwbGFjZSBjYXVzaW5nIHJlamVjdGVkIGxv Z2lucwo+IAlwYXRjaCA8ICR7RklMRVNESVJ9L3Zwb3BtYWlsLmRpZmYgfHwgZGllCg== 2671 2002-07-29 15:23 0000 vpopmail diff vpopmail.diff text/plain LS0tIHZwb3BtYWlsLmMJU2F0IE1heSAxOCAwMjoyNTo0OSAyMDAyCisrKyB2Yi92cG9wbWFpbC5j CU1vbiBKdWwgMjkgMTU6MDY6NDcgMjAwMgpAQCAtMTAxMiw1MSArMTAxMiw0NSBAQAogIGludCAg YnVmZl9zaXplOwogewogIGludCBpOwotIGludCBqOwotIGludCBrOwotIGludCBmb3VuZDsKLQot ICAgIGZvciggaT0wLGo9MCxmb3VuZD0wOyBmb3VuZD09MCAmJiBqPGJ1ZmZfc2l6ZSAmJiBlbWFp bFtpXSE9MDsgKytpLCsraikgewotICAgICAgICBmb3Ioaz0wO0FUQ0hBUlNba10hPTA7KytrKXsK LSAgICAgICAgICAgIGlmICggZW1haWxbaV0gPT0gQVRDSEFSU1trXSApIHsKLSAgICAgICAgICAg ICAgICBmb3VuZCA9IDE7Ci0gICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICB9 Ci0gICAgICAgIH0KLSAgICAgICAgaWYgKCBmb3VuZCA9PSAwICkgIHsgCi0gICAgICAgICAgdXNl cltqXSA9IGVtYWlsW2ldOwotICAgICAgICB9Ci0gICAgfQotICAgIHVzZXJbal0gPSAwOwotICAg IGxvd2VyaXQodXNlcik7Ci0KKyBpbnQgbjsKKyBpbnQgbGVuOworIGNoYXIgKmF0ID0gTlVMTDsK KworICBsb3dlcml0KGVtYWlsKTsKKworICBsZW4gPSBzdHJsZW4oQVRDSEFSUyk7CisgIGZvcihp PTA7aTxsZW47ICsraSApIGlmICgoYXQ9c3RyY2hyKGVtYWlsLEFUQ0hBUlNbaV0pKSkgYnJlYWs7 CisKKyAgaWYgKCBhdCE9TlVMTCApIHsKKyAgICBuID0gYXQgLSBlbWFpbCArIDE7CisgICAgaWYg KCBuID4gYnVmZl9zaXplICkgbiA9IGJ1ZmZfc2l6ZTsKKyAgICBzdHJuY3B5KHVzZXIsIGVtYWls LCBuKTsKKyAgICB1c2VyW24tMV0gPSAwOworICAgIHN0cm5jcHkoZG9tYWluLCArK2F0LCBidWZm X3NpemUpOworICAgIGRvbWFpbltidWZmX3NpemUtMV0gPSAwOworICB9IGVsc2UgeworICAgIHN0 cm5jcHkodXNlciwgZW1haWwsIGJ1ZmZfc2l6ZSk7CisgICAgdXNlcltidWZmX3NpemUtMV0gPSAw OwogICAgIGRvbWFpblswXSA9IDA7Ci0gICAgaWYgKGVtYWlsW2ldIT0wKSB7Ci0gICAgICAgIGZv cihqPTA7ajxidWZmX3NpemUmJmVtYWlsW2ldIT0wJiZlbWFpbFtpXSE9J0AnOysraSwrK2opIHsK LSAgICAgICAgICAgIGRvbWFpbltqXSA9IGVtYWlsW2ldOwotICAgICAgICB9Ci0gICAgICAgIGRv bWFpbltqXSA9IDA7Ci0gICAgICAgIGxvd2VyaXQoZG9tYWluKTsKLSAgICB9Ci0KLSAgICBpZiAo IGlzX3VzZXJuYW1lX3ZhbGlkKCB1c2VyICkgIT0gMCApIHsKLSAgICAgICBwcmludGYoInVzZXIg aW52YWxpZCAlc1xuIiwgdXNlcik7Ci0gICAgICAgcmV0dXJuKC0xKTsKLSAgICB9CisgIH0KIAot ICAgIGlmICggaXNfZG9tYWluX3ZhbGlkKCBkb21haW4gKSAhPSAwICkgewotICAgICAgIHByaW50 ZigiZG9tYWluIGludmFsaWQgJXNcbiIsIGRvbWFpbik7Ci0gICAgICAgcmV0dXJuKC0xKTsKLSAg ICB9CisgIGlmICggaXNfdXNlcm5hbWVfdmFsaWQoIHVzZXIgKSAhPSAwICkgeworICAgIHByaW50 ZigidXNlciBpbnZhbGlkICVzXG4iLCB1c2VyKTsKKyAgICByZXR1cm4oLTEpOworICB9CiAKLSAg ICAvKiBpZiB0aGUgZG9tYWluIGlzIGJsYW5rIHB1dCBpbiB0aGUgZGVmYXVsdCBkb21haW4gCi0g ICAgICogaWYgaXQgd2FzIGNvbmZpZ3VyZWQgd2l0aCAtLWVuYWJsZS1kZWZhdWx0LWRvbWFpbj1z b21ldGhpbmcKLSAgICAgKi8KLSAgICB2c2V0X2RlZmF1bHRfZG9tYWluKGRvbWFpbik7CisgIGlm ICggaXNfZG9tYWluX3ZhbGlkKCBkb21haW4gKSAhPSAwICkgeworICAgIHByaW50ZigiZG9tYWlu IGludmFsaWQgJXNcbiIsIGRvbWFpbik7CisgICAgcmV0dXJuKC0xKTsKKyAgfQogCi0gICAgdmdl dF9yZWFsX2RvbWFpbihkb21haW4sIGJ1ZmZfc2l6ZSk7CisgIC8qIGlmIHRoZSBkb21haW4gaXMg YmxhbmsgcHV0IGluIHRoZSBkZWZhdWx0IGRvbWFpbiAKKyAgICogaWYgaXQgd2FzIGNvbmZpZ3Vy ZWQgd2l0aCAtLWVuYWJsZS1kZWZhdWx0LWRvbWFpbj1zb21ldGhpbmcKKyAgICovCisgIHZzZXRf ZGVmYXVsdF9kb21haW4oZG9tYWluKTsKKyAgdmdldF9yZWFsX2RvbWFpbihkb21haW4sIGJ1ZmZf c2l6ZSk7CiAKLSAgICByZXR1cm4oMCk7CisgIHJldHVybigwKTsKIH0gCiAKIC8qCg==